Fixed bug #1501 : Interactive mode is broken

Author: gsherwood

package.xml

@@ -70,6 +70,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - Fixed bug #1495 : Setting an invalid installed path breaks all commands
   - Fixed bug #1496 : Squiz.Strings.DoubleQuoteUsage not unescaping dollar sign when fixing
     -- Thanks to Michał Bundyra for the patch
+  - Fixed bug #1501 : Interactive mode is broken
  </notes>
  <contents>
   <dir name="/">

src/Reporter.php

@@ -129,6 +129,8 @@ public function __construct(Config $config)
 
             if ($output === null) {
                 // Using a temp file.
+                // This needs to be set in the constructor so that all
+                // child procs use the same report file when running in parallel.
                 $this->tmpFiles[$type] = tempnam(sys_get_temp_dir(), 'phpcs');
                 file_put_contents($this->tmpFiles[$type], '');
             } else {
@@ -223,6 +225,7 @@ public function printReport($report)
             echo $generatedReport;
             if ($filename !== null && file_exists($filename) === true) {
                 unlink($filename);
+                unset($this->tmpFiles[$report]);
             }
         }
 
@@ -265,6 +268,14 @@ public function cacheFileReport(File $phpcsFile)
 
             if ($report['output'] === null) {
                 // Using a temp file.
+                if (isset($this->tmpFiles[$type]) === false) {
+                    // When running in interactive mode, the reporter prints the full
+                    // report many times, which will unlink the temp file. So we need
+                    // to create a new one if it doesn't exist.
+                    $this->tmpFiles[$type] = tempnam(sys_get_temp_dir(), 'phpcs');
+                    file_put_contents($this->tmpFiles[$type], '');
+                }
+
                 file_put_contents($this->tmpFiles[$type], $generatedReport, FILE_APPEND);
             } else {
                 $flags = FILE_APPEND;

src/Runner.php

@@ -98,9 +98,9 @@ public function runPHPCS()
         // so we hard-code the full report here and when outputting.
         // We also ensure parallel processing is off because we need to do one file at a time.
         if ($this->config->interactive === true) {
-            $this->config->reports     = array('full' => null);
-            $this->config->parallel    = 1;
-            $this->config->showProcess = false;
+            $this->config->reports      = array('full' => null);
+            $this->config->parallel     = 1;
+            $this->config->showProgress = false;
         }
 
         // Disable caching if we are processing STDIN as we can't be 100%
@@ -591,9 +591,6 @@ public function processFile($file)
 
         $this->reporter->cacheFileReport($file, $this->config);
 
-        // Clean up the file to save (a lot of) memory.
-        $file->cleanUp();
-
         if ($this->config->interactive === true) {
             /*
                 Running interactively.
@@ -633,6 +630,9 @@ public function processFile($file)
             }//end while
         }//end if
 
+        // Clean up the file to save (a lot of) memory.
+        $file->cleanUp();
+
     }//end processFile()