Generic LowerCaseConstantSniff and UpperCaseConstantSniff no longer report errors on classes named True, False or Null

Author: gsherwood

CodeSniffer/Standards/Generic/Sniffs/PHP/LowerCaseConstantSniff.php

@@ -75,6 +75,14 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
             return;
         }
 
+        // Is this a class name?
+        if ($tokens[$prevPtr]['code'] === T_CLASS
+            || $tokens[$prevPtr]['code'] === T_EXTENDS
+            || $tokens[$prevPtr]['code'] === T_IMPLEMENTS
+        ) {
+            return;
+        }
+
         // Class or namespace?
         if ($tokens[($stackPtr - 1)]['code'] === T_NS_SEPARATOR) {
             return;

CodeSniffer/Standards/Generic/Sniffs/PHP/UpperCaseConstantSniff.php

@@ -66,6 +66,14 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
             return;
         }
 
+        // Is this a class name?
+        if ($tokens[$prevPtr]['code'] === T_CLASS
+            || $tokens[$prevPtr]['code'] === T_EXTENDS
+            || $tokens[$prevPtr]['code'] === T_IMPLEMENTS
+        ) {
+            return;
+        }
+
         // Class or namespace?
         if ($tokens[($stackPtr - 1)]['code'] === T_NS_SEPARATOR) {
             return;

CodeSniffer/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.inc

@@ -52,4 +52,6 @@ $x->NULL = 7;
 
 use Zend\Log\Writer\NULL as NullWriter;
 new \Zend\Log\Writer\NULL()
+
+class True extends Null implements False {}
 ?>

CodeSniffer/Standards/Generic/Tests/PHP/UpperCaseConstantUnitTest.inc

@@ -53,4 +53,6 @@ $x->null = 7;
 use Zend\Log\Writer\Null as NullWriter;
 new \Zend\Log\Writer\Null()
 
+class True extends Null implements False {}
+
 ?>

package.xml

@@ -41,6 +41,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - AbstractPatternSniff now sets the ignoreComments option using a public var rather than through the constructor
     -- This allows the setting to be overwritten in ruleset.xml files
     -- Old method remains for backwards compatibility
+  - Generic LowerCaseConstantSniff and UpperCaseConstantSniff no longer report errors on classes named True, False or Null
   - PEAR ValidFunctionNameSniff no longer enforces exact case matching for PHP magic methods
   - Squiz SwitchDeclarationSniff now allows RETURN statements to close a CASE or DEFAULT statement
   - Squiz BlockCommentSniff now correctly reports an error for blank lines before blocks at the start of a control structure