Skip to content

Commit e73bc0f

Browse files
committed
Merge branch 'feature/generic-lineendings-check-short-echo-tag' of https://github.com/jrfnl/PHP_CodeSniffer
2 parents e33c49e + 002e4cc commit e73bc0f

File tree

7 files changed

+37
-21
lines changed

7 files changed

+37
-21
lines changed

.gitattributes

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@ scripts/ export-ignore
1111
# Declare files that should always have CRLF line endings on checkout.
1212
*WinTest.inc text eol=crlf
1313
*WinTest.php text eol=crlf
14+
src/Standards/Generic/Tests/Files/LineEndingsUnitTest*.inc text eol=crlf

package.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -590,8 +590,10 @@ http://pear.php.net/dtd/package-2.0.xsd">
590590
<file baseinstalldir="PHP/CodeSniffer" name="InlineHTMLUnitTest.php" role="test" />
591591
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.css" role="test" />
592592
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.css.fixed" role="test" />
593-
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.inc" role="test" />
594-
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.inc.fixed" role="test" />
593+
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.1.inc" role="test" />
594+
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.1.inc.fixed" role="test" />
595+
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.2.inc" role="test" />
596+
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.2.inc.fixed" role="test" />
595597
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.js" role="test" />
596598
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.js.fixed" role="test" />
597599
<file baseinstalldir="PHP/CodeSniffer" name="LineEndingsUnitTest.php" role="test" />

src/Standards/Generic/Sniffs/Files/LineEndingsSniff.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,10 @@ class LineEndingsSniff implements Sniff
4141
*/
4242
public function register()
4343
{
44-
return [T_OPEN_TAG];
44+
return [
45+
T_OPEN_TAG,
46+
T_OPEN_TAG_WITH_ECHO,
47+
];
4548

4649
}//end register()
4750

Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
2-
<?php
3-
echo 'hi';
4-
?>
5-
6-
<?php
7-
echo 'hi';
8-
?>
9-
10-
<?php
11-
function foo()
12-
{
13-
$query->group('a.id,
14-
uc.name,
15-
ag.title,
16-
ua.name'
17-
);
18-
}
1+
2+
<?php
3+
echo 'hi';
4+
?>
5+
6+
<?php
7+
echo 'hi';
8+
?>
9+
10+
<?php
11+
function foo()
12+
{
13+
$query->group('a.id,
14+
uc.name,
15+
ag.title,
16+
ua.name'
17+
);
18+
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
2+
<?= 'hi'; ?>
3+
4+
<div>...more HTML...</div>
5+
<?= 'hi'; ?>
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
2+
<?= 'hi'; ?>
3+
4+
<div>...more HTML...</div>
5+
<?= 'hi'; ?>

0 commit comments

Comments
 (0)