gitbase/fs_error_test: add brokenNone constant

Also delete leftover from previous implementation

Signed-off-by: Javi Fontan <[email protected]>

Author: jfontan

fs_error_test.go

@@ -91,7 +91,7 @@ func brokenFS(
 	}
 
 	var brokenFS billy.Filesystem
-	if brokenType == 0 {
+	if brokenType == brokenNone {
 		brokenFS = dotFS
 	} else {
 		brokenFS = NewBrokenFS(brokenType, dotFS)
@@ -100,30 +100,6 @@ func brokenFS(
 	return brokenFS, nil
 }
 
-func brokenRepo(
-	brokenType brokenType,
-	fs billy.Filesystem,
-) (*git.Repository, error) {
-	dotFS, err := fs.Chroot(".git")
-	if err != nil {
-		return nil, err
-	}
-
-	var brokenFS billy.Filesystem
-	if brokenType == 0 {
-		brokenFS = dotFS
-	} else {
-		brokenFS = NewBrokenFS(brokenType, dotFS)
-	}
-
-	storage, err := filesystem.NewStorage(brokenFS)
-	if err != nil {
-		return nil, err
-	}
-
-	return git.Open(storage, fs)
-}
-
 func testTable(t *testing.T, tableName string, number int) {
 	require := require.New(t)
 
@@ -179,6 +155,8 @@ func (r *billyRepository) Path() string {
 type brokenType uint64
 
 const (
+	// no errors
+	brokenNone brokenType = 0
 	// packfile has read errors
 	brokenPackfile brokenType = 1 << iota
 	// there's no index for one packfile