Merge pull request #597 from BakeRolls/server-follow-symlink

Server follow symlinks when passed as an argument

Author: ajnavarro

_testdata/repositories-link

@@ -0,0 +1 @@
+./repositories

_testdata/repositories/repositories-link

@@ -0,0 +1 @@
+repositories-link

cmd/gitbase/command/server.go

@@ -295,6 +295,10 @@ func (c *Server) addMatch(match string) error {
 	if err != nil {
 		return err
 	}
+	root, err = filepath.EvalSymlinks(root)
+	if err != nil {
+		return err
+	}
 
 	initDepth := strings.Count(root, string(os.PathSeparator))
 	return filepath.Walk(root, func(path string, info os.FileInfo, err error) error {

cmd/gitbase/command/server_test.go

@@ -0,0 +1,25 @@
+package command
+
+import (
+	"testing"
+
+	"github.com/src-d/gitbase"
+	"github.com/stretchr/testify/require"
+)
+
+func TestAddMatch(t *testing.T) {
+	require := require.New(t)
+
+	expected := []struct {
+		path string
+		err  func(error, ...interface{})
+	}{
+		{"../../../_testdata/repositories/", require.NoError},
+		{"../../../_testdata/repositories-link/", require.NoError},
+		{"../../../_testdata/repositories-not-exist/", require.Error},
+	}
+	c := &Server{pool: gitbase.NewRepositoryPool(0)}
+	for _, e := range expected {
+		e.err(c.addMatch(e.path))
+	}
+}