Fix incorrect error handling in commitsIter.New

jfontan · jfontan · commit c86dad0372c4 · 2018-04-23T11:30:53.000+02:00
Signed-off-by: Javi Fontan &lt;jfontan@gmail.com&gt;
diff --git a/iterator.go b/iterator.go
@@ -783,9 +783,11 @@ func (i *commitsIter) New(ctx *sql.Context, repo *Repository) (ChainableIter, er
 			"error": err,
 		}).Error("unable to get commit iterator")
 
-		if session.SkipGitErrors {
+		if !session.SkipGitErrors {
 			return nil, err
 		}
+
+		commits = nil
 	}
 
 	return &commitsIter{

Original file line number	Diff line number	Diff line change
`@@ -783,9 +783,11 @@ func (i commitsIter) New(ctx sql.Context, repo *Repository) (ChainableIter, er`
`783`	`783`	`"error": err,`
`784`	`784`	`}).Error("unable to get commit iterator")`
`785`	`785`
`786`		`- if session.SkipGitErrors {`
	`786`	`+ if !session.SkipGitErrors {`
`787`	`787`	`return nil, err`
`788`	`788`	`}`
	`789`	`+`
	`790`	`+ commits = nil`
`789`	`791`	`}`
`790`	`792`
`791`	`793`	`return &commitsIter{`