Merge branch 'master' into fix/squash-unsquashable

Author: ajnavarro

Gopkg.lock

@@ -1,6 +1,6 @@
 [[constraint]]
   name = "gopkg.in/src-d/go-mysql-server.v0"
-  revision = "1fa8e98aab8f06ae1569c4d381ccc9d3051f761a"
+  revision = "9d10e7afd56a6a48477314a49079778ec2372d7e"
 
 [[constraint]]
   name = "github.com/jessevdk/go-flags"

Gopkg.toml

@@ -32,4 +32,4 @@ BigEndianInt32(len(marhsal(node))+marshal(node)+
 
 ## Standard functions
 
-You can check standard functions in [`go-mysql-server` documentation](https://github.com/src-d/go-mysql-server/tree/1fa8e98aab8f06ae1569c4d381ccc9d3051f761a#custom-functions).
+You can check standard functions in [`go-mysql-server` documentation](https://github.com/src-d/go-mysql-server/tree/9d10e7afd56a6a48477314a49079778ec2372d7e#custom-functions).

docs/using-gitbase/functions.md

@@ -10,4 +10,4 @@ Note that you can create an index either **on one or more columns** or **on a si
 
 You can find some more examples in the [examples](./examples.md#create-an-index-for-columns-on-a-table) section.
 
-See [go-mysql-server](https://github.com/src-d/go-mysql-server/tree/1fa8e98aab8f06ae1569c4d381ccc9d3051f761a#indexes) documentation for more details
+See [go-mysql-server](https://github.com/src-d/go-mysql-server/tree/9d10e7afd56a6a48477314a49079778ec2372d7e#indexes) documentation for more details

docs/using-gitbase/indexes.md

@@ -1,3 +1,3 @@
 ## Supported syntax
 
-To see the SQL subset currently supported take a look at [this list](https://github.com/src-d/go-mysql-server/blob/1fa8e98aab8f06ae1569c4d381ccc9d3051f761a/SUPPORTED.md) from [src-d/go-mysql-server](https://github.com/src-d/go-mysql-server).
+To see the SQL subset currently supported take a look at [this list](https://github.com/src-d/go-mysql-server/blob/9d10e7afd56a6a48477314a49079778ec2372d7e/SUPPORTED.md) from [src-d/go-mysql-server](https://github.com/src-d/go-mysql-server).

docs/using-gitbase/supported-syntax.md

@@ -223,7 +223,7 @@ func TestSelectors(t *testing.T) {
 	require.True(selectors.isValid("d"))
 	vals, err := selectors.textValues("d")
 	require.NoError(err)
-	require.Equal(([]string)(nil), vals)
+	require.Equal([]string(nil), vals)
 
 	require.True(selectors.isValid("b"))
 	vals, err = selectors.textValues("b")
@@ -238,7 +238,7 @@ func TestSelectors(t *testing.T) {
 	require.False(selectors.isValid("c"))
 	vals, err = selectors.textValues("c")
 	require.NoError(err)
-	require.Equal(([]string)(nil), vals)
+	require.Equal([]string(nil), vals)
 }
 
 func TestClassifyFilters(t *testing.T) {

filters_test.go

@@ -230,7 +230,7 @@ func buildSquashedTable(
 	indexes map[string]sql.IndexLookup,
 ) (sql.Node, error) {
 	tableNames := orderedTableNames(tables)
-	allFilters := filters[:]
+	allFilters := filters
 
 	firstTable := tableNames[0]
 	var index sql.IndexLookup
@@ -1304,7 +1304,7 @@ func removeRedundantCompoundFilters(
 // isRedundantFilter tells whether the given filter is redundant for joining
 // t1 with t2. t1 MUST be higher in the table hierarchy than t2.
 func isRedundantFilter(f sql.Expression, t1, t2 string) bool {
-	switch true {
+	switch {
 	case t1 == gitbase.RepositoriesTableName && t2 == gitbase.RemotesTableName:
 		return isEq(
 			isCol(gitbase.RepositoriesTableName, "repository_id"),