-
Notifications
You must be signed in to change notification settings - Fork 0
Description
order_management_spring_boot/src/main/java/com/ecommerce/order/controller/CustomerController.java
Line 27 in 301b7d6
@GetMapping("/")
Not sure if the / is needed here
order_management_spring_boot/src/main/java/com/ecommerce/order/controller/OrderController.java
Line 28 in 301b7d6
return orderService.findAll(0, 5);
Why are the pagination values defaulted here?
order_management_spring_boot/src/main/java/com/ecommerce/order/service/CustomerService.java
Line 32 in 301b7d6
public Customer create(CreateCustomerDto customerDto) {
Why not use builder as we use Lombok instead of calling each setter?
order_management_spring_boot/src/main/java/com/ecommerce/order/service/CustomerService.java
Line 46 in 301b7d6
Customer customer = this.findOne(id);
Should we add an error check if the entity is not found?
order_management_spring_boot/src/main/java/com/ecommerce/order/service/CustomerService.java
Line 60 in 301b7d6
Customer customer = this.findOne(id);
same comment as above