Add autocomplete attribute

Author: srittau

NEWS.md

@@ -1,3 +1,9 @@
+# News in version 2.1.0
+
+## API Additions
+
+* Add `autocomplete` attribute to `Input`, `TextArea`, `Select`, and `Form`.
+
 # News in version 2.0.0
 
 ## API Additions

htmlgen/form.py

@@ -34,14 +34,15 @@ class Form(Element):
     """
 
     def __init__(self, method="GET", url=""):
-        super(Form, self).__init__("form")
+        super().__init__("form")
         self.method = method
         self.url = url
 
     method = html_attribute("method", default="GET")
     url = html_attribute("action", default="")
     target = html_attribute("target", "_self")
     encryption_type = html_attribute("enctype", _ENC_TYPE_URL_ENCODED)
+    autocomplete = html_attribute("autocomplete")
 
     def set_blank_target(self):
         self.target = "_blank"
@@ -80,7 +81,7 @@ def __init__(self, type_="text", name=""):
         submitting a form.
 
         """
-        super(Input, self).__init__("input")
+        super().__init__("input")
         self.type = type_
         self.name = name
 
@@ -89,6 +90,7 @@ def __init__(self, type_="text", name=""):
     readonly = boolean_html_attribute("readonly")
     disabled = boolean_html_attribute("disabled")
     type = html_attribute("type")
+    autocomplete = html_attribute("autocomplete")
     placeholder = html_attribute("placeholder")
     size = int_html_attribute("size")
     focus = boolean_html_attribute("autofocus")
@@ -380,14 +382,15 @@ class TextArea(Element):
     """
 
     def __init__(self, name=""):
-        super(TextArea, self).__init__("textarea")
+        super().__init__("textarea")
         self.name = name
 
     name = html_attribute("name", default="")
     readonly = boolean_html_attribute("readonly")
     disabled = boolean_html_attribute("disabled")
     columns = int_html_attribute("cols")
     rows = int_html_attribute("rows")
+    autocomplete = html_attribute("autocomplete")
     placeholder = html_attribute("placeholder")
 
 
@@ -417,11 +420,12 @@ class Select(Element):
     """
 
     def __init__(self, name=""):
-        super(Select, self).__init__("select")
+        super().__init__("select")
         self.name = name
 
     name = html_attribute("name", default="")
     disabled = boolean_html_attribute("disabled")
+    autocomplete = html_attribute("autocomplete")
 
     def create_group(self, label):
         """Create and append an option group."""

htmlgen/form.pyi

@@ -9,6 +9,7 @@ class Form(Element):
     url: str
     target: str
     encryption_type: str
+    autocomplete: Optional[str]
     multipart: bool
     def __init__(self, method: str = ..., url: str = ...) -> None: ...
     def set_blank_target(self) -> None: ...
@@ -19,6 +20,7 @@ class Input(VoidElement):
     readonly: bool
     disabled: bool
     type: str
+    autocomplete: Optional[str]
     placeholder: Optional[str]
     size: Optional[int]
     focus: bool
@@ -87,12 +89,14 @@ class TextArea(Element):
     disabled: bool
     columns: Optional[int]
     rows: Optional[int]
+    autocomplete: Optional[str]
     placeholder: Optional[str]
     def __init__(self, name: str = ...) -> None: ...
 
 class Select(Element):
     name: str
     disabled: bool
+    autocomplete: Optional[str]
     selected_option: Optional[Option]
     selected_value: Optional[str]
     def __init__(self, name: str = ...) -> None: ...

test_htmlgen/form.py

@@ -39,11 +39,23 @@ def test_implicit_arguments(self):
         assert_equal("PUT", form.method)
         assert_equal("/test", form.url)
         assert_equal("_self", form.target)
+        assert_is_none(form.autocomplete)
         assert_equal(
             [b'<form action="/test" method="PUT">', b"</form>"],
             list(iter(form)),
         )
 
+    def test_arguments(self):
+        form = Form("PUT", "/test")
+        form.autocomplete = "username"
+        assert_equal(
+            [
+                b'<form action="/test" autocomplete="username" method="PUT">',
+                b"</form>",
+            ],
+            list(iter(form)),
+        )
+
     def test_default_arguments(self):
         form = Form()
         assert_equal("GET", form.method)
@@ -90,13 +102,14 @@ def test_defaults(self):
 
     def test_attributes(self):
         input_ = Input()
-        input_.placeholder = "Foo"
         input_.size = 5
         input_.value = "My Value"
+        input_.autocomplete = "username"
+        input_.placeholder = "Foo"
         assert_equal(
             [
-                b'<input placeholder="Foo" size="5" type="text" '
-                b'value="My Value"/>'
+                b'<input autocomplete="username" placeholder="Foo" size="5" '
+                b'type="text" value="My Value"/>'
             ],
             list(iter(input_)),
         )
@@ -433,11 +446,20 @@ def test_without_name(self):
         text_area = TextArea()
         assert_equal("<textarea></textarea>", str(text_area))
 
+    def test_attributes(self):
+        text_area = TextArea()
+        text_area.autocomplete = "username"
+        assert_equal(
+            '<textarea autocomplete="username"></textarea>', str(text_area),
+        )
+
 
 class SelectTest(TestCase):
     def test_attributes(self):
         select = Select()
+        select.autocomplete = "username"
         assert_false(select.disabled)
+        assert_equal('<select autocomplete="username"></select>', str(select))
 
     def test_with_name(self):
         select = Select("my-name")