clab save fails for integrated Nokia SRSIM with components override

[joschel7]

Issue seen with different MDAs for SR-1.

See output below:

[root@rocker2 integrated]# clab ins
15:57:27 INFO Parsing & checking topology file=integrated.clab.yml
╭───────────────────────────────┬───────────────────────────────────────────────┬─────────┬───────────────────╮
│              Name             │                   Kind/Image                  │  State  │   IPv4/6 Address  │
├───────────────────────────────┼───────────────────────────────────────────────┼─────────┼───────────────────┤
│ clab-integrated-components    │ nokia_srsim                                   │ running │ 172.20.20.2       │
│                               │ registry.srlinux.dev/pub/nokia_srsim:25.10.R2 │         │ 3fff:172:20:20::2 │
├───────────────────────────────┼───────────────────────────────────────────────┼─────────┼───────────────────┤
│ clab-integrated-no-components │ nokia_srsim                                   │ running │ 172.20.20.3       │
│                               │ registry.srlinux.dev/pub/nokia_srsim:25.10.R2 │         │ 3fff:172:20:20::3 │
╰───────────────────────────────┴───────────────────────────────────────────────┴─────────┴───────────────────╯
[root@rocker2 integrated]# cat integrated.clab.yml
name: integrated

topology:
  kinds:
    nokia_srsim:
      license: /vsim_license/license_srsim.txt
      image: registry.srlinux.dev/pub/nokia_srsim:25.10.R2
  nodes:
    components:
      kind: nokia_srsim
      type: sr-1
      components:
        - mda:
          - slot: 1
            type: me16-25gb-sfp28+2-100gb-qsfp28
    no-components:
      kind: nokia_srsim
      type: sr-1


[root@rocker2 integrated]# clab save
15:57:35 INFO Parsing & checking topology file=integrated.clab.yml
15:57:35 ERRO node "components" save failed: failed to open netconf driver for [components.integrated.io]: dial tcp: lookup components.integrated.io on X.X.X.X:53: no such host
15:57:35 INFO Saved running configuration node=no-components addr=clab-integrated-no-components config-mode=model-driven
[root@rocker2 integrated]# ll clab-integrated/no-components/A/config/cf3/
total 14272
-rw-r--r--. 1 1001 1001     306 Feb 17 15:43 bof.cfg
-rw-r--r--. 1 1001 1001    2608 Feb 17 15:43 bootlog.txt
-rw-r--r--. 1 1001 1001   15689 Feb 17 15:57 config.cfg
-rw-r--r--. 1 1001 1001   15689 Feb 17 15:57 config.cfg.1
-rw-r--r--. 1 1001 1001   16215 Feb 17 15:43 config.cfg.10
-rw-r--r--. 1 1001 1001   15689 Feb 17 15:55 config.cfg.2
-rw-r--r--. 1 1001 1001   15689 Feb 17 15:53 config.cfg.3
-rw-r--r--. 1 1001 1001   15689 Feb 17 15:49 config.cfg.4
-rw-r--r--. 1 1001 1001   15689 Feb 17 15:48 config.cfg.5
-rw-r--r--. 1 1001 1001   15689 Feb 17 15:47 config.cfg.6
-rw-r--r--. 1 1001 1001   15689 Feb 17 15:44 config.cfg.7
-rw-r--r--. 1 1001 1001   15689 Feb 17 15:44 config.cfg.8
-rw-r--r--. 1 1001 1001   15689 Feb 17 15:43 config.cfg.9
-rwxr-xr-x. 1 1001 1001 8135904 Feb 17 15:43 i386-isa-aa.tim
-rw-r--r--. 1 1001 1001     927 Feb 17 15:43 license.txt
-rw-r--r--. 1 1001 1001     306 Feb 17 15:43 nvsys.info
-rw-r--r--. 1 1001 1001       1 Feb 17 15:43 restcntr.txt
-rwxr-xr-x. 1 1001 1001 6272432 Feb 17 15:43 yang.tim
[root@rocker2 integrated]# ll clab-integrated/components/A/config/cf3/
total 14128
-rw-r--r--. 1 1001 1001     306 Feb 17 15:43 bof.cfg
-rw-r--r--. 1 1001 1001    2608 Feb 17 15:43 bootlog.txt
-rw-r--r--. 1 1001 1001   15686 Feb 17 15:43 config.cfg
-rw-r--r--. 1 1001 1001   16212 Feb 17 15:43 config.cfg.1
-rwxr-xr-x. 1 1001 1001 8135904 Feb 17 15:43 i386-isa-aa.tim
-rw-r--r--. 1 1001 1001     927 Feb 17 15:43 license.txt
-rw-r--r--. 1 1001 1001     306 Feb 17 15:43 nvsys.info
-rw-r--r--. 1 1001 1001       1 Feb 17 15:43 restcntr.txt
-rwxr-xr-x. 1 1001 1001 6272432 Feb 17 15:43 yang.tim
[root@rocker2 integrated]#

[FloSch62]

@kaelemc

[kaelemc]

@sacckth Any reason we use the FQDN in the save? I think we can just use LongName instead.

This would fix that issue. I will PR it either in, or after Florian's start/stop PR since we touch a lot of srsim code there.

root@s01:~/containerlab# git --no-pager diff nodes/sros/sros.go 
diff --git a/nodes/sros/sros.go b/nodes/sros/sros.go
index d0c8f288a..d9a20bcea 100644
--- a/nodes/sros/sros.go
+++ b/nodes/sros/sros.go
@@ -1509,30 +1509,20 @@ func (n *sros) CheckInterfaceName() error {
 
 func (n *sros) SaveConfig(ctx context.Context) (*clabnodes.SaveConfigResult, error) {
        fqdn := ""
-       switch {
-       case n.isStandaloneNode():
-               // check if it is a cpm node. return without error if not
-               if !n.isCPM("") {
-                       return nil, nil
-               }
-               // if it is a standalone node use the fqdn
-               fqdn = n.Cfg.Fqdn
-       case n.isDistributedBaseNode():
-               // if it is the
+       if n.isDistributedBaseNode() {
                cmpNode, err := n.cpmNode()
                if err != nil {
                        return nil, err
                }
-               // delegate to cpm node
                return cmpNode.SaveConfig(ctx)
-       case n.isDistributedCardNode():
-               // check if it is a cpm node. return without error if not
-               if !n.isCPM("") {
-                       return nil, nil
-               }
-               fqdn = n.Cfg.LongName
        }
 
+       if !n.isCPM("") {
+               return nil, nil
+       }
+
+       fqdn = n.Cfg.LongName
+
        if err := n.saveConfigWithAddr(ctx, fqdn); err != nil {
                return nil, err
        }

[kaelemc]

@joschel7 since this is a bug, in the meantime the solution would have to be hardcoding that FQDN into the /etc/hosts. :(

[sacckth]

@sacckth Any reason we use the FQDN in the save? I think we can just use LongName instead.

This would fix that issue. I will PR it either in, or after Florian's start/stop PR since we touch a lot of srsim code there.

root@s01:~/containerlab# git --no-pager diff nodes/sros/sros.go
diff --git a/nodes/sros/sros.go b/nodes/sros/sros.go
index d0c8f288a..d9a20bcea 100644
--- a/nodes/sros/sros.go
+++ b/nodes/sros/sros.go
@@ -1509,30 +1509,20 @@ func (n *sros) CheckInterfaceName() error {

func (n *sros) SaveConfig(ctx context.Context) (*clabnodes.SaveConfigResult, error) {
fqdn := ""

•   switch {
  

•   case n.isStandaloneNode():
  

•           // check if it is a cpm node. return without error if not
  

•           if !n.isCPM("") {
  

•                   return nil, nil
  

•           }
  

•           // if it is a standalone node use the fqdn
  

•           fqdn = n.Cfg.Fqdn
  

•   case n.isDistributedBaseNode():
  

•           // if it is the
  

•   if n.isDistributedBaseNode() {
            cmpNode, err := n.cpmNode()
            if err != nil {
                    return nil, err
            }
  

•           // delegate to cpm node
            return cmpNode.SaveConfig(ctx)
  

•   case n.isDistributedCardNode():
  

•           // check if it is a cpm node. return without error if not
  

•           if !n.isCPM("") {
  

•                   return nil, nil
  

•           }
  

•           fqdn = n.Cfg.LongName
    }
  

•   if !n.isCPM("") {
  

•           return nil, nil
  

•   }
  

•   fqdn = n.Cfg.LongName
  

•   if err := n.saveConfigWithAddr(ctx, fqdn); err != nil {
            return nil, err
    }
  

Why not using the FQDN? The save command requires to connect to the node.