Skip to content

Commit 3e8578d

Browse files
authored
Fix CSR1000v and c8000v (#269)
* Remove whitespaces from IMG_NAME and IMG_VENDOR * Fix Cisco CSR1000v * Fix Cisco c8000v
1 parent b3a1ab5 commit 3e8578d

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

c8000v/Makefile

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
1-
VENDOR=Cisco
1+
VENDOR=cisco
22
NAME=c8000v
33
IMAGE_FORMAT=qcow2
44
IMAGE_GLOB=*.qcow2
55

66
# match versions like:
7-
# csr1000v-universalk9.16.03.01a.qcow2
8-
# csr1000v-universalk9.16.04.01.qcow2
7+
# c8000v-17.11.01a.qcow2
98
VERSION=$(shell echo $(IMAGE) | sed -e 's/.\+[^0-9]\([0-9]\+\.[0-9]\+\.[0-9]\+[a-z]\?\)\([^0-9].*\|$$\)/\1/')
109

1110
-include ../makefile-sanity.include
1211
-include ../makefile.include
1312
-include ../makefile-install.include
1413

1514
docker-build: docker-build-common
16-
docker run --cidfile cidfile --privileged $(REGISTRY)vr-$(VR_NAME):$(VERSION) --trace --install
17-
docker commit --change='ENTRYPOINT ["/launch.py"]' $$(cat cidfile) $(REGISTRY)vr-$(VR_NAME):$(VERSION)
15+
docker run --cidfile cidfile --privileged $(REGISTRY)$(VENDOR)_$(NAME):$(VERSION) --trace --install
16+
docker commit --change='ENTRYPOINT ["/launch.py"]' $$(cat cidfile) $(REGISTRY)$(VENDOR)_$(NAME):$(VERSION)
1817
docker rm -f $$(cat cidfile)

csr/Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
VENDOR=Cisco
2-
NAME=CSR1000v
1+
VENDOR=cisco
2+
NAME=csr1000v
33
IMAGE_FORMAT=qcow2
44
IMAGE_GLOB=*.qcow2
55

@@ -16,6 +16,6 @@ docker-pre-build:
1616
-rm cidfile
1717

1818
docker-build: docker-build-common
19-
docker run --cidfile cidfile --privileged $(REGISTRY)vr-$(VR_NAME):$(VERSION) --trace --install
20-
docker commit --change='ENTRYPOINT ["/launch.py"]' $$(cat cidfile) $(REGISTRY)vr-$(VR_NAME):$(VERSION)
19+
docker run --cidfile cidfile --privileged $(REGISTRY)$(VENDOR)_$(NAME):$(VERSION) --trace --install
20+
docker commit --change='ENTRYPOINT ["/launch.py"]' $$(cat cidfile) $(REGISTRY)$(VENDOR)_$(NAME):$(VERSION)
2121
docker rm -f $$(cat cidfile)

makefile.include

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
IMG_NAME=$(shell echo $(NAME) | tr '[:upper:]' '[:lower:]')
2-
IMG_VENDOR=$(shell echo $(VENDOR) | tr '[:upper:]' '[:lower:]')
1+
IMG_NAME=$(shell echo $(NAME) | tr '[:upper:]' '[:lower:]' | tr -d '[:space:]')
2+
IMG_VENDOR=$(shell echo $(VENDOR) | tr '[:upper:]' '[:lower:]' | tr -d '[:space:]')
33
IMAGES=$(shell ls $(IMAGE_GLOB) 2>/dev/null)
44
NUM_IMAGES=$(shell ls $(IMAGES) | wc -l)
55
VRNETLAB_VERION=$$(git log -1 --format=format:"Commit: %H from %aD")

0 commit comments

Comments
 (0)