check if MME-UE-S1AP-ID has been yet assigned before sending UL NAS Transport. If it hasn't log error and abort s1 tx.

frankist · frankist · commit 72bff83b6375 · 2021-05-10T15:35:28.000+01:00
diff --git a/srsenb/src/stack/upper/s1ap.cc b/srsenb/src/stack/upper/s1ap.cc
@@ -1385,7 +1385,8 @@ bool s1ap::ue::send_initialuemessage(asn1::s1ap::rrc_establishment_cause_e cause
 
 bool s1ap::ue::send_ulnastransport(srsran::unique_byte_buffer_t pdu)
 {
-  if (not s1ap_ptr->mme_connected) {
+  if (not ctxt.mme_ue_s1ap_id.has_value()) {
+    logger.error("Trying to send UL NAS Transport message for rnti=0x%x without MME-S1AP-UE-ID", ctxt.rnti);
     return false;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1385,7 +1385,8 @@ bool s1ap::ue::send_initialuemessage(asn1::s1ap::rrc_establishment_cause_e cause`
`1385`	`1385`
`1386`	`1386`	`bool s1ap::ue::send_ulnastransport(srsran::unique_byte_buffer_t pdu)`
`1387`	`1387`	`{`
`1388`		`- if (not s1ap_ptr->mme_connected) {`
	`1388`	`+ if (not ctxt.mme_ue_s1ap_id.has_value()) {`
	`1389`	`+ logger.error("Trying to send UL NAS Transport message for rnti=0x%x without MME-S1AP-UE-ID", ctxt.rnti);`
`1389`	`1390`	`return false;`
`1390`	`1391`	`}`
`1391`	`1392`