Skip to content

Commit 0200d4b

Browse files
FabianEckermanncodebot
authored andcommitted
cu_cp,ue_manager: Add explicit conversion to prevent -Werror=sign-compare
1 parent 13a144b commit 0200d4b

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

tests/unittests/cu_cp/ue_manager/ue_manager_test.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,8 @@ TEST_F(ue_manager_test, when_multiple_ues_added_then_ues_exist)
168168
ue_mng_logger.set_level(srslog::basic_levels::warning);
169169
test_logger.set_level(srslog::basic_levels::warning);
170170

171-
for (unsigned it = to_value(rnti_t::MIN_CRNTI); it < to_value(rnti_t::MIN_CRNTI) + MAX_NOF_UES_PER_DU; it++) {
171+
for (unsigned it = to_value(rnti_t::MIN_CRNTI); it < unsigned(to_value(rnti_t::MIN_CRNTI) + MAX_NOF_UES_PER_DU);
172+
it++) {
172173
rnti_t rnti = to_rnti(it);
173174
ue_index_t ue_index = ue_mng.allocate_new_ue_index(du_index);
174175
auto* ue = ue_mng.add_ue(ue_index, MIN_PCI, rnti);
@@ -209,7 +210,8 @@ TEST_F(ue_manager_test, when_more_than_max_ues_added_then_ue_not_created)
209210
ue_mng_logger.set_level(srslog::basic_levels::warning);
210211
test_logger.set_level(srslog::basic_levels::warning);
211212

212-
for (unsigned it = to_value(rnti_t::MIN_CRNTI); it < to_value(rnti_t::MIN_CRNTI) + MAX_NOF_UES_PER_DU; it++) {
213+
for (unsigned it = to_value(rnti_t::MIN_CRNTI); it < unsigned(to_value(rnti_t::MIN_CRNTI) + MAX_NOF_UES_PER_DU);
214+
it++) {
213215
rnti_t rnti = to_rnti(it);
214216
ue_index_t ue_index = ue_mng.allocate_new_ue_index(du_index);
215217
auto* ue = ue_mng.add_ue(ue_index, MIN_PCI, rnti);
@@ -356,7 +358,8 @@ TEST_F(ue_manager_test, when_multiple_ngap_ues_added_then_ues_exist)
356358
for (unsigned du_idx = du_index_to_uint(du_index_t::min); du_idx <= du_index_to_uint(du_index_t::max); du_idx++) {
357359
unsigned du_offset = du_idx * MAX_NOF_UES_PER_DU;
358360

359-
for (unsigned it = to_value(rnti_t::MIN_CRNTI); it < to_value(rnti_t::MIN_CRNTI) + MAX_NOF_UES_PER_DU; it++) {
361+
for (unsigned it = to_value(rnti_t::MIN_CRNTI); it < unsigned(to_value(rnti_t::MIN_CRNTI) + MAX_NOF_UES_PER_DU);
362+
it++) {
360363
ue_index_t ue_index = create_ue(uint_to_du_index(du_idx), MIN_PCI, to_rnti(du_offset + it));
361364
auto* ue = ue_mng.add_ue(ue_index, rrc_ue_pdu_notifier, rrc_ue_pdu_notifier, *du_processor_ctrl_notifier);
362365

@@ -390,7 +393,8 @@ TEST_F(ue_manager_test, when_more_than_max_ues_added_then_ngap_ue_not_created)
390393
for (unsigned du_idx = du_index_to_uint(du_index_t::min); du_idx <= du_index_to_uint(du_index_t::max); du_idx++) {
391394
unsigned du_offset = du_idx * MAX_NOF_UES_PER_DU;
392395

393-
for (unsigned it = to_value(rnti_t::MIN_CRNTI); it < to_value(rnti_t::MIN_CRNTI) + MAX_NOF_UES_PER_DU; it++) {
396+
for (unsigned it = to_value(rnti_t::MIN_CRNTI); it < unsigned(to_value(rnti_t::MIN_CRNTI) + MAX_NOF_UES_PER_DU);
397+
it++) {
394398
ue_index_t ue_index = create_ue(uint_to_du_index(du_idx), MIN_PCI, to_rnti(du_offset + it));
395399
auto* ue = ue_mng.add_ue(ue_index, rrc_ue_pdu_notifier, rrc_ue_pdu_notifier, *du_processor_ctrl_notifier);
396400

0 commit comments

Comments
 (0)