pdcp: methods of final classes don't need to be declared as final

Author: robertfalkenberg

lib/pdcp/pdcp_entity_rx.h

@@ -91,7 +91,7 @@ class pdcp_entity_rx final : public pdcp_entity_tx_rx_base,
   /*
    * Security configuration
    */
-  void configure_security(security::sec_128_as_config sec_cfg_) final
+  void configure_security(security::sec_128_as_config sec_cfg_) override
   {
     srsran_assert((is_srb() && sec_cfg_.domain == security::sec_domain::rrc) ||
                       (is_drb() && sec_cfg_.domain == security::sec_domain::up),
@@ -121,7 +121,7 @@ class pdcp_entity_rx final : public pdcp_entity_tx_rx_base,
     logger.log_info("128 K_enc: {}", sec_cfg.k_128_enc);
   }
 
-  void set_integrity_protection(security::integrity_enabled integrity_enabled_) final
+  void set_integrity_protection(security::integrity_enabled integrity_enabled_) override
   {
     if (integrity_enabled_ == security::integrity_enabled::on) {
       if (!sec_cfg.k_128_int.has_value()) {
@@ -136,7 +136,7 @@ class pdcp_entity_rx final : public pdcp_entity_tx_rx_base,
     integrity_enabled = integrity_enabled_;
     logger.log_info("Set integrity_enabled={}", integrity_enabled);
   }
-  void set_ciphering(security::ciphering_enabled ciphering_enabled_) final
+  void set_ciphering(security::ciphering_enabled ciphering_enabled_) override
   {
     ciphering_enabled = ciphering_enabled_;
     logger.log_info("Set ciphering_enabled={}", ciphering_enabled);

lib/pdcp/pdcp_entity_tx.h

@@ -109,7 +109,7 @@ class pdcp_entity_tx final : public pdcp_entity_tx_rx_base,
   /*
    * SDU/PDU handlers
    */
-  void handle_sdu(byte_buffer sdu) final;
+  void handle_sdu(byte_buffer sdu) override;
 
   void handle_transmit_notification(uint32_t notif_sn) override;
   void handle_delivery_notification(uint32_t notif_sn) override;
@@ -124,7 +124,7 @@ class pdcp_entity_tx final : public pdcp_entity_tx_rx_base,
   void handle_status_report(byte_buffer_chain status);
 
   // Status handler interface
-  void on_status_report(byte_buffer_chain status) final { handle_status_report(std::move(status)); }
+  void on_status_report(byte_buffer_chain status) override { handle_status_report(std::move(status)); }
 
   /*
    * Header helpers
@@ -153,7 +153,7 @@ class pdcp_entity_tx final : public pdcp_entity_tx_rx_base,
    */
   void configure_security(security::sec_128_as_config sec_cfg,
                           security::integrity_enabled integrity_enabled_,
-                          security::ciphering_enabled ciphering_enabled_) final;
+                          security::ciphering_enabled ciphering_enabled_) override;
 
   /// Sends a status report, as specified in TS 38.323, Sec. 5.4.
   void send_status_report();