cu_up: add unit test for n3_ext_addr

Author: robertfalkenberg

tests/unittests/cu_up/pdu_session_manager_test.cpp

@@ -16,7 +16,7 @@ using namespace srsran;
 using namespace srs_cu_up;
 
 /// PDU session handling tests (creation/deletion)
-TEST_F(pdu_session_manager_test, when_valid_pdu_session_setup_item_session_can_be_added)
+TEST_P(pdu_session_manager_test_set_n3_ext_addr, when_valid_pdu_session_setup_item_session_can_be_added)
 {
   // no sessions added yet
   ASSERT_EQ(pdu_session_mng->get_nof_pdu_sessions(), 0);
@@ -35,6 +35,10 @@ TEST_F(pdu_session_manager_test, when_valid_pdu_session_setup_item_session_can_b
   // check successful outcome
   ASSERT_TRUE(setup_result.success);
   ASSERT_EQ(setup_result.gtp_tunnel.gtp_teid.value(), 1);
+  const std::string tp_address_expect = net_config.n3_ext_addr.empty() || net_config.n3_ext_addr == "auto"
+                                            ? net_config.n3_bind_addr
+                                            : net_config.n3_ext_addr;
+  ASSERT_EQ(setup_result.gtp_tunnel.tp_address.to_string(), tp_address_expect);
   ASSERT_EQ(setup_result.drb_setup_results[0].gtp_tunnel.gtp_teid.value(), 0);
   ASSERT_EQ(pdu_session_mng->get_nof_pdu_sessions(), 1);
 
@@ -387,6 +391,10 @@ TEST_F(pdu_session_manager_test, when_new_ul_info_is_requested_f1u_is_disconnect
   ASSERT_EQ(pdu_session_mng->get_nof_pdu_sessions(), 1);
 }
 
+INSTANTIATE_TEST_SUITE_P(pdu_session_manager_test_n3_ext_addr,
+                         pdu_session_manager_test_set_n3_ext_addr,
+                         ::testing::Values("", "auto", "1.2.3.4"));
+
 int main(int argc, char** argv)
 {
   ::testing::InitGoogleTest(&argc, argv);

tests/unittests/cu_up/pdu_session_manager_test.h

@@ -18,11 +18,16 @@
 using namespace srsran;
 using namespace srs_cu_up;
 
-/// Fixture class for UE manager tests
-class pdu_session_manager_test : public ::testing::Test
+const network_interface_config net_config_default = {};
+
+/// Fixture base class for PDU session manager tests
+class pdu_session_manager_test_base
 {
 protected:
-  void SetUp() override
+  virtual ~pdu_session_manager_test_base()          = default;
+  virtual network_interface_config get_net_config() = 0;
+
+  void init()
   {
     srslog::fetch_basic_logger("TEST").set_level(srslog::basic_levels::debug);
     srslog::init();
@@ -42,6 +47,7 @@ class pdu_session_manager_test : public ::testing::Test
 
     manual_task_worker teid_worker{128};
 
+    net_config      = get_net_config();
     pdu_session_mng = std::make_unique<pdu_session_manager_impl>(MIN_UE_INDEX,
                                                                  qos,
                                                                  security_info,
@@ -63,7 +69,7 @@ class pdu_session_manager_test : public ::testing::Test
                                                                  gtpu_pcap);
   }
 
-  void TearDown() override
+  void finish()
   {
     // flush logger after each test
     srslog::flush();
@@ -86,6 +92,30 @@ class pdu_session_manager_test : public ::testing::Test
   cu_up_ue_logger                                      logger{"CU-UP", {MIN_UE_INDEX}};
 };
 
+/// Fixture class for PDU session manager tests with default network interface config
+class pdu_session_manager_test : public pdu_session_manager_test_base, public ::testing::Test
+{
+protected:
+  network_interface_config get_net_config() override { return net_config_default; }
+  void                     SetUp() override { init(); }
+  void                     TearDown() override { finish(); }
+};
+
+/// Fixture class for PDU session manager tests with configurable N3 ext addr
+class pdu_session_manager_test_set_n3_ext_addr : public pdu_session_manager_test_base,
+                                                 public ::testing::TestWithParam<const char*>
+{
+protected:
+  network_interface_config get_net_config() override
+  {
+    network_interface_config cfg = net_config_default;
+    cfg.n3_ext_addr              = GetParam();
+    return cfg;
+  }
+  void SetUp() override { init(); }
+  void TearDown() override { finish(); }
+};
+
 inline e1ap_pdu_session_res_to_setup_item
 generate_pdu_session_res_to_setup_item(pdu_session_id_t psi, drb_id_t drb_id, qos_flow_id_t qfi, five_qi_t five_qi)
 {