Update main

# Conflicts:
#	tests/unittests/phy/upper/channel_processors/prach_detector_test_data.tar.gz
#	tests/unittests/phy/upper/channel_processors/pucch_processor_format0_test_data.tar.gz
#	tests/unittests/phy/upper/signal_processors/port_channel_estimator_test_data.tar.gz

Author: codebot

.gitlab/ci/build.yml

@@ -2033,6 +2033,7 @@ custom build:
     - *build_after_script
   artifacts:
     <<: *build_artifacts
+    expire_in: 4 hours
   cache:
     - !reference [.fetch_src_cache, cache]
     - *cache_build_get

.gitlab/ci/e2e.yml

@@ -18,8 +18,10 @@ variables:
       - "zmq"
       - "zmq_deb"
       - "zmq_single_ue"
+      - "zmq_2x2_mimo"
       - "zmq_4x4_mimo"
       - "zmq_srsue"
+      - "zmq_cudu"
       - "rf_b200"
       - "rf_hp"
       - "android_b200"
@@ -286,6 +288,20 @@ amari 1UE:
     - *txrx-lib
     - *retina-needs
 
+amari 1UE 2x2 mimo:
+  extends: .zmq
+  variables:
+    TESTBED: "zmq_2x2_mimo"
+    MARKERS: "zmq_2x2_mimo"
+    E2E_LOG_LEVEL: "info"
+    RETINA_PARAM_ARGS: "gnb.all.pcap=True gnb.all.rlc_enable=False gnb.all.enable_integrity_protection=True"
+  needs:
+    - job: "basic relwithdeb"
+      artifacts: true
+    - *txrx-lib
+    - *retina-needs
+  allow_failure: true
+
 amari 1UE 4x4 mimo:
   extends: .zmq
   variables:
@@ -549,6 +565,7 @@ validate n300 config:
   variables:
     MARKERS: "rf_n300"
     TESTBED: "android_n300"
+  allow_failure: true
 
 ################################################################################
 # Android
@@ -586,6 +603,7 @@ android n300:
   extends: android x300
   variables:
     TESTBED: "android_n300"
+  allow_failure: true
 
 ################################################################################
 # VIAVI

.gitlab/ci/e2e/.env

@@ -1,6 +1,6 @@
 SRSGNB_REGISTRY_URI=registry.gitlab.com/softwareradiosystems/srsgnb
 RETINA_REGISTRY_PREFIX=registry.gitlab.com/softwareradiosystems/ci/retina
-RETINA_VERSION=0.51.10
+RETINA_VERSION=0.51.15
 UBUNTU_VERSION=24.04
 AMARISOFT_VERSION=2023-09-08
 SRSUE_VERSION=23.11

.gitlab/ci/e2e/retina_request_zmq_2x2_mimo.yml

@@ -0,0 +1,79 @@
+#
+# Copyright 2013-2024 Software Radio Systems Limited
+#
+# By using this file, you agree to the terms and conditions set
+# forth in the LICENSE file which can be found at the top level of
+# the distribution.
+#
+
+- name: amarisoft-ue
+  type: ue
+  image: ${RETINA_REGISTRY_PREFIX}/amarisoftue:${AMARISOFT_VERSION}_${RETINA_VERSION}
+  labels: 
+    - ${ZMQ_HOSTLABEL_1}
+  nof_ports: 32
+  requirements:
+    arch: amd64
+    cpu:
+      requests: 5
+      limits: 5
+    memory:
+      requests: "26G"
+      limits: "26G"
+    ephemeral-storage:
+      requests: "6G"
+      limits: "6G"
+  resources:
+    - type: zmq
+      nof_antennas_dl: 2
+      nof_antennas_ul: 2
+    - type: license
+      model: amarisoft-5g
+  shared_files:
+    - local_path: ${AMARISOFT_TXRX_BINARY_PATH}
+      remote_path: /opt/lteue/trx_srsran.so
+      is_executable: true
+
+- name: srs-gnb
+  type: gnb
+  image: ${RETINA_REGISTRY_PREFIX}/srsgnb:${RETINA_VERSION}
+  labels: 
+    - ${ZMQ_HOSTLABEL_1}
+  requirements:
+    arch: amd64
+    cpu:
+      requests: 5
+      limits: 5
+    memory:
+      requests: "26G"
+      limits: "26G"
+    ephemeral-storage:
+      requests: "6G"
+      limits: "6G"
+  resources:
+    - type: zmq
+      nof_antennas_dl: 2
+      nof_antennas_ul: 2
+  environment:
+    - PATH: ${PATH}:/builds/softwareradiosystems/srsgnb/build/apps/gnb
+  shared_files:
+    - local_path: ${GNB_BINARY_PATH}
+      remote_path: /usr/local/bin/gnb
+      is_executable: true
+
+- name: open5gs
+  type: 5gc
+  requirements:
+    arch: amd64
+    cpu:
+      requests: 1
+      limits: 1
+    memory:
+      requests: "8G"
+      limits: "8G"
+    ephemeral-storage:
+      requests: "6G"
+      limits: "6G"
+  image: ${RETINA_REGISTRY_PREFIX}/open5gs:${OPEN5GS_VERSION}_${RETINA_VERSION}
+  labels: 
+    - ${ZMQ_HOSTLABEL_1}

.gitlab/ci/trx.yml

@@ -78,7 +78,7 @@ build trx driver:
   artifacts: &trx_artifacts
     paths:
       - build_trx_srsran/libtrx_srsran.so
-    expire_in: 10 minutes
+    expire_in: 4 hours
 
 build amariue zmq driver:
   extends: build trx driver

apps/cu/cu.cpp

@@ -292,7 +292,7 @@ int main(int argc, char** argv)
   sctp_network_gateway_config f1c_sctp_cfg = {};
   f1c_sctp_cfg.if_name                     = "F1-C";
   f1c_sctp_cfg.bind_address                = cu_cfg.f1ap_cfg.bind_addr;
-  f1c_sctp_cfg.bind_port                   = 38471;
+  f1c_sctp_cfg.bind_port                   = F1AP_PORT;
   f1c_sctp_cfg.ppid                        = F1AP_PPID;
   f1c_cu_sctp_gateway_config f1c_server_cfg({f1c_sctp_cfg, *epoll_broker, *cu_cp_dlt_pcaps.f1ap});
   std::unique_ptr<srs_cu_cp::f1c_connection_server> cu_f1c_gw = srsran::create_f1c_gateway_server(f1c_server_cfg);

apps/du/adapters/f1_gateways.h

@@ -36,7 +36,7 @@ std::unique_ptr<srs_du::f1c_connection_client> create_f1c_client_gateway(const s
   f1c_sctp.if_name         = "F1-C";
   f1c_sctp.dest_name       = "CU-CP";
   f1c_sctp.connect_address = cu_cp_addr;
-  f1c_sctp.connect_port    = 38471;
+  f1c_sctp.connect_port    = F1AP_PORT;
   f1c_sctp.ppid            = F1AP_PPID;
   f1c_sctp.bind_address    = bind_addr;
   return create_f1c_gateway_client(f1c_du_sctp_gateway_config{f1c_sctp, broker, f1ap_pcap});

apps/gnb/gnb.cpp

@@ -184,6 +184,26 @@ static void register_app_logs(const logger_appconfig&         log_cfg,
   register_dynamic_du_loggers(du_loggers);
 }
 
+static void autoderive_slicing_args(dynamic_du_unit_config& du_unit_cfg, cu_cp_unit_config& cu_cp_config)
+{
+  std::vector<s_nssai_t> du_slices;
+  for (const auto& cell_cfg : du_unit_cfg.du_high_cfg.config.cells_cfg) {
+    for (const auto& slice : cell_cfg.cell.slice_cfg) {
+      if (du_slices.end() == std::find(du_slices.begin(), du_slices.end(), slice.s_nssai)) {
+        du_slices.push_back(slice.s_nssai);
+      }
+    }
+  }
+  // NOTE: A CU-CP can serve more slices than slices configured in the DU cells.
+  // [Implementation-defined] Ensure that all slices served by DU cells are part of CU-CP served slices.
+  for (const auto& slice : du_slices) {
+    if (cu_cp_config.slice_cfg.end() ==
+        std::find(cu_cp_config.slice_cfg.begin(), cu_cp_config.slice_cfg.end(), slice)) {
+      cu_cp_config.slice_cfg.push_back(slice);
+    }
+  }
+}
+
 int main(int argc, char** argv)
 {
   // Set the application error handler.
@@ -225,6 +245,7 @@ int main(int argc, char** argv)
   // Set the callback for the app calling all the autoderivation functions.
   app.callback([&app, &gnb_cfg, &du_unit_cfg, &cu_cp_config]() {
     autoderive_gnb_parameters_after_parsing(app, gnb_cfg);
+    autoderive_slicing_args(du_unit_cfg, cu_cp_config);
     autoderive_dynamic_du_parameters_after_parsing(app, du_unit_cfg);
 
     // Create the PLMN and TAC list from the cells.

apps/services/metrics_log_helper.cpp

@@ -133,6 +133,7 @@ void metrics_log_helper::report_metrics(const rlc_metrics& metrics)
   fmt::format_to(buffer, " du={}", metrics.du_index);
   fmt::format_to(buffer, " ue={}", metrics.ue_index);
   fmt::format_to(buffer, " rb={}", metrics.rb_id);
+  fmt::format_to(buffer, " mode={}", metrics.rx.mode);
   fmt::format_to(buffer, " TX=[{}]", format_rlc_tx_metrics(metrics.metrics_period, metrics.tx));
   fmt::format_to(buffer, " RX=[{}]  ", format_rlc_rx_metrics(metrics.metrics_period, metrics.rx));
   logger.debug("{}", to_c_str(buffer));

apps/services/rlc_metrics_plotter_json.cpp

@@ -96,17 +96,17 @@ void rlc_metrics_plotter_json::report_metrics(const rlc_metrics& drb)
   ctx.get<mlist_drbs>().emplace_back();
   auto& output = ctx.get<mlist_drbs>().back();
 
-  output.write<metric_du_id>(drb.du_index);
+  output.write<metric_du_id>(static_cast<uint32_t>(drb.du_index));
   output.write<metric_ue_id>(drb.ue_index);
   output.write<metric_drb_id>(static_cast<uint8_t>(drb.rb_id.get_drb_id()));
 
   // TX metrics
   auto& tx_output = output.get<mset_drb_tx_container>();
-  tx_output.write<metric_tx_num_sdus>(drb.tx.num_sdus);
-  tx_output.write<metric_tx_num_sdu_bytes>(drb.tx.num_sdu_bytes);
-  tx_output.write<metric_tx_num_dropped_sdus>(drb.tx.num_dropped_sdus);
-  tx_output.write<metric_tx_num_discarded_sdus>(drb.tx.num_discarded_sdus);
-  tx_output.write<metric_tx_num_discard_failures>(drb.tx.num_discarded_sdus);
+  tx_output.write<metric_tx_num_sdus>(drb.tx.tx_high.num_sdus);
+  tx_output.write<metric_tx_num_sdu_bytes>(drb.tx.tx_high.num_sdu_bytes);
+  tx_output.write<metric_tx_num_dropped_sdus>(drb.tx.tx_high.num_dropped_sdus);
+  tx_output.write<metric_tx_num_discarded_sdus>(drb.tx.tx_high.num_discarded_sdus);
+  tx_output.write<metric_tx_num_discard_failures>(drb.tx.tx_high.num_discarded_sdus);
 
   // RX metrics
   auto& rx_output = output.get<mset_drb_rx_container>();