sec: fix empty padding

robertfalkenberg · robertfalkenberg · commit 4bfd12b130d6 · 2024-07-15T06:04:11.000+02:00
diff --git a/tests/unittests/security/ciphering_engine_test.cpp b/tests/unittests/security/ciphering_engine_test.cpp
@@ -96,8 +96,10 @@ bool trim_tail_to_bitlength(byte_buffer_view buf, uint32_t bitlength)
     return false;
   }
   uint32_t padding = bitlength % 8;
-  uint8_t  mask    = 0xff << (8 - padding);
-  buf[buf.length() - 1] &= mask;
+  if (padding > 0) {
+    uint8_t mask = 0xff << (8 - padding);
+    buf[buf.length() - 1] &= mask;
+  }
   return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,10 @@ bool trim_tail_to_bitlength(byte_buffer_view buf, uint32_t bitlength)`
`96`	`96`	`return false;`
`97`	`97`	`}`
`98`	`98`	`uint32_t padding = bitlength % 8;`
`99`		`- uint8_t mask = 0xff << (8 - padding);`
`100`		`- buf[buf.length() - 1] &= mask;`
	`99`	`+ if (padding > 0) {`
	`100`	`+ uint8_t mask = 0xff << (8 - padding);`
	`101`	`+ buf[buf.length() - 1] &= mask;`
	`102`	`+ }`
`101`	`103`	`return true;`
`102`	`104`	`}`
`103`	`105`