Skip to content

Commit 5990f1b

Browse files
FabianEckermanncodebot
authored andcommitted
cu_cp,f1ap: make ue context modification procedure timeout configurable
1 parent a1ae70a commit 5990f1b

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

lib/f1ap/cu_cp/f1ap_cu_impl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ f1ap_cu_impl::handle_ue_context_modification_request(const f1ap_ue_context_modif
123123
});
124124
}
125125

126-
return launch_async<ue_context_modification_procedure>(request, ue_ctxt_list[request.ue_index], tx_pdu_notifier);
126+
return launch_async<ue_context_modification_procedure>(cfg, request, ue_ctxt_list[request.ue_index], tx_pdu_notifier);
127127
}
128128

129129
bool f1ap_cu_impl::handle_ue_id_update(ue_index_t ue_index, ue_index_t old_ue_index)

lib/f1ap/cu_cp/procedures/ue_context_modification_procedure.cpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ using namespace srsran;
1818
using namespace srsran::srs_cu_cp;
1919
using namespace asn1::f1ap;
2020

21-
constexpr std::chrono::milliseconds bearer_context_mod_response_timeout{1000};
22-
2321
/// \brief Convert the UE Context Modification Request from common type to ASN.1.
2422
/// \param[out] asn1_request The ASN.1 struct to store the result.
2523
/// \param[in] request The common type UE Context Modification Request.
@@ -39,10 +37,15 @@ static void fill_f1ap_ue_context_modification_response(f1ap_ue_context_modificat
3937
const asn1::f1ap::ue_context_mod_fail_s& asn1_fail);
4038

4139
ue_context_modification_procedure::ue_context_modification_procedure(
40+
const f1ap_configuration& f1ap_cfg_,
4241
const f1ap_ue_context_modification_request& request_,
4342
f1ap_ue_context& ue_ctxt_,
4443
f1ap_message_notifier& f1ap_notif_) :
45-
request(request_), ue_ctxt(ue_ctxt_), f1ap_notifier(f1ap_notif_), logger(srslog::fetch_basic_logger("CU-CP-F1"))
44+
f1ap_cfg(f1ap_cfg_),
45+
request(request_),
46+
ue_ctxt(ue_ctxt_),
47+
f1ap_notifier(f1ap_notif_),
48+
logger(srslog::fetch_basic_logger("CU-CP-F1"))
4649
{
4750
}
4851

@@ -53,7 +56,7 @@ void ue_context_modification_procedure::operator()(coro_context<async_task<f1ap_
5356
logger.debug("{}: Procedure started...", f1ap_ue_log_prefix{ue_ctxt.ue_ids, name()});
5457

5558
// Subscribe to respective publisher to receive UE CONTEXT MODIFICATION RESPONSE/FAILURE message.
56-
transaction_sink.subscribe_to(ue_ctxt.ev_mng.context_modification_outcome, bearer_context_mod_response_timeout);
59+
transaction_sink.subscribe_to(ue_ctxt.ev_mng.context_modification_outcome, f1ap_cfg.proc_timeout);
5760

5861
// Send command to DU.
5962
send_ue_context_modification_request();

lib/f1ap/cu_cp/procedures/ue_context_modification_procedure.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ namespace srs_cu_cp {
2424
class ue_context_modification_procedure
2525
{
2626
public:
27-
ue_context_modification_procedure(const f1ap_ue_context_modification_request& request_,
27+
ue_context_modification_procedure(const f1ap_configuration& f1ap_cfg_,
28+
const f1ap_ue_context_modification_request& request_,
2829
f1ap_ue_context& ue_ctxt_,
2930
f1ap_message_notifier& f1ap_notif_);
3031

@@ -39,6 +40,7 @@ class ue_context_modification_procedure
3940
/// Creates procedure result to send back to procedure caller.
4041
f1ap_ue_context_modification_response create_ue_context_modification_result();
4142

43+
const f1ap_configuration& f1ap_cfg;
4244
const f1ap_ue_context_modification_request request;
4345
f1ap_ue_context& ue_ctxt;
4446
f1ap_message_notifier& f1ap_notifier;

0 commit comments

Comments
 (0)