Skip to content

Commit 5efe741

Browse files
FabianEckermannasaezper
authored andcommitted
du: Small log fixes
1 parent defc575 commit 5efe741

File tree

2 files changed

+9
-12
lines changed

2 files changed

+9
-12
lines changed

lib/du_manager/procedures/ue_configuration_procedure.cpp

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ void ue_configuration_procedure::update_ue_context()
114114
// Note: This DRB pointer will remain valid and accessible from other layers until we update the latter.
115115
for (const drb_id_t& drb_to_rem : request.drbs_to_rem) {
116116
if (ue->bearers.drbs().count(drb_to_rem) == 0) {
117-
proc_logger.log_proc_warning("Failed to release DRB-Id={}. Cause: DRB does not exist", drb_to_rem);
117+
proc_logger.log_proc_warning("Failed to release {}. Cause: DRB does not exist", drb_to_rem);
118118
continue;
119119
}
120120
srsran_assert(std::any_of(prev_cell_group.rlc_bearers.begin(),
@@ -128,13 +128,11 @@ void ue_configuration_procedure::update_ue_context()
128128
// > Create DU UE DRB objects.
129129
for (const f1ap_drb_to_setup& drbtoadd : request.drbs_to_setup) {
130130
if (drbtoadd.uluptnl_info_list.empty()) {
131-
proc_logger.log_proc_warning("Failed to create DRB-Id={}. Cause: No UL UP TNL Info List provided.",
132-
drbtoadd.drb_id);
131+
proc_logger.log_proc_warning("Failed to create {}. Cause: No UL UP TNL Info List provided.", drbtoadd.drb_id);
133132
continue;
134133
}
135134
if (ue->bearers.drbs().count(drbtoadd.drb_id) > 0) {
136-
proc_logger.log_proc_warning("Failed to modify DRB-Id={}. Cause: DRB modifications not supported.",
137-
drbtoadd.drb_id);
135+
proc_logger.log_proc_warning("Failed to modify {}. Cause: DRB modifications not supported.", drbtoadd.drb_id);
138136
continue;
139137
}
140138

@@ -146,7 +144,7 @@ void ue_configuration_procedure::update_ue_context()
146144

147145
// Find the F1-U configuration for this DRB.
148146
auto f1u_cfg_it = du_params.ran.qos.find(drbtoadd.five_qi);
149-
srsran_assert(f1u_cfg_it != du_params.ran.qos.end(), "Undefined F1-U bearer config for 5QI={}", drbtoadd.five_qi);
147+
srsran_assert(f1u_cfg_it != du_params.ran.qos.end(), "Undefined F1-U bearer config for {}", drbtoadd.five_qi);
150148

151149
// Create DU DRB instance.
152150
std::unique_ptr<du_ue_drb> drb = create_drb(ue->ue_index,
@@ -161,8 +159,7 @@ void ue_configuration_procedure::update_ue_context()
161159
du_params,
162160
ue->get_rlc_rlf_notifier());
163161
if (drb == nullptr) {
164-
proc_logger.log_proc_warning("Failed to create DRB-Id={}. Cause: Failed to allocate DU UE resources.",
165-
drbtoadd.drb_id);
162+
proc_logger.log_proc_warning("Failed to create {}. Cause: Failed to allocate DU UE resources.", drbtoadd.drb_id);
166163
continue;
167164
}
168165
ue->bearers.add_drb(std::move(drb));

lib/du_manager/ran_resource_management/du_ran_resource_manager_impl.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,27 +153,27 @@ du_ran_resource_manager_impl::update_context(du_ue_index_t
153153
if (std::any_of(ue_mcg.rlc_bearers.begin(), ue_mcg.rlc_bearers.end(), [&drb](const auto& item) {
154154
return *drb.lcid == item.lcid;
155155
})) {
156-
logger.warning("Failed to allocate DRB-Id={}. Cause: Specified lcid={} already exists", drb.drb_id, lcid);
156+
logger.warning("Failed to allocate {}. Cause: Specified lcid={} already exists", drb.drb_id, lcid);
157157
resp.failed_drbs.push_back(drb.drb_id);
158158
continue;
159159
}
160160
} else {
161161
// >> Allocate LCID if not specified by F1AP.
162162
lcid = find_empty_lcid(ue_mcg.rlc_bearers);
163163
if (lcid > LCID_MAX_DRB) {
164-
logger.warning("Failed to allocate DRB-Id={}. Cause: No available LCIDs", drb.drb_id);
164+
logger.warning("Failed to allocate {}. Cause: No available LCIDs", drb.drb_id);
165165
resp.failed_drbs.push_back(drb.drb_id);
166166
continue;
167167
}
168168
}
169169

170170
// >> Get RLC config from 5QI
171171
if (qos_config.find(drb.five_qi) == qos_config.end()) {
172-
logger.warning("Failed to allocate DRB-Id={}. Cause: No 5QI={} configured", drb.drb_id, drb.five_qi);
172+
logger.warning("Failed to allocate {}. Cause: No {} configured", drb.drb_id, drb.five_qi);
173173
resp.failed_drbs.push_back(drb.drb_id);
174174
continue;
175175
}
176-
logger.debug("Getting RLC and MAC config for DRB-Id={} from 5QI={}", drb.drb_id, drb.five_qi);
176+
logger.debug("Getting RLC and MAC config for {} from {}", drb.drb_id, drb.five_qi);
177177
const du_qos_config& qos = qos_config.at(drb.five_qi);
178178

179179
ue_mcg.rlc_bearers.emplace_back();

0 commit comments

Comments
 (0)