sched: improve comments of slice scheduler

Author: frankist

lib/scheduler/slicing/slice_scheduler.cpp

@@ -27,7 +27,7 @@ slice_scheduler::slice_scheduler(const cell_configuration& cell_cfg_) :
   slices.back().inst.policy =
       create_scheduler_strategy(scheduler_strategy_params{"time_rr", &logger}, cell_cfg.expert_cfg.ue);
   ++id_count;
-  // Configured RRM policy members
+  // Configured RRM policy members.
   for (const slice_rrm_policy_config& rrm : cell_cfg.rrm_policy_members) {
     slices.emplace_back(id_count, cell_cfg, rrm);
     slices.back().inst.policy =
@@ -87,7 +87,7 @@ void slice_scheduler::rem_ue(du_ue_index_t ue_idx)
 
 ran_slice_instance& slice_scheduler::get_slice(const rrm_policy_member& rrm)
 {
-  auto it = std::find_if(slices.begin() + 1, slices.end(), [&rrm](const ran_slice_sched_context& slice) {
+  auto it = std::find_if(slices.begin(), slices.end(), [&rrm](const ran_slice_sched_context& slice) {
     return slice.inst.cfg.rrc_member == rrm;
   });
   if (it == slices.end()) {
@@ -151,11 +151,11 @@ slice_scheduler::priority_type slice_scheduler::ran_slice_sched_context::get_pri
 {
   // Note: The positive integer representing the priority of a slice consists of a concatenation of three priority
   // values:
-  // 1. slice traffic priority (16 bits). Differentiation of slices based on whether they have minimum required
-  // traffic agreements (e.g. minRB ratio).
+  // 1. slice traffic priority (16 most significant bits). It differentiates slices based on whether they have
+  // minimum required traffic agreements (e.g. minRB ratio).
   // 2. delay priority (8 bits), which attributes the highest priority to slices that have not been scheduled for a
-  // long time
-  // 3. round-robin based on slot indication count (8 bits).
+  // long time.
+  // 3. round-robin based on slot indication count (8 least significant bits).
 
   // Priority when slice has already reached its minimum RB ratio agreement.
   constexpr static priority_type default_prio = 0x1U;

lib/scheduler/slicing/slice_scheduler.h

@@ -57,7 +57,7 @@ class slice_scheduler
     {
     }
 
-    /// Get the slice priority as a candidate, considering also past decisions by the slice scheduler for this slot.
+    /// Determines the slice candidate priority.
     priority_type get_prio(bool is_dl, slot_count_type current_slot_count, bool slice_resched) const;
   };
 

tests/unittests/scheduler/slicing/slice_scheduler_test.cpp

@@ -157,12 +157,13 @@ class rb_ratio_slice_scheduler_test : public slice_scheduler_test, public ::test
 
   const ue_configuration* add_ue(du_ue_index_t ue_idx)
   {
-    auto req                                        = test_cfg.get_default_ue_config_request();
-    req.ue_index                                    = ue_idx;
-    req.crnti                                       = to_rnti(0x4601 + ue_idx);
-    req.starts_in_fallback                          = false;
-    (*req.cfg.lc_config_list)[2].rrm_policy.plmn_id = "00101";
-    (*req.cfg.lc_config_list)[2].rrm_policy.s_nssai = s_nssai_t{1};
+    const unsigned drb1_idx                                = 2;
+    auto           req                                     = test_cfg.get_default_ue_config_request();
+    req.ue_index                                           = ue_idx;
+    req.crnti                                              = to_rnti(0x4601 + ue_idx);
+    req.starts_in_fallback                                 = false;
+    (*req.cfg.lc_config_list)[drb1_idx].rrm_policy.plmn_id = "00101";
+    (*req.cfg.lc_config_list)[drb1_idx].rrm_policy.s_nssai = s_nssai_t{1};
     return slice_scheduler_test::add_ue(req);
   }
 };