Skip to content

Commit 663855f

Browse files
carlo-galcodebot
authored andcommitted
gnb: add PUCCH configuration for max 512 ues
Signed-off-by: Carlo Galiotto <[email protected]>
1 parent a28a6fb commit 663855f

File tree

4 files changed

+34
-5
lines changed

4 files changed

+34
-5
lines changed

apps/units/flexible_du/du_high/du_high_config_cli11_schema.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ static void configure_cli11_pucch_args(CLI::App& app, du_high_unit_pucch_config&
820820
pucch_params.nof_cell_sr_resources,
821821
"Number of PUCCH F1 resources available per cell for SR")
822822
->capture_default_str()
823-
->check(CLI::Range(1, 50));
823+
->check(CLI::Range(1, 100));
824824
add_option(app,
825825
"--f0_intraslot_freq_hop",
826826
pucch_params.f0_intraslot_freq_hopping,
@@ -850,7 +850,7 @@ static void configure_cli11_pucch_args(CLI::App& app, du_high_unit_pucch_config&
850850
pucch_params.nof_cell_csi_resources,
851851
"Number of PUCCH F2 resources available per cell for CSI")
852852
->capture_default_str()
853-
->check(CLI::Range(0, 50));
853+
->check(CLI::Range(0, 100));
854854
add_option(app, "--f2_max_nof_rbs", pucch_params.f2_max_nof_rbs, "Max number of RBs for PUCCH F2 resources")
855855
->capture_default_str()
856856
->check(CLI::Range(1, 16));

configs/cell_cfg_max_256_ues.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# This file contains the PUCCH configuration for the gNB to support:
22
# - SR period 20ms or 40ms.
33
# - CSI period 20ms or 40ms.
4-
# - Max 128 UEs.
4+
# - Max 256 UEs.
55

66
# NOTEs:
77
# - This configuration is optimized for TDD 7D-2U configuration, but it still works for TDD configurations
88
# with more than 2 UL slots.
9-
# - This configuration might work for more than 128 UEs, although it hasn't been tested for those scenarios.
9+
# - This configuration might work for more than 256 UEs, although it hasn't been tested for those scenarios.
1010

1111
cell_cfg:
1212
pucch:

configs/cell_cfg_max_512_ues.yml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
# This file contains the PUCCH configuration for the gNB to support:
2+
# - SR period 20ms or 40ms.
3+
# - CSI period 20ms (only with TDD 6D-3U configuration), 40ms (with both TDD 6D-3U and 7D-2U configurations).
4+
# - SR period <= CSI period.
5+
# - Max 512 UEs.
6+
7+
# NOTEs:
8+
# - This configuration is optimized for TDD 7D-2U configuration, but it still works for TDD configurations
9+
# with more than 2 UL slots.
10+
# - This configuration might work for more than 512 UEs, although it hasn't been tested for those scenarios.
11+
12+
cell_cfg:
13+
pucch:
14+
sr_period_ms: 20 # This can be set either 20 or 40 ms.
15+
nof_ue_res_harq_per_set: 8
16+
nof_cell_harq_pucch_sets: 2 # Increase this if UEs are not scheduled PDSCH due to PUCCH resources starvation.
17+
f0_or_f1_nof_cell_res_sr: 80
18+
f2_nof_cell_res_csi: 80
19+
csi:
20+
csi_rs_period: 40 # This can be set to 20 only with TDD 6D-3U.
21+
ul_common:
22+
max_ul_grants_per_slot: 128
23+
max_pucchs_per_slot: 120
24+
pusch:
25+
max_puschs_per_slot: 8
26+
tdd_ul_dl_cfg:
27+
nof_dl_symbols: 7
28+
nof_dl_slots: 7
29+
nof_ul_slots: 2

lib/scheduler/pucch_scheduling/pucch_allocator_impl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1188,7 +1188,7 @@ void pucch_allocator_impl::allocate_csi_grant(cell_slot_resource_allocator& pucc
11881188
}
11891189

11901190
if (pucch_grants_alloc_grid[sl_tx.to_uint()].full()) {
1191-
logger.info("rnti={}: PUCCH HARQ-ACK allocation for slot={} skipped. Cause: PUCCH allocator grant list is full",
1191+
logger.info("rnti={}: PUCCH CSI allocation for slot={} skipped. Cause: PUCCH allocator grant list is full",
11921192
crnti,
11931193
pucch_slot_alloc.slot);
11941194
return;

0 commit comments

Comments
 (0)