ci: rf pass if warnings in the log

Author: asaezper

.gitlab/ci/e2e.yml

@@ -26,8 +26,9 @@
     LOG_LEVEL: "info"
     MARKERS: ""
     ARGS: ""
-    FORCE_DOWNLOAD: "false"
+    FORCE_DOWNLOAD: "false"  # Download only failed tests by default
     PCAP: "" # Disabled by default
+    FAIL_IF_INTERNAL_ERRORS: "true" # Enabled by default
   tags:
     - on-prem-amd64
   extends:
@@ -48,6 +49,7 @@
       export RETINA_LOGLEVEL="$LOG_LEVEL"
       export RETINA_FORCE_DOWNLOAD_REPORT="$FORCE_DOWNLOAD"
       export RETINA_PCAP_ENABLE="$PCAP"
+      export RETINA_FAIL_IF_INTERNAL_ERRORS="$FAIL_IF_INTERNAL_ERRORS"
     - retina-launcher --retina-request ${REQUEST} --self-contained-html --html=./log/report.html --junitxml=out.xml "${ARGS}" -m "${MARKERS}" .
   after_script:
     - |
@@ -125,6 +127,7 @@ rf:
     REQUEST: "${CI_PROJECT_DIR}/.gitlab/ci/retina_request_rf.yml"
     MARKERS: "rf and not tcp and not multiue"
     LOG_LEVEL: "warning"
+    FAIL_IF_INTERNAL_ERRORS: ""
   needs:
     - job: "avx2 [basic]"
       artifacts: true

tests/e2e/tests/utils.py

@@ -50,7 +50,7 @@ def get_ue_gnb_epc(self, extra, band, common_scs, bandwidth, mcs, ue_count):
                     "bandwidth": bandwidth,
                     "mcs": mcs,
                     "log_level": get_loglevel(),
-                    "pcap": bool(os.environ["RETINA_PCAP_ENABLE"])
+                    "pcap": get_pcap(),
                 }
             },
         }
@@ -74,19 +74,24 @@ def get_ue_gnb_epc(self, extra, band, common_scs, bandwidth, mcs, ue_count):
 
         with suppress(NameError, grpc._channel._InactiveRpcError):
             return_code = gnb.Stop(Empty()).value
-            teardown_ok &= return_code == 0
             if return_code < 0:
+                teardown_ok = False
                 logging.error("GNB crashed with exit code %s", return_code)
             elif return_code > 0:
+                if get_fail_if_internal_errors():
+                    teardown_ok = False
                 logging.error("GNB has %d errors or warnings", return_code)
         with suppress(NameError, grpc._channel._InactiveRpcError):
             epc.Stop(Empty()).value
         with suppress(NameError, grpc._channel._InactiveRpcError):
             return_code = ue.Stop(Empty()).value
             teardown_ok &= return_code == 0
             if return_code < 0:
+                teardown_ok = False
                 logging.error("UE crashed with exit code %s", return_code)
             elif return_code > 0:
+                if get_fail_if_internal_errors():
+                    teardown_ok = False
                 logging.error("UE has %d errors or warnings", return_code)
         if teardown_ok is False:
             test_successful = False
@@ -147,3 +152,23 @@ def get_loglevel():
         return os.environ["RETINA_LOGLEVEL"]
     except KeyError:
         return "info"
+
+
+def get_pcap():
+    """
+    Return True / False
+    """
+    try:
+        return bool(os.environ["RETINA_PCAP_ENABLE"])
+    except KeyError:
+        return False
+
+
+def get_fail_if_internal_errors():
+    """
+    Return True / False
+    """
+    try:
+        return bool(os.environ["RETINA_FAIL_IF_INTERNAL_ERRORS"])
+    except KeyError:
+        return True