cu_cp: improve cell (de-)activation

Author: FabianEckermann

lib/cu_cp/routines/cell_activation_routine.cpp

@@ -45,17 +45,22 @@ void cell_activation_routine::operator()(coro_context<async_task<void>>& ctx)
     }
 
     if (!generate_gnb_cu_configuration_update()) {
-      logger.warning("Failed to generate gNB-CU configuration update for DU {}", *du_idx_it);
+      logger.warning("Failed to generate gNB-CU configuration update for du={}", *du_idx_it);
       continue;
     }
 
     CORO_AWAIT_VALUE(f1ap_cu_cfg_update_response, du_proc->handle_configuration_update(f1ap_cu_cfg_update));
+    if (!f1ap_cu_cfg_update_response.success) {
+      logger.info(
+          "Configuration update for du={} failed. Cause: {}", *du_idx_it, f1ap_cu_cfg_update_response.cause.value());
+      routine_success = false;
+    }
   }
 
-  if (f1ap_cu_cfg_update_response.success) {
+  if (routine_success) {
     logger.info("\"{}\" finished successfully", name());
   } else {
-    logger.info("\"{}\" failed. Cause: {}", name(), f1ap_cu_cfg_update_response.cause.value());
+    logger.info("\"{}\" failed", name());
   }
 
   CORO_RETURN();

lib/cu_cp/routines/cell_activation_routine.h

@@ -46,6 +46,7 @@ class cell_activation_routine
 
   // (Sub-)Routine results.
   f1ap_gnb_cu_configuration_update_response f1ap_cu_cfg_update_response;
+  bool                                      routine_success = true;
 
   std::unordered_set<plmn_identity> plmns_to_activate;
   std::vector<du_index_t>           du_indexes;

lib/cu_cp/routines/cell_deactivation_routine.cpp

@@ -71,17 +71,22 @@ void cell_deactivation_routine::operator()(coro_context<async_task<void>>& ctx)
     }
 
     if (!generate_gnb_cu_configuration_update()) {
-      logger.warning("Failed to generate gNB-CU configuration update for DU {}", *du_idx_it);
+      logger.warning("Failed to generate gNB-CU configuration update for du={}", *du_idx_it);
       continue;
     }
 
     CORO_AWAIT_VALUE(f1ap_cu_cfg_update_response, du_proc->handle_configuration_update(f1ap_cu_cfg_update));
+    if (!f1ap_cu_cfg_update_response.success) {
+      logger.info(
+          "Configuration update for du={} failed. Cause: {}", *du_idx_it, f1ap_cu_cfg_update_response.cause.value());
+      routine_success = false;
+    }
   }
 
-  if (f1ap_cu_cfg_update_response.success) {
+  if (routine_success) {
     logger.info("\"{}\" finished successfully", name());
   } else {
-    logger.info("\"{}\" failed. Cause: {}", name(), f1ap_cu_cfg_update_response.cause.value());
+    logger.info("\"{}\" failed", name());
   }
 
   CORO_RETURN();

lib/cu_cp/routines/cell_deactivation_routine.h

@@ -54,6 +54,7 @@ class cell_deactivation_routine
 
   // (Sub-)Routine results.
   f1ap_gnb_cu_configuration_update_response f1ap_cu_cfg_update_response;
+  bool                                      routine_success = true;
 
   std::unordered_map<ue_index_t, bool>           ue_release_status;
   std::unordered_map<ue_index_t, bool>::iterator ue_release_status_it;