pdcp: add log spy to RX test and check warnings and errors

Author: robertfalkenberg

tests/unittests/pdcp/pdcp_rx_test.cpp

@@ -25,6 +25,10 @@ TEST_P(pdcp_rx_test, create_new_entity)
 
   ASSERT_NE(pdcp_rx, nullptr);
   ASSERT_NE(test_frame, nullptr);
+
+  // No warnings or errors during construction
+  EXPECT_EQ(test_spy.get_warning_counter(), 0);
+  EXPECT_EQ(test_spy.get_error_counter(), 0);
 }
 
 /// Test extraction of PDCP sequence numbers
@@ -54,6 +58,10 @@ TEST_P(pdcp_rx_test, sn_unpack)
   } else {
     FAIL();
   }
+
+  // No warnings or errors
+  EXPECT_EQ(test_spy.get_warning_counter(), 0);
+  EXPECT_EQ(test_spy.get_error_counter(), 0);
 }
 
 /// Test in-order reception of PDCP PDUs
@@ -95,6 +103,10 @@ TEST_P(pdcp_rx_test, rx_in_order)
   } else {
     FAIL();
   }
+
+  // No warnings or errors
+  EXPECT_EQ(test_spy.get_warning_counter(), 0);
+  EXPECT_EQ(test_spy.get_error_counter(), 0);
 }
 
 /// Test out of order reception of PDUs.
@@ -160,6 +172,10 @@ TEST_P(pdcp_rx_test, rx_out_of_order)
   } else {
     FAIL();
   }
+
+  // No warnings or errors
+  EXPECT_EQ(test_spy.get_warning_counter(), 0);
+  EXPECT_EQ(test_spy.get_error_counter(), 0);
 }
 
 /// Test out of order reception of PDUs.
@@ -209,6 +225,10 @@ TEST_P(pdcp_rx_test, rx_reordering_timer)
   } else {
     FAIL();
   }
+
+  // No warnings or errors
+  EXPECT_EQ(test_spy.get_warning_counter(), 0);
+  EXPECT_EQ(test_spy.get_error_counter(), 0);
 }
 
 /// Test out of order reception of PDUs.
@@ -256,6 +276,10 @@ TEST_P(pdcp_rx_test, rx_reordering_timer_0ms)
   } else {
     FAIL();
   }
+
+  // No warnings or errors
+  EXPECT_EQ(test_spy.get_warning_counter(), 0);
+  EXPECT_EQ(test_spy.get_error_counter(), 0);
 }
 
 /// Test out of order reception of PDUs.
@@ -306,6 +330,10 @@ TEST_P(pdcp_rx_test, rx_reordering_timer_infinite)
   } else {
     FAIL();
   }
+
+  // One warning but no errors
+  EXPECT_EQ(test_spy.get_warning_counter(), 1);
+  EXPECT_EQ(test_spy.get_error_counter(), 0);
 }
 
 /// Test reception of PDUs with bad integrity checks.
@@ -344,6 +372,10 @@ TEST_P(pdcp_rx_test, rx_integrity_fail)
   } else {
     FAIL();
   }
+
+  // Three warnings but no errors
+  EXPECT_EQ(test_spy.get_warning_counter(), 3);
+  EXPECT_EQ(test_spy.get_error_counter(), 0);
 }
 
 /// Test count wrap-around protection for PDCP RX
@@ -383,6 +415,10 @@ TEST_P(pdcp_rx_test, count_wraparound)
   };
 
   test_max_count(rx_next_start);
+
+  // One warning and one error
+  EXPECT_EQ(test_spy.get_warning_counter(), 1);
+  EXPECT_EQ(test_spy.get_error_counter(), 1);
 }
 
 /// Test TX SDU buffering.
@@ -420,6 +456,10 @@ TEST_P(pdcp_rx_test, rx_buffer)
   wait_pending_crypto();
   worker.run_pending_tasks();
   FLUSH_AND_ASSERT_EQ(2, test_frame->sdu_queue.size());
+
+  // No warnings or errors
+  EXPECT_EQ(test_spy.get_warning_counter(), 0);
+  EXPECT_EQ(test_spy.get_error_counter(), 0);
 }
 
 ///////////////////////////////////////////////////////////////////

tests/unittests/pdcp/pdcp_rx_test.h

@@ -11,10 +11,26 @@
 #pragma once
 
 #include "pdcp_rx_test_helpers.h"
+#include "srsran/support/test_utils.h"
 #include <gtest/gtest.h>
 
 namespace srsran {
 
+srsran::log_sink_spy& test_spy = []() -> srsran::log_sink_spy& {
+  if (!srslog::install_custom_sink(
+          srsran::log_sink_spy::name(),
+          std::unique_ptr<srsran::log_sink_spy>(new srsran::log_sink_spy(srslog::get_default_log_formatter())))) {
+    report_fatal_error("Unable to create logger spy");
+  }
+  auto* spy = static_cast<srsran::log_sink_spy*>(srslog::find_sink(srsran::log_sink_spy::name()));
+  if (spy == nullptr) {
+    report_fatal_error("Unable to create logger spy");
+  }
+
+  srslog::fetch_basic_logger("PDCP", *spy, true);
+  return *spy;
+}();
+
 /// Fixture class for PDCP tests
 /// It requires TEST_P() and INSTANTIATE_TEST_SUITE_P() to create/spawn tests for each supported SN size
 class pdcp_rx_test : public pdcp_rx_test_helper_default_crypto,
@@ -28,6 +44,9 @@ class pdcp_rx_test : public pdcp_rx_test_helper_default_crypto,
     srslog::init();
     logger.set_level(srslog::basic_levels::debug);
 
+    // reset log spy
+    test_spy.reset_counters();
+
     // init RLC logger
     srslog::fetch_basic_logger("PDCP", false).set_level(srslog::basic_levels::debug);
     srslog::fetch_basic_logger("PDCP", false).set_hex_dump_max_size(100);