cu_cp,rrc: improve function name

Author: FabianEckermann

include/srsran/rrc/rrc_ue.h

@@ -198,10 +198,10 @@ class rrc_ue_control_message_handler
   /// \returns The Security Mode Command context.
   virtual rrc_ue_security_mode_command_context get_security_mode_command_context() = 0;
 
-  /// \brief Await a RRC Security Mode Command Complete for a handover.
-  /// \param[in] transaction_id The transaction ID of the RRC Security Mode Command Complete.
-  /// \returns True if the RRC Security Mode Command Complete was received, false otherwise.
-  virtual async_task<bool> handle_security_mode_command_complete_expected(uint8_t transaction_id) = 0;
+  /// \brief Await a RRC Security Mode Complete.
+  /// \param[in] transaction_id The transaction ID of the RRC Security Mode Complete.
+  /// \returns True if the RRC Security Mode Complete was received, false otherwise.
+  virtual async_task<bool> handle_security_mode_complete_expected(uint8_t transaction_id) = 0;
 
   /// \brief Get the packed UE Capability RAT Container List.
   /// \returns The packed UE Capability RAT Container List.

lib/cu_cp/routines/initial_context_setup_routine.cpp

@@ -79,10 +79,10 @@ void initial_context_setup_routine::operator()(
     }
   }
 
-  // Await Security Mode Command Complete from RRC UE
+  // Await Security Mode Complete from RRC UE
   {
     CORO_AWAIT_VALUE(security_mode_command_result,
-                     rrc_ue.handle_security_mode_command_complete_expected(rrc_smc_ctxt.transaction_id));
+                     rrc_ue.handle_security_mode_complete_expected(rrc_smc_ctxt.transaction_id));
     if (!security_mode_command_result) {
       handle_failure();
       CORO_EARLY_RETURN(make_unexpected(fail_msg));

lib/rrc/ue/rrc_ue_impl.h

@@ -63,7 +63,7 @@ class rrc_ue_impl final : public rrc_ue_interface, public rrc_ue_controller
 
   // rrc_ue_control_message_handler
   rrc_ue_security_mode_command_context get_security_mode_command_context() override;
-  async_task<bool>                     handle_security_mode_command_complete_expected(uint8_t transaction_id) override;
+  async_task<bool>                     handle_security_mode_complete_expected(uint8_t transaction_id) override;
   byte_buffer                          get_packed_ue_capability_rat_container_list() const override;
   byte_buffer                          get_packed_ue_radio_access_cap_info() const override;
   async_task<bool> handle_rrc_reconfiguration_request(const rrc_reconfiguration_procedure_request& msg) override;

lib/rrc/ue/rrc_ue_message_handlers.cpp

@@ -312,7 +312,7 @@ rrc_ue_security_mode_command_context rrc_ue_impl::get_security_mode_command_cont
   return smc_ctxt;
 }
 
-async_task<bool> rrc_ue_impl::handle_security_mode_command_complete_expected(uint8_t transaction_id)
+async_task<bool> rrc_ue_impl::handle_security_mode_complete_expected(uint8_t transaction_id)
 {
   // arbitrary timeout for RRC Reconfig procedure, UE will be removed if timer fires
   const std::chrono::milliseconds timeout_ms{1000};
@@ -321,7 +321,7 @@ async_task<bool> rrc_ue_impl::handle_security_mode_command_complete_expected(uin
       [this, timeout_ms, transaction_id, transaction = rrc_transaction{}](coro_context<async_task<bool>>& ctx) mutable {
         CORO_BEGIN(ctx);
 
-        logger.log_debug("Awaiting RRC Security Mode Command Complete (timeout={}ms)", timeout_ms.count());
+        logger.log_debug("Awaiting RRC Security Mode Complete (timeout={}ms)", timeout_ms.count());
         // create new transaction for RRC Security Mode Command procedure
         transaction = event_mng->transactions.create_transaction(transaction_id, timeout_ms);