sec: fix ambiguous bitmask in s3g

robertfalkenberg · robertfalkenberg · commit 92ee1e81f083 · 2025-09-08T11:18:39.000+02:00
diff --git a/lib/security/s3g.cpp b/lib/security/s3g.cpp
@@ -413,7 +413,7 @@ static void s3g_PRE_MUL_P(std::array<std::array<uint64_t, 256>, 8>& PM, uint64_t
     uint64_t a                 = PM[(i - 1) >> 3][1 << ((i - 1) & 0x7)];
     PM[i >> 3][1 << (i & 0x7)] = a << 1;
     // If the leftmost bit...
-    static constexpr uint64_t leftmost_bit_mask = 1L << 63;
+    static constexpr uint64_t leftmost_bit_mask = 1UL << 63UL;
     if (a & leftmost_bit_mask) {
       PM[i >> 3][1 << (i & 0x7)] ^= c;
     }

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,7 @@ static void s3g_PRE_MUL_P(std::array<std::array<uint64_t, 256>, 8>& PM, uint64_t`
`413`	`413`	`uint64_t a = PM[(i - 1) >> 3][1 << ((i - 1) & 0x7)];`
`414`	`414`	`PM[i >> 3][1 << (i & 0x7)] = a << 1;`
`415`	`415`	`// If the leftmost bit...`
`416`		`- static constexpr uint64_t leftmost_bit_mask = 1L << 63;`
	`416`	`+ static constexpr uint64_t leftmost_bit_mask = 1UL << 63UL;`
`417`	`417`	`if (a & leftmost_bit_mask) {`
`418`	`418`	`PM[i >> 3][1 << (i & 0x7)] ^= c;`
`419`	`419`	`}`