phy: review memory related

phy: fix compilation

Author: xavierarteaga

lib/phy/upper/channel_modulation/evm_calculator_generic_impl.cpp

@@ -34,8 +34,9 @@ float evm_calculator_generic_impl::calculate(span<const log_likelihood_ratio> so
   float    avg_power   = 0.0;
 
   while (!soft_bits.empty()) {
-    unsigned block_nof_symbols = std::min(static_cast<unsigned>(symbols.size()), MAX_NOF_SYMBOLS);
-    unsigned block_nof_bits    = block_nof_symbols * bits_per_symbol;
+    unsigned block_nof_symbols =
+        std::min(static_cast<unsigned>(symbols.size()), static_cast<unsigned>(MAX_NOF_SYMBOLS));
+    unsigned block_nof_bits = block_nof_symbols * bits_per_symbol;
 
     // Perform hard-decision.
     bit_buffer hard_bits = temp_hard_bits.first(block_nof_bits);

lib/phy/upper/channel_modulation/evm_calculator_generic_impl.h

@@ -33,9 +33,9 @@ class evm_calculator_generic_impl : public evm_calculator
                   modulation_scheme                modulation) override;
 
 private:
-  /// Maximum number of symbols assuming 156 RE/RB, 275 RB and 4 layers.
+  /// Maximum processing block size in number of symbols.
   static constexpr unsigned MAX_NOF_SYMBOLS = 4096;
-  /// Maximum number of bits.
+  /// Maximum processing block size in number of bits.
   static constexpr unsigned MAX_NOF_BITS = MAX_NOF_SYMBOLS * 8;
   /// Internal modulator.
   std::unique_ptr<modulation_mapper> modulator;

lib/phy/upper/channel_processors/channel_processor_factories.cpp

@@ -321,6 +321,7 @@ class pdsch_processor_concurrent_factory_sw : public pdsch_processor_factory
     srsran_assert(rate_matcher_factory, "Invalid rate matcher factory.");
     srsran_assert(prg_factory, "Invalid PRG factory.");
     srsran_assert(modulator_factory, "Invalid modulator factory.");
+    srsran_assert(dmrs_factory, "Invalid DM-RS factory.");
     srsran_assert(nof_concurrent_threads > 1, "Number of concurrent threads must be greater than one.");
 
     // Create vector of codeblock processors.

lib/phy/upper/upper_phy_rx_symbol_handler_impl.h

@@ -34,7 +34,7 @@ class rx_payload_buffer_pool
   /// Returns the next available buffer from the pool.
   span<uint8_t> acquire_payload_buffer(units::bytes size)
   {
-    srsran_assert(size.to_bits() <= static_cast<units::bits>(MAX_BUFFER_SIZE),
+    srsran_assert(size.to_bits().value() <= pool[index].size(),
                   "Buffer size (i.e., {}) exceeds maximum {}.",
                   size,
                   pool[index].size());