ofh,ethernet: reduce sleeping time in socket-based receiver, adjust pool size

Author: sauka

lib/ofh/ethernet/dpdk/dpdk_ethernet_transmitter.cpp

@@ -21,7 +21,7 @@ void dpdk_transmitter_impl::send(span<span<const uint8_t>> frames)
   // Receiving a frame burst larger than MAX_BURST_SIZE requires making several Tx bursts.
   for (unsigned offset = 0; offset < frames.size();) {
     auto frame_burst = frames.subspan(offset, std::min<unsigned>(MAX_BURST_SIZE, frames.size() - offset));
-    offset += frames.size();
+    offset += frame_burst.size();
 
     static_vector<::rte_mbuf*, MAX_BURST_SIZE> mbufs(frame_burst.size());
     if (::rte_pktmbuf_alloc_bulk(port_ctx->get_mempool(), mbufs.data(), frame_burst.size()) < 0) {

lib/ofh/ethernet/ethernet_receiver_impl.cpp

@@ -134,28 +134,25 @@ void receiver_impl::receive_loop()
 }
 
 /// Blocking function that waits for incoming data over the socket or until the specified timeout expires.
-static bool wait_for_data(int socket, std::chrono::seconds timeout)
+static bool wait_for_data(int socket, std::chrono::microseconds timeout)
 {
   fd_set read_fs;
   FD_ZERO(&read_fs);
   FD_SET(socket, &read_fs);
-  timeval tv = {static_cast<time_t>(timeout.count()), 0};
+  timeval tv = {0, static_cast<__suseconds_t>(timeout.count())};
 
   return (::select(socket + 1, &read_fs, nullptr, nullptr, &tv) > 0);
 }
 
 void receiver_impl::receive()
 {
-  ofh_tracer << instant_trace_event("ofh_receiver_wait_data", instant_trace_event::cpu_scope::thread);
-
-  if (!wait_for_data(socket_fd, std::chrono::seconds(1))) {
+  if (!wait_for_data(socket_fd, std::chrono::microseconds(5))) {
     return;
   }
 
   trace_point tp = ofh_tracer.now();
 
   auto exp_buffer = buffer_pool.reserve();
-
   if (exp_buffer.is_error()) {
     logger.warning("No buffer is available for receiving an Ethernet packet");
     return;

lib/ofh/ethernet/ethernet_rx_buffer_pool.h

@@ -25,8 +25,8 @@ namespace ether {
 /// Pool of buffers accessed by a socket-based Ethernet receiver.
 class ethernet_rx_buffer_pool
 {
-  /// Allocate 2MB of storage, evenly divided between Ethernet receive buffers.
-  static inline constexpr units::bytes ETH_BUFFER_POOL_SIZE{2048000};
+  /// Allocate 4MB of storage, evenly divided between Ethernet receive buffers.
+  static inline constexpr units::bytes ETH_BUFFER_POOL_SIZE{4096000};
 
   using rx_buffer_id_list =
       concurrent_queue<unsigned, concurrent_queue_policy::lockfree_spsc, concurrent_queue_wait_policy::non_blocking>;

lib/ofh/transmitter/ofh_message_transmitter_impl.cpp

@@ -88,9 +88,9 @@ void message_transmitter_impl::on_new_symbol(slot_symbol_point symbol_point)
   enqueue_messages_into_burst(interval_up, frame_burst);
 
   // Transmit the data.
-  trace_point tp_dpdk = ofh_tracer.now();
+  trace_point tp_ether = ofh_tracer.now();
   transmit_frame_burst(frame_burst);
-  ofh_tracer << trace_event("ofh_dpdk_tx", tp_dpdk);
+  ofh_tracer << trace_event("ofh_ether_tx", tp_ether);
 
   // Clear sent buffers.
   pool->clear_sent_frame_buffers(interval_cp_dl);