adt: fix byte_buffer_test of concatenated vectors

robertfalkenberg · codebot · commit aaab37c4a132 · 2024-05-17T14:11:42.000Z
diff --git a/tests/unittests/adt/byte_buffer_test.cpp b/tests/unittests/adt/byte_buffer_test.cpp
@@ -396,7 +396,8 @@ TEST_P(two_vector_size_param_test, shallow_copy_and_append)
     ASSERT_EQ(pdu.length(), pdu.end() - pdu.begin()) << "shallow copied-from byte_buffer::length() got corrupted";
     ASSERT_EQ(pdu2.length(), pdu2.end() - pdu2.begin()) << "shallow copy byte_buffer::length() got corrupted";
   }
-  ASSERT_EQ_BUFFER(pdu, concat_vec(bytes1, bytes2));
+  auto combined = concat_vec(bytes1, bytes2);
+  ASSERT_EQ_BUFFER(pdu, combined);
   ASSERT_EQ(pdu.length(), pdu.end() - pdu.begin());
 }
 
@@ -416,7 +417,8 @@ TEST_P(three_vector_size_param_test, shallow_copy_prepend_and_append)
     ASSERT_EQ(pdu.length(), pdu.end() - pdu.begin()) << "shallow copied-from byte_buffer::length() got corrupted";
     ASSERT_EQ(pdu2.length(), pdu2.end() - pdu2.begin()) << "shallow copy byte_buffer::length() got corrupted";
   }
-  ASSERT_EQ_BUFFER(pdu, concat_vec(bytes2, concat_vec(bytes1, bytes3)));
+  auto combined = concat_vec(bytes2, concat_vec(bytes1, bytes3));
+  ASSERT_EQ_BUFFER(pdu, combined);
   ASSERT_EQ(pdu.length(), pdu.end() - pdu.begin());
 }
 

Original file line number	Diff line number	Diff line change
`@@ -396,7 +396,8 @@ TEST_P(two_vector_size_param_test, shallow_copy_and_append)`
`396`	`396`	`ASSERT_EQ(pdu.length(), pdu.end() - pdu.begin()) << "shallow copied-from byte_buffer::length() got corrupted";`
`397`	`397`	`ASSERT_EQ(pdu2.length(), pdu2.end() - pdu2.begin()) << "shallow copy byte_buffer::length() got corrupted";`
`398`	`398`	`}`
`399`		`- ASSERT_EQ_BUFFER(pdu, concat_vec(bytes1, bytes2));`
	`399`	`+ auto combined = concat_vec(bytes1, bytes2);`
	`400`	`+ ASSERT_EQ_BUFFER(pdu, combined);`
`400`	`401`	`ASSERT_EQ(pdu.length(), pdu.end() - pdu.begin());`
`401`	`402`	`}`
`402`	`403`
`@@ -416,7 +417,8 @@ TEST_P(three_vector_size_param_test, shallow_copy_prepend_and_append)`
`416`	`417`	`ASSERT_EQ(pdu.length(), pdu.end() - pdu.begin()) << "shallow copied-from byte_buffer::length() got corrupted";`
`417`	`418`	`ASSERT_EQ(pdu2.length(), pdu2.end() - pdu2.begin()) << "shallow copy byte_buffer::length() got corrupted";`
`418`	`419`	`}`
`419`		`- ASSERT_EQ_BUFFER(pdu, concat_vec(bytes2, concat_vec(bytes1, bytes3)));`
	`420`	`+ auto combined = concat_vec(bytes2, concat_vec(bytes1, bytes3));`
	`421`	`+ ASSERT_EQ_BUFFER(pdu, combined);`
`420`	`422`	`ASSERT_EQ(pdu.length(), pdu.end() - pdu.begin());`
`421`	`423`	`}`
`422`	`424`