sched: fix other comments in pucch alloc/res mng

Signed-off-by: Carlo Galiotto <[email protected]>

Author: carlo-gal

lib/scheduler/pucch_scheduling/pucch_allocator_impl.cpp

@@ -1133,6 +1133,7 @@ pucch_harq_ack_grant pucch_allocator_impl::update_format2_grant(pucch_info&
   }
 
   logger.debug("ue={:#x}'s UCI mltplxd on existing PUCCH F2 for slot={}", existing_f2_grant.crnti, sl_tx);
+  // When the chosen resource is for CSI only, the resource indicator won't be used and can be set to any value.
   const unsigned res_indicator = use_pucch_f2_csi_res ? 0U : pucch_f2_harq_info.pucch_res_indicator;
   return pucch_harq_ack_grant{.pucch_res_indicator = static_cast<unsigned>(res_indicator),
                               .pucch_pdu           = &existing_f2_grant};

lib/scheduler/pucch_scheduling/pucch_resource_manager.cpp

@@ -286,7 +286,7 @@ pucch_resource_manager::fetch_allocated_f2_harq_resource(slot_point          slo
                                                          const pucch_config& pucch_cfg)
 {
   srsran_sanity_check(slot_harq < last_sl_ind + RES_MANAGER_RING_BUFFER_SIZE,
-                      "PUCCH being allocated to far into the future");
+                      "PUCCH being allocated too far into the future");
 
   // Get resource list of wanted slot.
   rnti_pucch_res_id_slot_record& res_counter = get_slot_resource_counter(slot_harq);

lib/scheduler/uci_scheduling/uci_allocator_impl.cpp

@@ -208,17 +208,15 @@ void uci_allocator_impl::multiplex_uci_on_pusch(ul_sched_info&                pu
                                                 const ue_cell_configuration&  ue_cell_cfg,
                                                 rnti_t                        crnti)
 {
-  // Note: the UCI bits is capped to the PUCCH Format 2 capacity. When multiplexing UCI to PUSCH, we only "tranfer"
-  // the bits that would have been fit within the PUCCH, not the all the bits that should have been reported.
-  // TODO: Check if this approach is correct.
+  // Move the bits that are carried by the PUCCH into the PUSCH.
   const pucch_uci_bits pucch_uci = pucch_alloc.remove_ue_uci_from_pucch(slot_alloc, crnti, ue_cell_cfg);
 
   // In case there are no UCI bits from PUCCH, then there is no UCI to be multiplexed on the PUSCH.
   if (pucch_uci.harq_ack_nof_bits == 0 and pucch_uci.csi_part1_bits == 0) {
     return;
   }
 
-  // We assume that at this point, there are no existing UCI grants in the PUSCH; allocate one.
+  // We assume that at this point, there are no existing UCI grants in the PUSCH; allocate a new one.
   uci_info& uci = pusch_grant.uci.emplace();
   fill_uci_on_pusch(uci,
                     ue_cell_cfg.cfg_dedicated().ul_config.value().init_ul_bwp.pusch_cfg.value().uci_cfg.value(),