app: fix unnecessary adding of TDD pattern2 even when not configured

herlesupreeth · herlesupreeth · commit d7bbf4796f77 · 2023-07-21T09:55:06.000+02:00
diff --git a/apps/gnb/gnb_appconfig_cli11_schema.cpp b/apps/gnb/gnb_appconfig_cli11_schema.cpp
@@ -660,7 +660,7 @@ static void configure_cli11_tdd_ul_dl_args(CLI::App& app, tdd_ul_dl_appconfig& t
       tdd_ul_dl_params.pattern2.reset();
     }
   };
-  app.callback(tdd_ul_dl_verify_callback);
+  app.parse_complete_callback(tdd_ul_dl_verify_callback);
 }
 
 static void configure_cli11_paging_args(CLI::App& app, paging_appconfig& pg_params)
@@ -825,7 +825,7 @@ static void configure_cli11_common_cell_args(CLI::App& app, base_cell_appconfig&
       cell_params.tdd_ul_dl_cfg.reset();
     }
   };
-  app.callback(tdd_ul_dl_verify_callback);
+  app.parse_complete_callback(tdd_ul_dl_verify_callback);
 
   // Paging configuration.
   CLI::App* paging_subcmd = app.add_subcommand("paging", "Paging parameters");

Original file line number	Diff line number	Diff line change
`@@ -660,7 +660,7 @@ static void configure_cli11_tdd_ul_dl_args(CLI::App& app, tdd_ul_dl_appconfig& t`
`660`	`660`	`tdd_ul_dl_params.pattern2.reset();`
`661`	`661`	`}`
`662`	`662`	`};`
`663`		`- app.callback(tdd_ul_dl_verify_callback);`
	`663`	`+ app.parse_complete_callback(tdd_ul_dl_verify_callback);`
`664`	`664`	`}`
`665`	`665`
`666`	`666`	`static void configure_cli11_paging_args(CLI::App& app, paging_appconfig& pg_params)`
`@@ -825,7 +825,7 @@ static void configure_cli11_common_cell_args(CLI::App& app, base_cell_appconfig&`
`825`	`825`	`cell_params.tdd_ul_dl_cfg.reset();`
`826`	`826`	`}`
`827`	`827`	`};`
`828`		`- app.callback(tdd_ul_dl_verify_callback);`
	`828`	`+ app.parse_complete_callback(tdd_ul_dl_verify_callback);`
`829`	`829`
`830`	`830`	`// Paging configuration.`
`831`	`831`	`CLI::App* paging_subcmd = app.add_subcommand("paging", "Paging parameters");`