support: timer ticks based on io broker

Author: frankist

lib/support/network/io_timer_source.cpp

@@ -21,14 +21,17 @@ io_timer_source::io_timer_source(timer_manager&            tick_sink_,
                                  std::chrono::milliseconds tick_period_) :
   tick_sink(tick_sink_), broker(broker_), tick_period(tick_period_), logger(srslog::fetch_basic_logger("IO-EPOLL"))
 {
+  using namespace std::chrono;
+
   timer_fd = unique_fd{timerfd_create(CLOCK_REALTIME, 0)};
   if (not timer_fd.is_open()) {
     report_fatal_error_if_not("Failed to create timer source (errno={})", strerror(errno));
   }
 
-  struct itimerspec timerspec = {{0, 0},
-                                 {std::chrono::duration_cast<std::chrono::seconds>(tick_period).count(),
-                                  std::chrono::duration_cast<std::chrono::nanoseconds>(tick_period).count()}};
+  auto              tsecs     = duration_cast<seconds>(tick_period);
+  auto              tnsecs    = duration_cast<nanoseconds>(tick_period) - duration_cast<nanoseconds>(tsecs);
+  struct timespec   period    = {tsecs.count(), tnsecs.count()};
+  struct itimerspec timerspec = {period, period};
   timerfd_settime(timer_fd.value(), 0, &timerspec, nullptr);
 
   io_sub = broker.register_fd(

tests/unittests/support/network/CMakeLists.txt

@@ -8,6 +8,6 @@
 
 set_directory_properties(PROPERTIES LABELS "io_broker")
 
-add_executable(network_test transport_layer_address_test.cpp io_broker_epoll_test.cpp)
+add_executable(network_test transport_layer_address_test.cpp io_broker_epoll_test.cpp io_timer_source_test.cpp)
 target_link_libraries(network_test srsran_network srsran_support srslog gtest gtest_main)
 gtest_discover_tests(network_test)

tests/unittests/support/network/io_timer_source_test.cpp

@@ -0,0 +1,63 @@
+/*
+ *
+ * Copyright 2021-2024 Software Radio Systems Limited
+ *
+ * By using this file, you agree to the terms and conditions set
+ * forth in the LICENSE file which can be found at the top level of
+ * the distribution.
+ *
+ */
+
+#include "srsran/support/executors/manual_task_worker.h"
+#include "srsran/support/io/io_broker_factory.h"
+#include "srsran/support/io/io_timer_source.h"
+#include "srsran/support/timers.h"
+#include <gtest/gtest.h>
+#include <optional>
+
+using namespace srsran;
+
+class io_timer_source_test : public ::testing::Test
+{
+public:
+  manual_task_worker         worker{16};
+  timer_manager              timers{16};
+  std::unique_ptr<io_broker> broker = create_io_broker(srsran::io_broker_type::epoll);
+
+  void start() { source.emplace(timers, *broker, std::chrono::milliseconds{1}); }
+
+  void stop() { source.reset(); }
+
+  std::optional<io_timer_source> source;
+};
+
+TEST_F(io_timer_source_test, timer_gets_ticked_when_source_starts)
+{
+  std::chrono::milliseconds run_duration{100};
+  std::chrono::milliseconds timer_period{5};
+  unsigned                  count = 0;
+  unique_timer              t     = timers.create_unique_timer(worker);
+  t.set(timer_period, [&count, &t](timer_id_t tid) {
+    count++;
+    t.run();
+  });
+  t.run();
+
+  std::this_thread::sleep_for(std::chrono::milliseconds{10});
+  worker.run_pending_tasks();
+  ASSERT_EQ(count, 0);
+
+  start();
+  for (unsigned i = 0; i != run_duration.count(); i++) {
+    std::this_thread::sleep_for(std::chrono::milliseconds{1});
+    worker.run_pending_tasks();
+  }
+  ASSERT_GT(count, 1);
+  fmt::print("Tick count: expected={} actual={}\n", run_duration / timer_period, count);
+
+  stop();
+  count = 0;
+  std::this_thread::sleep_for(std::chrono::milliseconds{10});
+  worker.run_pending_tasks();
+  ASSERT_EQ(count, 0);
+}