sched: rename notifier function argument

Author: frankist

include/srsran/scheduler/scheduler_configurator.h

@@ -159,9 +159,9 @@ class scheduler_ue_configurator
 class sched_configuration_notifier
 {
 public:
-  virtual ~sched_configuration_notifier()                                  = default;
-  virtual void on_ue_config_complete(du_ue_index_t ue_index, bool success) = 0;
-  virtual void on_ue_delete_response(du_ue_index_t ue_index)               = 0;
+  virtual ~sched_configuration_notifier()                                             = default;
+  virtual void on_ue_config_complete(du_ue_index_t ue_index, bool ue_creation_result) = 0;
+  virtual void on_ue_delete_response(du_ue_index_t ue_index)                          = 0;
 };
 
 } // namespace srsran

lib/mac/mac_sched/srsran_scheduler_adapter.cpp

@@ -194,13 +194,15 @@ const sched_result& srsran_scheduler_adapter::slot_indication(slot_point slot_tx
   return res;
 }
 
-void srsran_scheduler_adapter::sched_config_notif_adapter::on_ue_config_complete(du_ue_index_t ue_index, bool success)
+void srsran_scheduler_adapter::sched_config_notif_adapter::on_ue_config_complete(du_ue_index_t ue_index,
+                                                                                 bool          ue_creation_result)
 {
   srsran_sanity_check(is_du_ue_index_valid(ue_index), "Invalid ue index={}", ue_index);
 
   // Remove continuation of task in ctrl executor.
-  if (not parent.ctrl_exec.defer(
-          [this, ue_index, success]() { parent.sched_cfg_notif_map[ue_index].ue_config_ready.set(success); })) {
+  if (not parent.ctrl_exec.defer([this, ue_index, ue_creation_result]() {
+        parent.sched_cfg_notif_map[ue_index].ue_config_ready.set(ue_creation_result);
+      })) {
     parent.logger.error("ue={}: Unable to finish UE configuration. Cause: DU task queue is full.", ue_index);
   }
 }

lib/mac/mac_sched/srsran_scheduler_adapter.h

@@ -96,7 +96,7 @@ class srsran_scheduler_adapter final : public mac_scheduler_adapter
   {
   public:
     explicit sched_config_notif_adapter(srsran_scheduler_adapter& parent_) : parent(parent_) {}
-    void on_ue_config_complete(du_ue_index_t ue_index, bool success) override;
+    void on_ue_config_complete(du_ue_index_t ue_index, bool ue_creation_result) override;
     void on_ue_delete_response(du_ue_index_t ue_index) override;
 
   private:

tests/benchmarks/scheduler/scheduler_no_ues_benchmark.cpp

@@ -20,7 +20,7 @@ using namespace srsran;
 class sched_cfg_dummy_notifier : public sched_configuration_notifier
 {
 public:
-  void on_ue_config_complete(du_ue_index_t ue_index, bool success) override {}
+  void on_ue_config_complete(du_ue_index_t ue_index, bool ue_creation_result) override {}
   void on_ue_delete_response(du_ue_index_t ue_index) override {}
 };
 

tests/unittests/scheduler/test_utils/dummy_test_components.h

@@ -137,7 +137,7 @@ class sched_cfg_dummy_notifier : public sched_configuration_notifier
   optional<du_ue_index_t> last_ue_index_cfg;
   optional<du_ue_index_t> last_ue_index_deleted;
 
-  void on_ue_config_complete(du_ue_index_t ue_index, bool success) override { last_ue_index_cfg = ue_index; }
+  void on_ue_config_complete(du_ue_index_t ue_index, bool ue_creation_result) override { last_ue_index_cfg = ue_index; }
   void on_ue_delete_response(du_ue_index_t ue_index) override { last_ue_index_deleted = ue_index; }
 };