all what's required for vJunosEVO v25

(version tested both with vagrant and clab)

Fix ipspace#2644

Author: ssasso

docs/caveats.md

@@ -350,7 +350,7 @@ You can change the license file parameters within a node definition or with **de
 
 * *netlab* supports only vJunosEvolved releases that do not require external PFE- and RPIO links. The first vJunosEvolved release implementing internal PFE- and RPIO links is the release 23.2R1-S1.8.
 * vJunosEvolved software is supposed to be run on an Intel CPU. _netlab_ implements the hacks [suggested by Juniper to run vJunos on an AMD CPU](https://www.juniper.net/documentation/us/en/software/nce/nce-510-virtual-switches-mist-cloud-managed/amd-cpu_unofficial_tweaks.html), but please note that this is not supported.
-* _netlab_ can start virtual machines running vJunosEvolved release 23.2 (release 24.1 and later requires UEFI BIOS). Use the vrnetlab-generated container as a workaround if you want to run vJunosEvolved release 24.1 or later.
+* _netlab_ can start virtual machines running vJunosEvolved release 24.1+ (which requires UEFI BIOS - previous releases do not work with UEFI BIOS). Use the vrnetlab-generated container as a workaround if you want to run older vJunosEvolved releases.
 * _netlab_ supports the [vrnetlab-generated](https://containerlab.dev/manual/kinds/vr-vjunosevolved/) vJunosEvolved container, not the cJunosEvolved container. The differences between the two make it impossible to run both container versions as the same virtual device, and cJunosEvolved offers no significant advantages at the moment.
 * The vJunosEvolved container runs on Intel and AMD CPU.
 * The virtual MAC address of the anycast gateway is ignored. _netlab_, therefore, does not support the anycast gateway on vPTX.

netsim/devices/vptx.yml

@@ -24,7 +24,7 @@ libvirt:
   create_template: vptx.xml.j2
 
 clab:
-  image: vrnetlab/juniper_vjunosevolved:23.4R2-S2.1
+  image: vrnetlab/juniper_vjunosevolved:25.2R1.8-EVO
   build: https://containerlab.dev/manual/kinds/vr-vjunosevolved/
   mtu: 1500
   node:

netsim/install/libvirt/vptx.xml.j2

@@ -63,6 +63,8 @@
     <ns0:arg value="type=0,vendor=Bochs,version=Bochs"/>
     <ns0:arg value="-smbios"/>
     <ns0:arg value="type=3,manufacturer=Bochs"/>
+    <ns0:arg value="-bios"/>
+    <ns0:arg value="/usr/share/qemu/OVMF.fd"/>
     <ns0:arg value="-smbios"/>
     <ns0:arg value="type=1,manufacturer=Bochs,product=Bochs,serial=chassis_no=0:slot=0:type=1:assembly_id=0x0D20:platform=251:master=0:channelized=no"/>
   </ns0:commandline>

netsim/templates/provider/libvirt/vptx-domain.j2

@@ -15,10 +15,10 @@
       domain.video_type = "none"
       domain.nested = true
 
-{#
+{# -- add if condition here for UEFI (rel >24) #}
       domain.loader = "/usr/share/OVMF/OVMF_CODE_4M.fd"
       domain.nvram = "/var/lib/libvirt/qemu/nvram/{{ name }}.fd"
-#}
+
       domain.machine_type = "q35"
       domain.cpu_mode = "host-passthrough"