Refactor to remove unused function arguments

christianbundy · christianbundy · commit 18699b141b7d · 2019-08-05T07:20:28.000-07:00
diff --git a/index.js b/index.js
@@ -31,7 +31,7 @@ function quitIfAlreadyRunning () {
     console.log('Please close the existing instance before starting a new one.')
     return electron.app.quit()
   }
-  electron.app.on('second-instance', (event, commandLine, workingDirectory) => {
+  electron.app.on('second-instance', () => {
     // Someone tried to run a second instance, we should focus our window.
     if (windows.main) {
       if (windows.main.isMinimized()) windows.main.restore()
@@ -116,7 +116,7 @@ electron.app.on('ready', () => {
     Menu.setApplicationMenu(Menu.buildFromTemplate(menu))
   })
 
-  electron.app.on('activate', function (e) {
+  electron.app.on('activate', function () {
     if (windows.main) {
       windows.main.show()
     }
@@ -126,7 +126,7 @@ electron.app.on('ready', () => {
     quitting = true
   })
 
-  electron.ipcMain.on('open-background-devtools', function (ev, config) {
+  electron.ipcMain.on('open-background-devtools', function () {
     if (windows.background) {
       windows.background.webContents.openDevTools({ mode: 'detach' })
     }
diff --git a/lib/depject/about/sync.js b/lib/depject/about/sync.js
@@ -2,7 +2,7 @@ var nest = require('depnest')
 
 exports.gives = nest('about.sync.shortFeedId')
 
-exports.create = function (api) {
+exports.create = function () {
   return nest('about.sync.shortFeedId', function (id) {
     return id.slice(1, 10)
   })
diff --git a/lib/depject/about/sync/short-feed-id.js b/lib/depject/about/sync/short-feed-id.js
@@ -2,7 +2,7 @@ var nest = require('depnest')
 
 exports.gives = nest('about.sync.shortFeedId')
 
-exports.create = function (api) {
+exports.create = function () {
   return nest('about.sync.shortFeedId', function (id) {
     return `${id.slice(0, 10)}...`
   })
diff --git a/lib/depject/app/html/progress-notifier.js b/lib/depject/app/html/progress-notifier.js
@@ -18,7 +18,7 @@ exports.needs = nest({
 
 exports.create = function (api) {
   const i18n = api.intl.sync.i18n
-  return nest('app.html.progressNotifier', function (id) {
+  return nest('app.html.progressNotifier', function () {
     var replicateProgress = api.progress.obs.replicate()
     var indexes = api.progress.obs.indexes()
     var migration = api.progress.obs.migration()
diff --git a/lib/depject/app/link-preview.js b/lib/depject/app/link-preview.js
@@ -14,7 +14,7 @@ exports.gives = nest('app.linkPreview')
 
 exports.create = function (api) {
   var i18n = api.intl.sync.i18n
-  return nest('app.linkPreview', function (container, delay) {
+  return nest('app.linkPreview', function (container) {
     var currentHover = ObserveLinkHover(container, (value, lastValue) => {
       var href = value && value.getAttribute('href')
       var oldHref = lastValue && lastValue.getAttribute('href')
diff --git a/lib/depject/app/sync/external-handler/git.js b/lib/depject/app/sync/external-handler/git.js
@@ -15,7 +15,7 @@ var gitMessageTypes = [
   'pull-request'
 ]
 
-exports.create = (api) => {
+exports.create = () => {
   return nest('app.sync.externalHandler', function (msg) {
     if (!gitMessageTypes.includes(msg.value.content.type)) return
     return function gitHandler (id) {
@@ -29,12 +29,12 @@ exports.create = (api) => {
 function portInUse (port, cb) {
   /* eslint-disable standard/no-callback-literal */
   // super hacky check!
-  var server = net.createServer(function (socket) {})
+  var server = net.createServer(function () {})
   server.listen(port, '127.0.0.1')
-  server.on('error', function (e) {
+  server.on('error', function () {
     cb(true)
   })
-  server.on('listening', function (e) {
+  server.on('listening', function () {
     server.close()
     cb(false)
   })
diff --git a/lib/depject/app/views.js b/lib/depject/app/views.js
@@ -3,7 +3,7 @@ var nest = require('depnest')
 
 exports.gives = nest('app.views')
 
-exports.create = function (api) {
+exports.create = function () {
   return nest('app.views', function (renderPage, defaultViews) {
     var views = Dict({})
 
diff --git a/lib/depject/channel/html/subscribe-toggle.js b/lib/depject/channel/html/subscribe-toggle.js
@@ -11,7 +11,7 @@ exports.needs = nest({
 
 exports.create = function (api) {
   var i18n = api.intl.sync.i18n
-  return nest('channel.html.subscribeToggle', function (channel, opts) {
+  return nest('channel.html.subscribeToggle', function (channel) {
     var yourId = api.keys.sync.id()
     var subscribedChannels = api.channel.obs.subscribed(yourId)
 
diff --git a/lib/depject/channel/sync/normalize.js b/lib/depject/channel/sync/normalize.js
@@ -3,6 +3,6 @@ var normalizeChannel = require('ssb-ref').normalizeChannel
 
 exports.gives = nest('channel.sync.normalize')
 
-exports.create = function (api) {
+exports.create = function () {
   return nest('channel.sync.normalize', normalizeChannel)
 }
diff --git a/lib/depject/feed/html/rollup.js b/lib/depject/feed/html/rollup.js
@@ -49,8 +49,6 @@ exports.create = function (api) {
     hidden = false,
     groupSummaries = true,
     compactFilter = returnFalse,
-    filterRepliesIfBlockedByRootAuthor = true,
-    displayFilter = returnTrue,
     ungroupFilter = returnFalse,
     searchSpinner = false,
     updateStream
@@ -75,12 +73,12 @@ exports.create = function (api) {
       intersectionBindingViewport: { rootMargin: '1000px' },
 
       style: { overflow: 'auto' },
-      hooks: [(element) => {
+      hooks: [() => {
         // don't activate until added to DOM
         refresh()
 
         if (isObservable(hidden)) {
-          unwatchHidden = hidden((hidden) => {
+          unwatchHidden = hidden(() => {
             refresh()
           })
         }
@@ -356,10 +354,6 @@ function getAuthors (items) {
   return Object.keys(authors)
 }
 
-function returnTrue () {
-  return true
-}
-
 function returnFalse () {
   return false
 }
diff --git a/lib/depject/gathering/sheet/edit.js b/lib/depject/gathering/sheet/edit.js
@@ -257,7 +257,7 @@ function PickrHook (obs) {
       enableTime: true,
       altInput: true,
       dateFormat: 'U',
-      onChange: function (dates) {
+      onChange: function () {
         obs.set(spacetime(parseInt(element.value, 10) * 1000))
       }
     })
diff --git a/lib/depject/intl/sync/i18n.js b/lib/depject/intl/sync/i18n.js
@@ -47,7 +47,7 @@ exports.create = (api) => {
   }
 
   // Get all locales loaded in i18nL
-  function locales (sofar = {}) {
+  function locales () {
     return i18nL.getLocales()
   }
 
diff --git a/lib/depject/invite/invite.js b/lib/depject/invite/invite.js
@@ -40,7 +40,7 @@ exports.create = function (api) {
       progress.set('Requesting follow...')
 
       // ask them to follow us
-      sbot.invite.use({ feed: id }, function (err, msg) {
+      sbot.invite.use({ feed: id }, function (err) {
         if (err) {
           // the probably already follow us
           api.contact.async.followerOf(id, data.key, function (_, follows) {
diff --git a/lib/depject/message/html/decorate/context-menu.js b/lib/depject/message/html/decorate/context-menu.js
@@ -2,7 +2,7 @@ const nest = require('depnest')
 
 exports.gives = nest('message.html.decorate')
 
-exports.create = (api) => {
+exports.create = () => {
   return nest('message.html.decorate', function (element, { msg }) {
     // accessed from lib/context-menu-and-spellcheck
     element.msg = { key: msg.key }
diff --git a/lib/depject/message/html/missing.js b/lib/depject/message/html/missing.js
@@ -15,7 +15,7 @@ exports.gives = nest('message.html.missing')
 
 exports.create = function (api) {
   const i18n = api.intl.sync.i18n
-  return nest('message.html.missing', function (id, hintMessage, rootMessage) {
+  return nest('message.html.missing', function (id, hintMessage) {
     if (!ref.isMsg(id)) return
     var msg = api.message.obs.get(id, hintMessage)
     return computed(msg, msg => {
diff --git a/lib/depject/message/sync/root.js b/lib/depject/message/sync/root.js
@@ -3,7 +3,7 @@ var nest = require('depnest')
 
 exports.gives = nest('message.sync.root', true)
 
-exports.create = function (api) {
+exports.create = function () {
   return nest('message.sync.root', function (msg) {
     if (msg && msg.value && msg.value.content) {
       var type = msg.value.content.type
diff --git a/lib/depject/message/sync/timestamp.js b/lib/depject/message/sync/timestamp.js
@@ -7,7 +7,7 @@ exports.gives = nest('message.sync.timestamp', true)
 // received before the claimed time, then use receive time
 // (handles clocks set into the future, and avoid received "3 mins from now" issue!)
 
-exports.create = function (api) {
+exports.create = function () {
   return nest('message.sync.timestamp', function (msg) {
     return getTimestamp(msg)
   })
diff --git a/lib/depject/page/html/render/search.js b/lib/depject/page/html/render/search.js
@@ -62,7 +62,7 @@ exports.create = function (api) {
     pull(
       getStream(query, true),
       realtimeAborter,
-      pull.drain(msg => {
+      pull.drain(() => {
         updates.set(updates() + 1)
       })
     )
@@ -111,7 +111,7 @@ exports.create = function (api) {
         scroller
       )
 
-      loading.set(computed([done, scroller.queue], (done, queue) => {
+      loading.set(computed([done, scroller.queue], (done) => {
         return !done
       }))
     }
@@ -192,7 +192,7 @@ function highlight (el, query) {
 }
 
 function RemoveHook (fn) {
-  return function (element) {
+  return function () {
     return fn
   }
 }
diff --git a/lib/depject/page/html/render/tag.js b/lib/depject/page/html/render/tag.js
@@ -28,7 +28,7 @@ exports.create = function (api) {
     const showMostActive = Value(parts[4] !== 'recent')
 
     const usedByYou = scuttleTag.obs.allTagsFrom(myId)
-    const mostActive = map(scuttleTag.obs.mostActive(), ([id, count]) => id, {
+    const mostActive = map(scuttleTag.obs.mostActive(), ([id]) => id, {
       comparer: (a, b) => {
         if (Array.isArray(a) && Array.isArray(b)) {
           return a[0] === b[0] && a[1] === b[1]
diff --git a/lib/depject/progress/html/render.js b/lib/depject/progress/html/render.js
@@ -5,7 +5,7 @@ var nest = require('depnest')
 
 exports.gives = nest('progress.html.render')
 
-exports.create = function (api) {
+exports.create = function () {
   return nest('progress.html.render', function (pos, classList) {
     var pending = computed(pos, x => x > 0 && x < 1)
     return svg('svg RadialProgress', {
diff --git a/lib/expander-hook.js b/lib/expander-hook.js
@@ -16,7 +16,7 @@ function expander (needsExpand, element) {
   }
 }
 
-function handleEvent (ev) {
+function handleEvent () {
   var { needsExpand, element } = this
   if (!needsExpand()) {
     if (element.firstElementChild && element.firstElementChild.clientHeight + 5 > element.clientHeight) {
diff --git a/lib/main-window.js b/lib/main-window.js
@@ -317,7 +317,7 @@ module.exports = function (config) {
 
   function dropTab (title, items) {
     var element = h('a -drop', {
-      'ev-click': (ev) => {
+      'ev-click': () => {
         var rects = element.getBoundingClientRect()
         electron.remote.getCurrentWindow().webContents.getZoomFactor((factor) => {
           var menu = electron.remote.Menu.buildFromTemplate(items.map(item => {
@@ -391,7 +391,7 @@ module.exports = function (config) {
   function tab (name, view) {
     var instance = views.get(view)
     return h('a', {
-      'ev-click': function (ev) {
+      'ev-click': function () {
         var instance = views.get(view)
         var isSelected = views.currentView() === view
         var needsRefresh = instance && instance.pendingUpdates && instance.pendingUpdates()
@@ -424,7 +424,7 @@ function overrideConfig (config) {
   return {
     'patchwork/config': {
       gives: nest('config.sync.load'),
-      create: function (api) {
+      create: function () {
         return nest('config.sync.load', () => config)
       }
     }
@@ -435,7 +435,7 @@ function addCommand (id, cb) {
   return {
     [`patchwork/command/${id}`]: {
       gives: nest(id),
-      create: function (api) {
+      create: function () {
         return nest(id, cb)
       }
     }
diff --git a/lib/observe-link-hover.js b/lib/observe-link-hover.js
@@ -14,7 +14,7 @@ module.exports = function (root, delay) {
     target.set(anchor)
   })
 
-  root.addEventListener('mouseleave', (ev) => {
+  root.addEventListener('mouseleave', () => {
     target.set(false)
   })
 
diff --git a/lib/plugins/backlinks.js b/lib/plugins/backlinks.js
@@ -7,7 +7,7 @@ exports.manifest = {
 
 var excludeTypes = ['about', 'vote', 'tag']
 
-exports.init = function (ssb, config) {
+exports.init = function (ssb) {
   return {
     referencesStream: function ({ id, since }) {
       return getBacklinksStream(id, since, (msg) => {
diff --git a/lib/plugins/channel-feed.js b/lib/plugins/channel-feed.js
@@ -16,7 +16,7 @@ exports.manifest = {
   roots: 'source'
 }
 
-exports.init = function (ssb, config) {
+exports.init = function (ssb) {
   // cache mostly just to avoid reading the same roots over and over again
   // not really big enough for multiple refresh cycles
   var cache = HLRU(100)
diff --git a/lib/plugins/channels.js b/lib/plugins/channels.js
@@ -13,7 +13,7 @@ exports.manifest = {
   recentStream: 'source'
 }
 
-exports.init = function (ssb, config) {
+exports.init = function (ssb) {
   var index = ssb._flumeUse('patchwork-channels', FlumeReduce(3, reduce, map))
   return {
     get: index.get,
diff --git a/lib/plugins/contacts.js b/lib/plugins/contacts.js
@@ -12,7 +12,7 @@ exports.manifest = {
   isBlocking: 'async'
 }
 
-exports.init = function (ssb, config) {
+exports.init = function (ssb) {
   var values = {}
 
   var view = ssb._flumeUse('patchwork-contacts', FlumeReduce(0, function reduce (result, item) {
@@ -78,7 +78,7 @@ exports.init = function (ssb, config) {
     },
 
     /// return a list of everyone you have blocked privately
-    ignoreStream: function ({ live }, cb) {
+    ignoreStream: function ({ live }) {
       var stream = PullPushAbort()
 
       var result = {}
@@ -138,7 +138,7 @@ exports.init = function (ssb, config) {
     },
 
     // return who a given contact publicly follows and blocks (or reverse)
-    stateStream: function ({ feedId, live = false, reverse = false }, cb) {
+    stateStream: function ({ feedId, live = false, reverse = false }) {
       var stream = PullPushAbort()
 
       var result = {}
diff --git a/lib/plugins/gatherings.js b/lib/plugins/gatherings.js
@@ -13,7 +13,7 @@ exports.manifest = {
   roots: 'source'
 }
 
-exports.init = function (ssb, config) {
+exports.init = function (ssb) {
   return {
     latest: function () {
       return pull(
diff --git a/lib/plugins/heartbeat.js b/lib/plugins/heartbeat.js
@@ -1,5 +1,5 @@
 var Pushable = require('pull-pushable')
-module.exports = function (ssb, config) {
+module.exports = function () {
   return function () {
     var stream = Pushable(() => {
       clearInterval(timer)
diff --git a/lib/plugins/index.js b/lib/plugins/index.js
@@ -189,7 +189,7 @@ exports.init = function (ssb, config) {
         var requesterId = peer.id
         var feedId = opts.id
         if (graph && feedId !== requesterId && graph[feedId] && graph[feedId][requesterId] === false) {
-          cb(null, function (abort, cb) {
+          cb(null, function () {
             // just give them the cold shoulder
           })
         } else {
diff --git a/lib/plugins/likes.js b/lib/plugins/likes.js
diff --git a/lib/plugins/live-backlinks.js b/lib/plugins/live-backlinks.js
diff --git a/lib/plugins/mentions-feed.js b/lib/plugins/mentions-feed.js
diff --git a/lib/plugins/network-feed.js b/lib/plugins/network-feed.js
diff --git a/lib/plugins/participating-feed.js b/lib/plugins/participating-feed.js
diff --git a/lib/plugins/private-feed.js b/lib/plugins/private-feed.js
diff --git a/lib/plugins/profile.js b/lib/plugins/profile.js
diff --git a/lib/plugins/progress.js b/lib/plugins/progress.js
diff --git a/lib/plugins/public-feed.js b/lib/plugins/public-feed.js
diff --git a/lib/plugins/recent-feeds.js b/lib/plugins/recent-feeds.js
diff --git a/lib/plugins/search.js b/lib/plugins/search.js
diff --git a/lib/plugins/subscriptions.js b/lib/plugins/subscriptions.js
diff --git a/lib/plugins/subscriptions2.js b/lib/plugins/subscriptions2.js
diff --git a/lib/plugins/thread.js b/lib/plugins/thread.js

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,6 @@ var normalizeChannel = require('ssb-ref').normalizeChannel`
`3`	`3`
`4`	`4`	`exports.gives = nest('channel.sync.normalize')`
`5`	`5`
`6`		`-exports.create = function (api) {`
	`6`	`+exports.create = function () {`
`7`	`7`	`return nest('channel.sync.normalize', normalizeChannel)`
`8`	`8`	`}`