Refactor pw::trim to use argument instead of reading stdin

Author: sschmid

src/migrations/pwconf-12.0.0

@@ -23,7 +23,7 @@ if [[ -f "${old_pw_config}" ]] ; then
   migrate() {
     local line section=""
     while IFS= read -r line; do
-      line="$(pw::trim <<< "${line}")"
+      line="$(pw::trim "${line}")"
       [[ -z "${line}" ]] && echo >> "${mig_pw_config}" && continue
       [[ "${line}" == "#"* || "${line}" == ";"* ]] && echo "${line}" >> "${mig_pw_config}" && continue
 

src/pw

@@ -51,8 +51,7 @@ EOF
 }
 
 pw::trim() {
-  local line
-  IFS= read -r line || line=""
+  local line="$1"
   line="${line#"${line%%[![:space:]]*}"}"
   line="${line%"${line##*[![:space:]]}"}"
   printf '%s' "${line}"
@@ -85,7 +84,7 @@ pw::parse_config() {
 
   local line section key value
   while IFS= read -r line; do
-    line="$(pw::trim <<< "${line}")"
+    line="$(pw::trim "${line}")"
     [[ -z ${line} ]] && continue
     [[ "${line}" == "#"* || "${line}" == ";"* ]] && continue
     # shellcheck disable=SC2016
@@ -95,8 +94,8 @@ pw::parse_config() {
       "[keychains]") section="keychains"               ;;
       \[*\])         section="plugin-${line//[\[\]]/}" ;;
       *)
-        key="$(pw::trim <<< "${line%%=*}")"
-        value="$(pw::trim <<< "${line#*=}")"
+        key="$(pw::trim "${line%%=*}")"
+        value="$(pw::trim "${line#*=}")"
         [[ -z ${value} ]] && continue
         if [[ "${section}" == plugin-* ]]; then
           section="${section#plugin-}"