Avoid looking up entry in channel requests twice.

drieseng · drieseng · commit 17fb74315336 · 2016-06-23T21:46:36.000+02:00
diff --git a/src/Renci.SshNet/Channels/Channel.cs b/src/Renci.SshNet/Channels/Channel.cs
@@ -720,11 +720,10 @@ private void OnChannelRequest(object sender, MessageEventArgs<ChannelRequestMess
             {
                 try
                 {
-                    if (_session.ConnectionInfo.ChannelRequests.ContainsKey(e.Message.RequestName))
-                    {
-                        //  Get request specific class
-                        var requestInfo = _session.ConnectionInfo.ChannelRequests[e.Message.RequestName];
+                    RequestInfo requestInfo;
 
+                    if (_session.ConnectionInfo.ChannelRequests.TryGetValue(e.Message.RequestName, out requestInfo))
+                    {
                         //  Load request specific data
                         requestInfo.Load(e.Message.RequestData);
 

Original file line number	Diff line number	Diff line change
`@@ -720,11 +720,10 @@ private void OnChannelRequest(object sender, MessageEventArgs<ChannelRequestMess`
`720`	`720`	`{`
`721`	`721`	`try`
`722`	`722`	`{`
`723`		`- if (_session.ConnectionInfo.ChannelRequests.ContainsKey(e.Message.RequestName))`
`724`		`- {`
`725`		`- // Get request specific class`
`726`		`- var requestInfo = _session.ConnectionInfo.ChannelRequests[e.Message.RequestName];`
	`723`	`+ RequestInfo requestInfo;`
`727`	`724`
	`725`	`+ if (_session.ConnectionInfo.ChannelRequests.TryGetValue(e.Message.RequestName, out requestInfo))`
	`726`	`+ {`
`728`	`727`	`// Load request specific data`
`729`	`728`	`requestInfo.Load(e.Message.RequestData);`
`730`	`729`