Modify tests to take into account fact that we no longer explicitly disconnect the SftpSession, but instead immediately dispose it.

Author: drieseng

src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Connected.cs

@@ -48,7 +48,6 @@ protected void Arrange()
                 .Returns(_sftpSessionMock.Object);
             _sftpSessionMock.InSequence(sequence).Setup(p => p.Connect());
             _sessionMock.InSequence(sequence).Setup(p => p.OnDisconnecting());
-            _sftpSessionMock.InSequence(sequence).Setup(p => p.Disconnect());
             _sftpSessionMock.InSequence(sequence).Setup(p => p.Dispose());
             _sessionMock.InSequence(sequence).Setup(p => p.Disconnect());
             _sessionMock.InSequence(sequence).Setup(p => p.Dispose());
@@ -76,9 +75,9 @@ public void CreateSessionOnServiceFactoryShouldBeInvokedOnce()
         }
 
         [TestMethod]
-        public void DisconnectOnNetConfSessionShouldBeInvokedOnce()
+        public void DisconnectOnNetConfSessionShouldNeverBeInvoked()
         {
-            _sftpSessionMock.Verify(p => p.Disconnect(), Times.Once);
+            _sftpSessionMock.Verify(p => p.Disconnect(), Times.Never);
         }
 
         [TestMethod]

src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Disconnected.cs

@@ -48,7 +48,6 @@ protected void Arrange()
                 .Returns(_sftpSessionMock.Object);
             _sftpSessionMock.InSequence(sequence).Setup(p => p.Connect());
             _sessionMock.InSequence(sequence).Setup(p => p.OnDisconnecting());
-            _sftpSessionMock.InSequence(sequence).Setup(p => p.Disconnect());
             _sftpSessionMock.InSequence(sequence).Setup(p => p.Dispose());
             _sessionMock.InSequence(sequence).Setup(p => p.Disconnect());
             _sessionMock.InSequence(sequence).Setup(p => p.Dispose());
@@ -77,9 +76,9 @@ public void CreateSessionOnServiceFactoryShouldBeInvokedOnce()
         }
 
         [TestMethod]
-        public void DisconnectOnNetConfSessionShouldBeInvokedOnce()
+        public void DisconnectOnNetConfSessionShouldNeverBeInvoked()
         {
-            _sftpSessionMock.Verify(p => p.Disconnect(), Times.Once);
+            _sftpSessionMock.Verify(p => p.Disconnect(), Times.Never);
         }
 
         [TestMethod]

src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Disposed.cs

@@ -48,7 +48,6 @@ protected void Arrange()
                 .Returns(_sftpSessionMock.Object);
             _sftpSessionMock.InSequence(sequence).Setup(p => p.Connect());
             _sessionMock.InSequence(sequence).Setup(p => p.OnDisconnecting());
-            _sftpSessionMock.InSequence(sequence).Setup(p => p.Disconnect());
             _sftpSessionMock.InSequence(sequence).Setup(p => p.Dispose());
             _sessionMock.InSequence(sequence).Setup(p => p.Disconnect());
             _sessionMock.InSequence(sequence).Setup(p => p.Dispose());
@@ -77,9 +76,9 @@ public void CreateSessionOnServiceFactoryShouldBeInvokedOnce()
         }
 
         [TestMethod]
-        public void DisconnectOnNetConfSessionShouldBeInvokedOnce()
+        public void DisconnectOnNetConfSessionShouldNeverBeInvoked()
         {
-            _sftpSessionMock.Verify(p => p.Disconnect(), Times.Once);
+            _sftpSessionMock.Verify(p => p.Disconnect(), Times.Never);
         }
 
         [TestMethod]