disable CA1508

Author: mus65

.editorconfig

@@ -683,6 +683,10 @@ dotnet_diagnostic.CA1305.severity = none
 # https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1309
 dotnet_diagnostic.CA1309.severity = none
 
+# CA1508: Avoid dead conditional code
+# Too many false positives.
+dotnet_diagnostic.CA1508.severity = none
+
 # CA1510: Use ArgumentNullException throw helper
 #
 # This is only available in .NET 6.0 and higher. We'd need to use conditional compilation to only

src/Renci.SshNet/Channels/ChannelDirectTcpip.cs

@@ -124,12 +124,10 @@ private void CloseSocket()
 
             lock (_socketLock)
             {
-#pragma warning disable CA1508 // Avoid dead conditional code
                 if (_socket is null)
                 {
                     return;
                 }
-#pragma warning restore CA1508 // Avoid dead conditional code
 
                 // closing a socket actually disposes the socket, so we can safely dereference
                 // the field to avoid entering the lock again later
@@ -295,13 +293,11 @@ protected override void Dispose(bool disposing)
                     lock (_socketLock)
                     {
                         var socket = _socket;
-#pragma warning disable CA1508 // Avoid dead conditional code
                         if (socket != null)
                         {
                             _socket = null;
                             socket.Dispose();
                         }
-#pragma warning restore CA1508 // Avoid dead conditional code
                     }
                 }
 

src/Renci.SshNet/Channels/ChannelForwardedTcpip.cs

@@ -164,13 +164,11 @@ private void CloseSocket()
             lock (_socketShutdownAndCloseLock)
             {
                 var socket = _socket;
-#pragma warning disable CA1508 // Avoid dead conditional code
                 if (socket != null)
                 {
                     _socket = null;
                     socket.Dispose();
                 }
-#pragma warning restore CA1508 // Avoid dead conditional code
             }
         }
 

src/Renci.SshNet/Session.cs

@@ -1964,9 +1964,7 @@ private void SocketDisconnectAndDispose()
 
                 try
                 {
-#pragma warning disable CA1508 // Avoid dead conditional code; Value could have been changed by another thread.
                     if (_socket != null)
-#pragma warning restore CA1508 // Avoid dead conditional code
                     {
                         if (_socket.Connected)
                         {

src/Renci.SshNet/Sftp/SftpFileStream.cs

@@ -1067,7 +1067,6 @@ protected override void Dispose(bool disposing)
                 {
                     lock (_lock)
                     {
-#pragma warning disable CA1508 // Avoid dead conditional code
                         if (_session != null)
                         {
                             _canRead = false;
@@ -1091,7 +1090,6 @@ protected override void Dispose(bool disposing)
 
                             _session = null;
                         }
-#pragma warning restore CA1508 // Avoid dead conditional code
                     }
                 }
             }