Skip to content

Commit 77e7bc8

Browse files
committed
Do not catching exceptions while clearing read buffer of socket.
Leave this up to the caller.
1 parent c274f1f commit 77e7bc8

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

src/Renci.SshNet/Abstractions/SocketAbstraction.cs

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -81,20 +81,15 @@ public static Socket Connect(IPEndPoint remoteEndpoint, TimeSpan connectTimeout)
8181

8282
public static void ClearReadBuffer(Socket socket)
8383
{
84-
try
85-
{
86-
var buffer = new byte[256];
87-
int bytesReceived;
84+
var timeout = TimeSpan.FromMilliseconds(10);
85+
var buffer = new byte[256];
86+
int bytesReceived;
8887

89-
do
90-
{
91-
bytesReceived = ReadPartial(socket, buffer, 0, buffer.Length, TimeSpan.FromMilliseconds(10));
92-
} while (bytesReceived > 0);
93-
}
94-
catch
88+
do
9589
{
96-
// ignore any exceptions
90+
bytesReceived = ReadPartial(socket, buffer, 0, buffer.Length, timeout);
9791
}
92+
while (bytesReceived > 0);
9893
}
9994

10095
public static int ReadPartial(Socket socket, byte[] buffer, int offset, int size, TimeSpan timeout)

0 commit comments

Comments
 (0)