seal types not publicly instantiable (ma0053)

Rob-Hague · Rob-Hague · commit 7e6787568d48 · 2025-07-12T14:48:56.000+02:00
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -9,20 +9,18 @@
     <PackageVersion Include="coverlet.collector" Version="6.0.4" />
     <PackageVersion Include="coverlet.msbuild" Version="6.0.4" />
     <PackageVersion Include="GitHubActionsTestLogger" Version="2.4.1" />
-    <PackageVersion Include="Meziantou.Analyzer" Version="2.0.203" />
-    
+    <PackageVersion Include="Meziantou.Analyzer" Version="2.0.205" />
     <!-- Should stay on LTS .NET releases. -->
-    <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.6" />
-    <PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="9.0.6" />
-    <PackageVersion Include="MSTest" Version="3.9.1" />
+    <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.3" />
+    <PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="9.0.7" />
+    <PackageVersion Include="MSTest" Version="3.9.3" />
     <PackageVersion Include="Moq" Version="4.20.72" />
     <PackageVersion Include="Nerdbank.GitVersioning" Version="3.7.115" />
     <PackageVersion Include="PolySharp" Version="1.15.0" />
-    <PackageVersion Include="SonarAnalyzer.CSharp" Version="10.12.0.118525" />
+    <PackageVersion Include="SonarAnalyzer.CSharp" Version="10.13.0.120203" />
     <PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" />
-    
     <!-- Should stay on LTS .NET releases. -->
     <PackageVersion Include="System.Formats.Asn1" Version="8.0.2" />
-    <PackageVersion Include="Testcontainers" Version="4.5.0" />
+    <PackageVersion Include="Testcontainers" Version="4.6.0" />
   </ItemGroup>
-</Project>
+</Project>
diff --git a/src/Renci.SshNet/Common/PortForwardEventArgs.cs b/src/Renci.SshNet/Common/PortForwardEventArgs.cs
@@ -6,7 +6,7 @@ namespace Renci.SshNet.Common
     /// <summary>
     /// Provides data for <see cref="ForwardedPort.RequestReceived"/> event.
     /// </summary>
-    public class PortForwardEventArgs : EventArgs
+    public sealed class PortForwardEventArgs : EventArgs
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="PortForwardEventArgs"/> class.
diff --git a/src/Renci.SshNet/Session.cs b/src/Renci.SshNet/Session.cs
@@ -30,7 +30,7 @@ namespace Renci.SshNet
     /// <summary>
     /// Provides functionality to connect and interact with SSH server.
     /// </summary>
-    public class Session : ISession
+    public sealed class Session : ISession
     {
         internal const byte CarriageReturn = 0x0d;
         internal const byte LineFeed = 0x0a;
@@ -2185,7 +2185,7 @@ public void Dispose()
         /// Releases unmanaged and - optionally - managed resources.
         /// </summary>
         /// <param name="disposing"><see langword="true"/> to release both managed and unmanaged resources; <see langword="false"/> to release only unmanaged resources.</param>
-        protected virtual void Dispose(bool disposing)
+        private void Dispose(bool disposing)
         {
             if (_disposed)
             {
diff --git a/src/Renci.SshNet/Sftp/SftpFileAttributes.cs b/src/Renci.SshNet/Sftp/SftpFileAttributes.cs
@@ -10,7 +10,7 @@ namespace Renci.SshNet.Sftp
     /// <summary>
     /// Contains SFTP file attributes.
     /// </summary>
-    public class SftpFileAttributes
+    public sealed class SftpFileAttributes
     {
 #pragma warning disable IDE1006 // Naming Styles
 #pragma warning disable SA1310 // Field names should not contain underscore
diff --git a/src/Renci.SshNet/Sftp/SftpFileStream.cs b/src/Renci.SshNet/Sftp/SftpFileStream.cs
@@ -16,7 +16,7 @@ namespace Renci.SshNet.Sftp
 #pragma warning disable IDE0079 // We intentionally want to suppress the below warning.
     [SuppressMessage("Performance", "CA1844: Provide memory-based overrides of async methods when subclassing 'Stream'", Justification = "TODO: This should be addressed in the future.")]
 #pragma warning restore IDE0079
-    public class SftpFileStream : Stream
+    public sealed class SftpFileStream : Stream
     {
         private readonly Lock _lock = new Lock();
         private readonly int _readBufferSize;
@@ -162,7 +162,7 @@ public override long Position
         /// <value>
         /// The operating system file handle for the file that the current <see cref="SftpFileStream"/> encapsulates.
         /// </value>
-        public virtual byte[] Handle
+        public byte[] Handle
         {
             get
             {
diff --git a/src/Renci.SshNet/Sftp/SftpFileSystemInformation.cs b/src/Renci.SshNet/Sftp/SftpFileSystemInformation.cs
@@ -3,11 +3,9 @@
 namespace Renci.SshNet.Sftp
 {
     /// <summary>
-    /// Contains File system information exposed by statvfs@openssh.com request.
+    /// Contains file system information exposed by statvfs@openssh.com request.
     /// </summary>
-#pragma warning disable SA1649 // File name should match first type name
-    public class SftpFileSystemInformation
-#pragma warning restore SA1649 // File name should match first type name
+    public sealed class SftpFileSystemInformation
     {
 #pragma warning disable SA1310 // Field names should not contain underscore
         internal const ulong SSH_FXE_STATVFS_ST_RDONLY = 0x1;
diff --git a/src/Renci.SshNet/Shell.cs b/src/Renci.SshNet/Shell.cs
@@ -12,7 +12,7 @@ namespace Renci.SshNet
     /// <summary>
     /// Represents instance of the SSH shell object.
     /// </summary>
-    public class Shell : IDisposable
+    public sealed class Shell : IDisposable
     {
         private const int DefaultBufferSize = 1024;
 
@@ -315,7 +315,7 @@ public void Dispose()
         /// Releases unmanaged and - optionally - managed resources.
         /// </summary>
         /// <param name="disposing"><see langword="true"/> to release both managed and unmanaged resources; <see langword="false"/> to release only unmanaged resources.</param>
-        protected virtual void Dispose(bool disposing)
+        private void Dispose(bool disposing)
         {
             if (_disposed)
             {
diff --git a/src/Renci.SshNet/ShellStream.cs b/src/Renci.SshNet/ShellStream.cs
@@ -17,7 +17,7 @@ namespace Renci.SshNet
     /// <summary>
     /// Contains operation for working with SSH Shell.
     /// </summary>
-    public class ShellStream : Stream
+    public sealed class ShellStream : Stream
     {
         private const int DefaultBufferSize = 1024;
 
diff --git a/src/Renci.SshNet/SshCommand.cs b/src/Renci.SshNet/SshCommand.cs
@@ -16,7 +16,7 @@ namespace Renci.SshNet
     /// <summary>
     /// Represents an SSH command that can be executed.
     /// </summary>
-    public class SshCommand : IDisposable
+    public sealed class SshCommand : IDisposable
     {
         private readonly ISession _session;
         private readonly Encoding _encoding;
@@ -630,7 +630,7 @@ public void Dispose()
         /// Releases unmanaged and - optionally - managed resources.
         /// </summary>
         /// <param name="disposing"><see langword="true"/> to release both managed and unmanaged resources; <see langword="false"/> to release only unmanaged resources.</param>
-        protected virtual void Dispose(bool disposing)
+        private void Dispose(bool disposing)
         {
             if (_isDisposed)
             {

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace Renci.SshNet.Common`
`6`	`6`	`/// <summary>`
`7`	`7`	`/// Provides data for <see cref="ForwardedPort.RequestReceived"/> event.`
`8`	`8`	`/// </summary>`
`9`		`- public class PortForwardEventArgs : EventArgs`
	`9`	`+ public sealed class PortForwardEventArgs : EventArgs`
`10`	`10`	`{`
`11`	`11`	`/// <summary>`
`12`	`12`	`/// Initializes a new instance of the <see cref="PortForwardEventArgs"/> class.`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ namespace Renci.SshNet`
`30`	`30`	`/// <summary>`
`31`	`31`	`/// Provides functionality to connect and interact with SSH server.`
`32`	`32`	`/// </summary>`
`33`		`- public class Session : ISession`
	`33`	`+ public sealed class Session : ISession`
`34`	`34`	`{`
`35`	`35`	`internal const byte CarriageReturn = 0x0d;`
`36`	`36`	`internal const byte LineFeed = 0x0a;`
`@@ -2185,7 +2185,7 @@ public void Dispose()`
`2185`	`2185`	`/// Releases unmanaged and - optionally - managed resources.`
`2186`	`2186`	`/// </summary>`
`2187`	`2187`	`/// <param name="disposing"><see langword="true"/> to release both managed and unmanaged resources; <see langword="false"/> to release only unmanaged resources.</param>`
`2188`		`- protected virtual void Dispose(bool disposing)`
	`2188`	`+ private void Dispose(bool disposing)`
`2189`	`2189`	`{`
`2190`	`2190`	`if (_disposed)`
`2191`	`2191`	`{`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace Renci.SshNet.Sftp`
`10`	`10`	`/// <summary>`
`11`	`11`	`/// Contains SFTP file attributes.`
`12`	`12`	`/// </summary>`
`13`		`- public class SftpFileAttributes`
	`13`	`+ public sealed class SftpFileAttributes`
`14`	`14`	`{`
`15`	`15`	`#pragma warning disable IDE1006 // Naming Styles`
`16`	`16`	`#pragma warning disable SA1310 // Field names should not contain underscore`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ namespace Renci.SshNet.Sftp`
`16`	`16`	`#pragma warning disable IDE0079 // We intentionally want to suppress the below warning.`
`17`	`17`	`[SuppressMessage("Performance", "CA1844: Provide memory-based overrides of async methods when subclassing 'Stream'", Justification = "TODO: This should be addressed in the future.")]`
`18`	`18`	`#pragma warning restore IDE0079`
`19`		`- public class SftpFileStream : Stream`
	`19`	`+ public sealed class SftpFileStream : Stream`
`20`	`20`	`{`
`21`	`21`	`private readonly Lock _lock = new Lock();`
`22`	`22`	`private readonly int _readBufferSize;`
`@@ -162,7 +162,7 @@ public override long Position`
`162`	`162`	`/// <value>`
`163`	`163`	`/// The operating system file handle for the file that the current <see cref="SftpFileStream"/> encapsulates.`
`164`	`164`	`/// </value>`
`165`		`- public virtual byte[] Handle`
	`165`	`+ public byte[] Handle`
`166`	`166`	`{`
`167`	`167`	`get`
`168`	`168`	`{`
Original file line number	Diff line number	Diff line change
`@@ -3,11 +3,9 @@`
`3`	`3`	`namespace Renci.SshNet.Sftp`
`4`	`4`	`{`
`5`	`5`	`/// <summary>`
`6`		`- /// Contains File system information exposed by [email protected] request.`
	`6`	`+ /// Contains file system information exposed by [email protected] request.`
`7`	`7`	`/// </summary>`
`8`		`-#pragma warning disable SA1649 // File name should match first type name`
`9`		`- public class SftpFileSystemInformation`
`10`		`-#pragma warning restore SA1649 // File name should match first type name`
	`8`	`+ public sealed class SftpFileSystemInformation`
`11`	`9`	`{`
`12`	`10`	`#pragma warning disable SA1310 // Field names should not contain underscore`
`13`	`11`	`internal const ulong SSH_FXE_STATVFS_ST_RDONLY = 0x1;`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ namespace Renci.SshNet`
`12`	`12`	`/// <summary>`
`13`	`13`	`/// Represents instance of the SSH shell object.`
`14`	`14`	`/// </summary>`
`15`		`- public class Shell : IDisposable`
	`15`	`+ public sealed class Shell : IDisposable`
`16`	`16`	`{`
`17`	`17`	`private const int DefaultBufferSize = 1024;`
`18`	`18`
`@@ -315,7 +315,7 @@ public void Dispose()`
`315`	`315`	`/// Releases unmanaged and - optionally - managed resources.`
`316`	`316`	`/// </summary>`
`317`	`317`	`/// <param name="disposing"><see langword="true"/> to release both managed and unmanaged resources; <see langword="false"/> to release only unmanaged resources.</param>`
`318`		`- protected virtual void Dispose(bool disposing)`
	`318`	`+ private void Dispose(bool disposing)`
`319`	`319`	`{`
`320`	`320`	`if (_disposed)`
`321`	`321`	`{`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ namespace Renci.SshNet`
`17`	`17`	`/// <summary>`
`18`	`18`	`/// Contains operation for working with SSH Shell.`
`19`	`19`	`/// </summary>`
`20`		`- public class ShellStream : Stream`
	`20`	`+ public sealed class ShellStream : Stream`
`21`	`21`	`{`
`22`	`22`	`private const int DefaultBufferSize = 1024;`
`23`	`23`