Check CanSeek in ReadAllBytes

Author: Rob-Hague

src/Renci.SshNet/Sftp/SftpFileStream.cs

@@ -55,7 +55,7 @@ public override bool CanWrite
         /// Gets a value indicating whether timeout properties are usable for <see cref="SftpFileStream"/>.
         /// </summary>
         /// <value>
-        /// <see langword="true"/> in all cases.
+        /// <see langword="false"/> in all cases.
         /// </value>
         public override bool CanTimeout
         {

src/Renci.SshNet/SftpClient.cs

@@ -1714,8 +1714,20 @@ public byte[] ReadAllBytes(string path)
         {
             using (var stream = OpenRead(path))
             {
-                var buffer = new byte[stream.Length];
-                stream.ReadExactly(buffer, 0, buffer.Length);
+                byte[] buffer;
+
+                if (stream.CanSeek)
+                {
+                    buffer = new byte[stream.Length];
+                    stream.ReadExactly(buffer, 0, buffer.Length);
+                }
+                else
+                {
+                    MemoryStream ms = new();
+                    stream.CopyTo(ms);
+                    buffer = ms.ToArray();
+                }
+
                 return buffer;
             }
         }

test/Renci.SshNet.IntegrationTests/SftpTests.cs

@@ -6360,7 +6360,7 @@ private void DownloadFileRandomMethod(SftpClient client, string path, Stream out
         {
             Console.Write($"Downloading '{path}'");
 
-            var random = new Random().Next(1, 6);
+            var random = new Random().Next(1, 7);
             switch (random)
             {
                 case 1:
@@ -6390,15 +6390,23 @@ private void DownloadFileRandomMethod(SftpClient client, string path, Stream out
                     }
 
                     break;
-                default:
-                    Debug.Assert(random == 5);
+                case 5:
                     Console.WriteLine($" with {nameof(SftpFileStream.CopyToAsync)}");
 
                     using (var fs = client.OpenAsync(path, FileMode.Open, FileAccess.Read, CancellationToken.None).GetAwaiter().GetResult())
                     {
                         fs.CopyToAsync(output).GetAwaiter().GetResult();
                     }
 
+                    break;
+                default:
+                    Debug.Assert(random == 6);
+                    Console.WriteLine($" with {nameof(SftpClient.ReadAllBytes)}");
+
+                    byte[] bytes = client.ReadAllBytes(path);
+
+                    output.Write(bytes, 0, bytes.Length);
+
                     break;
             }
         }