Remove unnecessary finalizers (#1209)

All of the finalizers in the library are no-ops, but their existence means that
when Dispose (and thus GC.SuppressFinalize) is not called, the objects' lifetimes
are extended unnecessarily while they are waiting to be finalized.

Co-authored-by: Wojciech Nagórski <[email protected]>

Author: Rob-Hague

src/Renci.SshNet/BaseClient.cs

@@ -461,14 +461,6 @@ protected void CheckDisposed()
 #endif // NET7_0_OR_GREATER
         }
 
-        /// <summary>
-        /// Finalizes an instance of the <see cref="BaseClient"/> class.
-        /// </summary>
-        ~BaseClient()
-        {
-            Dispose(disposing: false);
-        }
-
         /// <summary>
         /// Stops the keep-alive timer, and waits until all timer callbacks have been
         /// executed.

src/Renci.SshNet/Channels/Channel.cs

@@ -868,13 +868,5 @@ protected virtual void Dispose(bool disposing)
                 _isDisposed = true;
             }
         }
-
-        /// <summary>
-        /// Finalizes an instance of the <see cref="Channel"/> class.
-        /// </summary>
-        ~Channel()
-        {
-            Dispose(disposing: false);
-        }
     }
 }

src/Renci.SshNet/Compression/Compressor.cs

@@ -175,14 +175,5 @@ protected virtual void Dispose(bool disposing)
                 _isDisposed = true;
             }
         }
-
-        /// <summary>
-        /// Releases unmanaged resources and performs other cleanup operations before the <see cref="Compressor"/> is reclaimed
-        /// by garbage collection.
-        /// </summary>
-        ~Compressor()
-        {
-            Dispose(disposing: false);
-        }
     }
 }

src/Renci.SshNet/ForwardedPortRemote.cs

@@ -379,13 +379,5 @@ protected override void Dispose(bool disposing)
 
             _isDisposed = true;
         }
-
-        /// <summary>
-        /// Finalizes an instance of the <see cref="ForwardedPortRemote"/> class.
-        /// </summary>
-        ~ForwardedPortRemote()
-        {
-            Dispose(disposing: false);
-        }
     }
 }

src/Renci.SshNet/KeyboardInteractiveAuthenticationMethod.cs

@@ -183,13 +183,5 @@ protected virtual void Dispose(bool disposing)
                 _isDisposed = true;
             }
         }
-
-        /// <summary>
-        /// Finalizes an instance of the <see cref="KeyboardInteractiveAuthenticationMethod"/> class.
-        /// </summary>
-        ~KeyboardInteractiveAuthenticationMethod()
-        {
-            Dispose(disposing: false);
-        }
     }
 }

src/Renci.SshNet/KeyboardInteractiveConnectionInfo.cs

@@ -174,13 +174,5 @@ protected virtual void Dispose(bool disposing)
                 _isDisposed = true;
             }
         }
-
-        /// <summary>
-        /// Finalizes an instance of the <see cref="KeyboardInteractiveConnectionInfo"/> class.
-        /// </summary>
-        ~KeyboardInteractiveConnectionInfo()
-        {
-            Dispose(disposing: false);
-        }
     }
 }

src/Renci.SshNet/NoneAuthenticationMethod.cs

@@ -121,13 +121,5 @@ protected virtual void Dispose(bool disposing)
                 _isDisposed = true;
             }
         }
-
-        /// <summary>
-        /// Finalizes an instance of the <see cref="NoneAuthenticationMethod"/> class.
-        /// </summary>
-        ~NoneAuthenticationMethod()
-        {
-            Dispose(disposing: false);
-        }
     }
 }

src/Renci.SshNet/PasswordAuthenticationMethod.cs

@@ -201,13 +201,5 @@ protected virtual void Dispose(bool disposing)
                 _isDisposed = true;
             }
         }
-
-        /// <summary>
-        /// Finalizes an instance of the <see cref="PasswordAuthenticationMethod"/> class.
-        /// </summary>
-        ~PasswordAuthenticationMethod()
-        {
-            Dispose(disposing: false);
-        }
     }
 }

src/Renci.SshNet/PasswordConnectionInfo.cs

@@ -291,13 +291,5 @@ protected virtual void Dispose(bool disposing)
                 _isDisposed = true;
             }
         }
-
-        /// <summary>
-        /// Finalizes an instance of the <see cref="PasswordConnectionInfo"/> class.
-        /// </summary>
-        ~PasswordConnectionInfo()
-        {
-            Dispose(disposing: false);
-        }
     }
 }

src/Renci.SshNet/PrivateKeyAuthenticationMethod.cs

@@ -191,14 +191,6 @@ protected virtual void Dispose(bool disposing)
             }
         }
 
-        /// <summary>
-        /// Finalizes an instance of the <see cref="PrivateKeyAuthenticationMethod"/> class.
-        /// </summary>
-        ~PrivateKeyAuthenticationMethod()
-        {
-            Dispose(disposing: false);
-        }
-
         private sealed class SignatureData : SshData
         {
             private readonly RequestMessagePublicKey _message;