A couple of changes/fixes in SshCommand (#1423)

* Send "signal" and set the wait handle on completion always

* Make ExitStatus nullable

Author: Rob-Hague

.editorconfig

@@ -688,7 +688,7 @@ dotnet_diagnostic.CA1852.severity = none
 # CA1859: Change return type for improved performance
 #
 # By default, this diagnostic is only reported for private members.
-dotnet_code_quality.CA1859.api_surface = all
+dotnet_code_quality.CA1859.api_surface = private,internal
 
 # CA2208: Instantiate argument exceptions correctly
 # https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2208

src/Renci.SshNet/Channels/ChannelSession.cs

@@ -274,35 +274,6 @@ public bool SendSignalRequest(string signalName)
             return true;
         }
 
-        /// <summary>
-        /// Sends the exit status request.
-        /// </summary>
-        /// <param name="exitStatus">The exit status.</param>
-        /// <returns>
-        /// <see langword="true"/> if request was successful; otherwise <see langword="false"/>.
-        /// </returns>
-        public bool SendExitStatusRequest(uint exitStatus)
-        {
-            SendMessage(new ChannelRequestMessage(RemoteChannelNumber, new ExitStatusRequestInfo(exitStatus)));
-            return true;
-        }
-
-        /// <summary>
-        /// Sends the exit signal request.
-        /// </summary>
-        /// <param name="signalName">Name of the signal.</param>
-        /// <param name="coreDumped">if set to <see langword="true"/> [core dumped].</param>
-        /// <param name="errorMessage">The error message.</param>
-        /// <param name="language">The language.</param>
-        /// <returns>
-        /// <see langword="true"/> if request was successful; otherwise <see langword="false"/>.
-        /// </returns>
-        public bool SendExitSignalRequest(string signalName, bool coreDumped, string errorMessage, string language)
-        {
-            SendMessage(new ChannelRequestMessage(RemoteChannelNumber, new ExitSignalRequestInfo(signalName, coreDumped, errorMessage, language)));
-            return true;
-        }
-
         /// <summary>
         /// Sends [email protected] request.
         /// </summary>

src/Renci.SshNet/Channels/IChannelSession.cs

@@ -120,27 +120,6 @@ bool SendPseudoTerminalRequest(string environmentVariable,
         /// </returns>
         bool SendSignalRequest(string signalName);
 
-        /// <summary>
-        /// Sends the exit status request.
-        /// </summary>
-        /// <param name="exitStatus">The exit status.</param>
-        /// <returns>
-        /// <see langword="true"/> if request was successful; otherwise <see langword="false"/>.
-        /// </returns>
-        bool SendExitStatusRequest(uint exitStatus);
-
-        /// <summary>
-        /// Sends the exit signal request.
-        /// </summary>
-        /// <param name="signalName">Name of the signal.</param>
-        /// <param name="coreDumped">if set to <see langword="true"/> [core dumped].</param>
-        /// <param name="errorMessage">The error message.</param>
-        /// <param name="language">The language.</param>
-        /// <returns>
-        /// <see langword="true"/> if request was successful; otherwise <see langword="false"/>.
-        /// </returns>
-        bool SendExitSignalRequest(string signalName, bool coreDumped, string errorMessage, string language);
-
         /// <summary>
         /// Sends [email protected] request.
         /// </summary>

src/Renci.SshNet/CommandAsyncResult.cs

@@ -56,15 +56,5 @@ internal CommandAsyncResult()
         /// true if the operation is complete; otherwise, false.
         /// </returns>
         public bool IsCompleted { get; internal set; }
-
-        /// <summary>
-        /// Gets or sets a value indicating whether <see cref="SshCommand.EndExecute(IAsyncResult)"/> was already called for this
-        /// <see cref="CommandAsyncResult"/>.
-        /// </summary>
-        /// <returns>
-        /// <see langword="true"/> if <see cref="SshCommand.EndExecute(IAsyncResult)"/> was already called for this <see cref="CommandAsyncResult"/>;
-        /// otherwise, <see langword="false"/>.
-        /// </returns>
-        internal bool EndCalled { get; set; }
     }
 }

src/Renci.SshNet/SshClient.cs

@@ -235,7 +235,7 @@ public SshCommand CreateCommand(string commandText, Encoding encoding)
             EnsureSessionIsOpen();
 
             ConnectionInfo.Encoding = encoding;
-            return new SshCommand(Session, commandText, encoding);
+            return new SshCommand(Session!, commandText, encoding);
         }
 
         /// <summary>