Remove Encoding from SubsystemSession and NetConfSession, and move it to SftpSession (as it is only used there).

Refactor creation of SFTP response messages to a SftpResponseFactory.
Implement SaveData for a few SFTP response messages.

Author: drieseng

src/Renci.SshNet.NETCore/Renci.SshNet.NETCore.csproj

@@ -97,6 +97,10 @@
       <Version>4.0.1</Version>
     </PackageReference>
   </ItemGroup>
+  <ItemGroup>
+    <Compile Update="..\Renci.SshNet\Sftp\ISftpMessageFactory.cs" Link="Sftp\ISftpResponseFactory.cs" />
+    <Compile Update="..\Renci.SshNet\Sftp\SftpMessageFactory.cs" Link="Sftp\SftpResponseFactory.cs" />
+  </ItemGroup>
   <PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' ">
     <DefineConstants>TRACE;DEBUG;FEATURE_ENCODING_ASCII;FEATURE_DIAGNOSTICS_TRACESOURCE;FEATURE_DIRECTORYINFO_ENUMERATEFILES;FEATURE_MEMORYSTREAM_TRYGETBUFFER;FEATURE_REFLECTION_TYPEINFO;FEATURE_RNG_CREATE;FEATURE_SOCKET_TAP;FEATURE_SOCKET_EAP;FEATURE_SOCKET_SYNC;FEATURE_SOCKET_SETSOCKETOPTION;FEATURE_SOCKET_SELECT;FEATURE_SOCKET_POLL;FEATURE_DNS_TAP;FEATURE_STREAM_TAP;FEATURE_THREAD_COUNTDOWNEVENT;FEATURE_THREAD_THREADPOOL;FEATURE_THREAD_SLEEP;FEATURE_HASH_MD5;FEATURE_HASH_SHA1_CREATE;FEATURE_HASH_SHA256_CREATE;FEATURE_HASH_SHA384_CREATE;FEATURE_HASH_SHA512_CREATE;FEATURE_HMAC_MD5;FEATURE_HMAC_SHA1;FEATURE_HMAC_SHA256;FEATURE_HMAC_SHA384;FEATURE_HMAC_SHA512</DefineConstants>
   </PropertyGroup>

src/Renci.SshNet.Tests/Classes/Sftp/SftpDataResponseBuilder.cs

@@ -0,0 +1,38 @@
+using Renci.SshNet.Sftp.Responses;
+
+namespace Renci.SshNet.Tests.Classes.Sftp
+{
+    internal class SftpDataResponseBuilder
+    {
+        private uint _protocolVersion;
+        private uint _responseId;
+        private byte[] _data;
+
+        public SftpDataResponseBuilder WithProtocolVersion(uint protocolVersion)
+        {
+            _protocolVersion = protocolVersion;
+            return this;
+        }
+
+        public SftpDataResponseBuilder WithResponseId(uint responseId)
+        {
+            _responseId = responseId;
+            return this;
+        }
+
+        public SftpDataResponseBuilder WithData(byte[] data)
+        {
+            _data = data;
+            return this;
+        }
+
+        public SftpDataResponse Build()
+        {
+            return new SftpDataResponse(_protocolVersion)
+                {
+                    ResponseId = _responseId,
+                    Data = _data
+                };
+        }
+    }
+}

src/Renci.SshNet.Tests/Classes/Sftp/SftpHandleResponseBuilder.cs

@@ -0,0 +1,42 @@
+using Renci.SshNet.Sftp;
+using Renci.SshNet.Sftp.Responses;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Renci.SshNet.Tests.Classes.Sftp
+{
+    internal class SftpHandleResponseBuilder
+    {
+        private uint _protocolVersion;
+        private uint _responseId;
+        private byte[] _handle;
+
+        public SftpHandleResponseBuilder WithProtocolVersion(uint protocolVersion)
+        {
+            _protocolVersion = protocolVersion;
+            return this;
+        }
+
+        public SftpHandleResponseBuilder WithResponseId(uint responseId)
+        {
+            _responseId = responseId;
+            return this;
+        }
+
+        public SftpHandleResponseBuilder WithHandle(byte[] handle)
+        {
+            _handle = handle;
+            return this;
+        }
+
+        public SftpHandleResponse Build()
+        {
+            var sftpHandleResponse = new SftpHandleResponse(_protocolVersion)
+            {
+                ResponseId = _responseId,
+                Handle = _handle
+            };
+            return sftpHandleResponse;
+        }
+    }
+}

src/Renci.SshNet.Tests/Classes/Sftp/SftpInitRequestBuilder.cs

@@ -0,0 +1,20 @@
+using Renci.SshNet.Sftp.Requests;
+
+namespace Renci.SshNet.Tests.Classes.Sftp
+{
+    internal class SftpInitRequestBuilder
+    {
+        private uint _version;
+
+        public SftpInitRequestBuilder WithVersion(uint version)
+        {
+            _version = version;
+            return this;
+        }
+
+        public SftpInitRequest Build()
+        {
+            return new SftpInitRequest(_version);
+        }
+    }
+}

src/Renci.SshNet.Tests/Classes/Sftp/SftpNameResponseBuilder.cs

@@ -0,0 +1,61 @@
+using Renci.SshNet.Sftp;
+using Renci.SshNet.Sftp.Responses;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Renci.SshNet.Tests.Classes.Sftp
+{
+    internal class SftpNameResponseBuilder
+    {
+        private uint _responseId;
+        private uint _protocolVersion;
+        private Encoding _encoding;
+        private List<KeyValuePair<string, SftpFileAttributes>> _files;
+
+        public SftpNameResponseBuilder()
+        {
+            _files = new List<KeyValuePair<string, SftpFileAttributes>>();
+        }
+
+        public SftpNameResponseBuilder WithProtocolVersion(uint protocolVersion)
+        {
+            _protocolVersion = protocolVersion;
+            return this;
+        }
+
+        public SftpNameResponseBuilder WithResponseId(uint responseId)
+        {
+            _responseId = responseId;
+            return this;
+        }
+
+        public SftpNameResponseBuilder WithFiles(params KeyValuePair<string, SftpFileAttributes>[] files)
+        {
+            for (var i = 0; i < files.Length; i++)
+                _files.Add(files[i]);
+            return this;
+        }
+
+        public SftpNameResponseBuilder WithFile(string filename, SftpFileAttributes attributes)
+        {
+            _files.Add(new KeyValuePair<string, SftpFileAttributes>(filename, attributes));
+            return this;
+        }
+
+        public SftpNameResponseBuilder WithEncoding(Encoding encoding)
+        {
+            _encoding = encoding;
+            return this;
+        }
+
+        public SftpNameResponse Build()
+        {
+            var sftpNameResponse = new SftpNameResponse(_protocolVersion, _encoding)
+                {
+                    ResponseId = _responseId,
+                    Files = _files.ToArray()
+                };
+            return sftpNameResponse;
+        }
+    }
+}

src/Renci.SshNet.Tests/Classes/Sftp/SftpOpenRequestBuilder.cs

@@ -0,0 +1,71 @@
+using Renci.SshNet.Sftp;
+using Renci.SshNet.Sftp.Requests;
+using Renci.SshNet.Sftp.Responses;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+
+namespace Renci.SshNet.Tests.Classes.Sftp
+{
+    internal class SftpOpenRequestBuilder
+    {
+        private uint _protocolVersion;
+        private uint _requestId;
+        private string _fileName;
+        private Encoding _encoding;
+        private Flags _flags;
+        private Action<SftpHandleResponse> _handleAction;
+        private Action<SftpStatusResponse> _statusAction;
+
+        public SftpOpenRequestBuilder WithProtocolVersion(uint protocolVersion)
+        {
+            _protocolVersion = protocolVersion;
+            return this;
+        }
+
+        public SftpOpenRequestBuilder WithRequestId(uint requestId)
+        {
+            _requestId = requestId;
+            return this;
+        }
+
+        public SftpOpenRequestBuilder WithFileName(string fileName)
+        {
+            _fileName = fileName;
+            return this;
+        }
+
+        public SftpOpenRequestBuilder WithEncoding(Encoding encoding)
+        {
+            _encoding = encoding;
+            return this;
+        }
+
+        public SftpOpenRequestBuilder WithFlags(Flags flags)
+        {
+            _flags = flags;
+            return this;
+        }
+
+        public SftpOpenRequestBuilder WithDataAction(Action<SftpHandleResponse> handleAction)
+        {
+            _handleAction = handleAction;
+            return this;
+        }
+
+        public SftpOpenRequestBuilder WithStatusAction(Action<SftpStatusResponse> statusAction)
+        {
+            _statusAction = statusAction;
+            return this;
+        }
+
+        public SftpOpenRequest Build()
+        {
+            var handleAction = _handleAction ?? ((handleResponse) => { });
+            var statusAction = _statusAction ?? ((statusResponse) => { });
+
+            return new SftpOpenRequest(_protocolVersion, _requestId, _fileName, _encoding, _flags, handleAction, statusAction);
+        }
+    }
+}

src/Renci.SshNet.Tests/Classes/Sftp/SftpReadRequestBuilder.cs

@@ -0,0 +1,67 @@
+using Renci.SshNet.Sftp.Requests;
+using Renci.SshNet.Sftp.Responses;
+using System;
+
+namespace Renci.SshNet.Tests.Classes.Sftp
+{
+    internal class SftpReadRequestBuilder
+    {
+        private uint _protocolVersion;
+        private uint _requestId;
+        private byte[] _handle;
+        private uint _offset;
+        private uint _length;
+        private Action<SftpDataResponse> _dataAction;
+        private Action<SftpStatusResponse> _statusAction;
+
+        public SftpReadRequestBuilder WithProtocolVersion(uint protocolVersion)
+        {
+            _protocolVersion = protocolVersion;
+            return this;
+        }
+
+        public SftpReadRequestBuilder WithRequestId(uint requestId)
+        {
+            _requestId = requestId;
+            return this;
+        }
+
+        public SftpReadRequestBuilder WithHandle(byte[] handle)
+        {
+            _handle = handle;
+            return this;
+        }
+
+        public SftpReadRequestBuilder WithOffset(uint offset)
+        {
+            _offset = offset;
+            return this;
+        }
+
+        public SftpReadRequestBuilder WithLength(uint length)
+        {
+            _length = length;
+            return this;
+        }
+
+        public SftpReadRequestBuilder WithDataAction(Action<SftpDataResponse> dataAction)
+        {
+            _dataAction = dataAction;
+            return this;
+        }
+
+        public SftpReadRequestBuilder WithStatusAction(Action<SftpStatusResponse> statusAction)
+        {
+            _statusAction = statusAction;
+            return this;
+        }
+
+        public SftpReadRequest Build()
+        {
+            var dataAction = _dataAction ?? ((dataResponse) => { });
+            var statusAction = _statusAction ?? ((statusResponse) => { });
+
+            return new SftpReadRequest(_protocolVersion, _requestId, _handle, _offset, _length, dataAction, statusAction);
+        }
+    }
+}

src/Renci.SshNet.Tests/Classes/Sftp/SftpRealPathRequestBuilder.cs

@@ -0,0 +1,61 @@
+using Renci.SshNet.Sftp.Requests;
+using Renci.SshNet.Sftp.Responses;
+using System;
+using System.Text;
+
+namespace Renci.SshNet.Tests.Classes.Sftp
+{
+    internal class SftpRealPathRequestBuilder
+    {
+        private uint _protocolVersion;
+        private uint _requestId;
+        private string _path;
+        private Encoding _encoding;
+        private Action<SftpNameResponse> _nameAction;
+        private Action<SftpStatusResponse> _statusAction;
+
+        public SftpRealPathRequestBuilder WithProtocolVersion(uint protocolVersion)
+        {
+            _protocolVersion = protocolVersion;
+            return this;
+        }
+
+        public SftpRealPathRequestBuilder WithRequestId(uint requestId)
+        {
+            _requestId = requestId;
+            return this;
+        }
+
+        public SftpRealPathRequestBuilder WithPath(string path)
+        {
+            _path = path;
+            return this;
+        }
+
+        public SftpRealPathRequestBuilder WithEncoding(Encoding encoding)
+        {
+            _encoding = encoding;
+            return this;
+        }
+
+        public SftpRealPathRequestBuilder WithNameAction(Action<SftpNameResponse> nameAction)
+        {
+            _nameAction = nameAction;
+            return this;
+        }
+
+        public SftpRealPathRequestBuilder WithStatusAction(Action<SftpStatusResponse> statusAction)
+        {
+            _statusAction = statusAction;
+            return this;
+        }
+
+        public SftpRealPathRequest Build()
+        {
+            var nameAction = _nameAction ?? ((nameResponse) => { });
+            var statusAction = _statusAction ?? ((statusResponse) => { });
+
+            return new SftpRealPathRequest(_protocolVersion, _requestId, _path, _encoding, nameAction, statusAction);
+        }
+    }
+}