fixed suggestion bar visibility issues

Author: sspanak

app/src/main/java/io/github/sspanak/tt9/db/mindReading/MindReader.java

@@ -88,6 +88,8 @@ public void guessNext(@NonNull InputMode inputMode, @NonNull Language language,
 
 		loadingId = 0;
 
+		// @todo: Thai no longer works
+		// @todo: Chinese no longer works
 		// @todo: this fails for ABC. Fix it!
 		if (setContextSync(inputMode, language, surroundingText, lastWord)) {
 			runInThread(() -> {
@@ -196,7 +198,7 @@ public void processContext(@Nullable InputMode inputMode, @NonNull Language lang
 
 
 	private String adjustWordTextCase(@NonNull String word) {
-		if (autoTextCase == null) {
+		if (autoTextCase == null || (wordContext.language != null && !wordContext.language.hasUpperCase())) {
 			return word;
 		}
 

app/src/main/java/io/github/sspanak/tt9/ime/TypingHandler.java

@@ -198,6 +198,8 @@ protected boolean onNumber(int key, boolean hold, int repeat) {
 		// First pass, analyze the incoming key press and decide whether it could be the start of
 		// a new word. In case we do accept it, we preserve the suggestion list instead of clearing,
 		// to prevent flashing while the next suggestions are being loaded.
+
+		// @todo: accept first-letter-completed on space
 		if (mInputMode.shouldAcceptPreviousSuggestion(suggestionOps.getCurrent(), key, hold)) {
 			// WARNING! Ensure the code after "acceptIncompleteAndKeepList()" does not depend on
 			// the suggestions in SuggestionOps, since we don't clear that list.

app/src/main/java/io/github/sspanak/tt9/ime/helpers/SuggestionOps.java

@@ -104,32 +104,32 @@ public void clear() {
 
 
 	public void addGuesses(@NonNull ArrayList<String> guesses) {
-		setVisibility(settings, guesses, true);
+		setVisibility(settings, isEmpty() && guesses.isEmpty(), true);
 		if (suggestionBar != null) {
 			suggestionBar.prependGuesses(guesses);
 		}
 	}
 
 
-	public void set(ArrayList<String> suggestions) {
+	public void set(@Nullable ArrayList<String> suggestions) {
 		set(suggestions, 0, false);
 	}
 
 
-	public void set(ArrayList<String> suggestions, boolean containsGenerated) {
+	public void set(@Nullable ArrayList<String> suggestions, boolean containsGenerated) {
 		set(suggestions, 0, containsGenerated);
 	}
 
 
-	public void set(ArrayList<String> suggestions, int selectIndex, boolean containsGenerated) {
-		setVisibility(settings, suggestions, false);
+	public void set(@Nullable ArrayList<String> suggestions, int selectIndex, boolean containsGenerated) {
+		setVisibility(settings, suggestions == null || suggestions.isEmpty(), false);
 		if (suggestionBar != null) {
 			suggestionBar.setMany(suggestions, selectIndex, containsGenerated);
 		}
 	}
 
 
-	public void setClipboardItems(LinkedList<CharSequence> clips) {
+	public void setClipboardItems(@NonNull LinkedList<CharSequence> clips) {
 		ArrayList<String> clipStrings = new ArrayList<>(clips.size());
 		for (int i = clips.size() - 1; i >= 0; i--) {
 			String preview = Clipboard.getPreview(i, SuggestionsBar.CLIPBOARD_SUGGESTION_SUFFIX);
@@ -138,7 +138,7 @@ public void setClipboardItems(LinkedList<CharSequence> clips) {
 			}
 		}
 
-		setVisibility(settings, clipStrings, true);
+		setVisibility(settings, clipStrings.isEmpty(), true);
 		if (suggestionBar != null) {
 			suggestionBar.setMany(clipStrings, 0, false);
 		}
@@ -296,15 +296,15 @@ public void setColorScheme() {
 	}
 
 
-	private void setVisibility(@Nullable SettingsStore settings, @Nullable ArrayList<String> newSuggestions, boolean forceVisible) {
+	private void setVisibility(@Nullable SettingsStore settings, boolean willBeEmpty, boolean forceVisible) {
 		final boolean areSuggestionsVisible = isInputLimited || forceVisible || (settings != null && settings.getShowSuggestions());
 
 		if (suggestionBar != null) {
 			suggestionBar.setVisible(areSuggestionsVisible);
 		}
 
 		if (statusBar != null) {
-			statusBar.setShown(newSuggestions == null || newSuggestions.isEmpty() || !areSuggestionsVisible);
+			statusBar.setShown(willBeEmpty || !areSuggestionsVisible);
 		}
 	}
 }