Add virtual destructors to classes with virtual functions and no declared destructor. (#1257)

Author: leekillough

src/sst/core/eli/elementbuilder.h

@@ -27,6 +27,8 @@ struct Builder
 
     template <class NewBase>
     using ChangeBase = Builder<NewBase, Args...>;
+
+    virtual ~Builder() = default;
 };
 
 template <class Base, class... CtorArgs>

src/sst/core/link.h

@@ -111,6 +111,8 @@ class alignas(64) Link
            @param key Key that would be passed into the eventSent() function.
          */
         virtual void serializeEventAttachPointKey(SST::Core::Serialization::serializer& ser, uintptr_t& key);
+
+        virtual ~AttachPoint() = default;
     };
 
     friend class LinkPair;

src/sst/core/model/element_python.h

@@ -117,6 +117,8 @@ class SSTElementPythonModuleCode
      *  \return full name of module as a string
      */
     std::string getFullModuleName();
+
+    virtual ~SSTElementPythonModuleCode() = default;
 };
 
 /**

src/sst/core/realtimeAction.h

@@ -34,6 +34,7 @@ class RealTimeAction
 
 
     RealTimeAction();
+    virtual ~RealTimeAction() = default;
 
     /* Optional function called just before run loop starts. Passes in
      * the next scheduled time of the event or 0 if the event is not

src/sst/core/ssthandler.h

@@ -470,6 +470,8 @@ class SSTHandlerBase<void, argT> : public SST::Core::Serialization::serializable
         virtual void
         serializeHandlerInterceptPointKey(SST::Core::Serialization::serializer& UNUSED(ser), uintptr_t& UNUSED(key))
         {}
+
+        virtual ~InterceptPoint() = default;
     };
 
 private:

src/sst/core/statapi/statbase.h

@@ -342,6 +342,8 @@ struct StatisticCollector<T, true>
             addData_impl(data);
         }
     }
+
+    virtual ~StatisticCollector() = default;
 };
 
 template <class... Args>
@@ -367,6 +369,8 @@ struct StatisticCollector<std::tuple<Args...>, false>
     {
         addData_impl(std::make_tuple(std::forward<InArgs>(args)...));
     }
+
+    virtual ~StatisticCollector() = default;
 };
 
 ////////////////////////////////////////////////////////////////////////////////