Skip to content

Commit 190a389

Browse files
committed
Add override to overriden virtual functions
1 parent 8cce3d5 commit 190a389

14 files changed

+36
-28
lines changed

src/sst/core/componentExtension.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class ComponentExtension : public BaseComponent
3131
public:
3232
ComponentExtension(ComponentId_t id);
3333

34-
virtual ~ComponentExtension() {};
34+
virtual ~ComponentExtension() override = default;
3535

3636
private:
3737
// For serialization only

src/sst/core/impl/timevortex/timeVortexPQ.cc

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,10 @@ class TimeVortexPQ : public TimeVortexPQBase<false>
153153
TimeVortexPQ() : TimeVortexPQBase<false>() {} // For serialization only
154154
~TimeVortexPQ() {}
155155

156-
void serialize_order(SST::Core::Serialization::serializer& ser) { TimeVortexPQBase<false>::serialize_order(ser); }
156+
void serialize_order(SST::Core::Serialization::serializer& ser) override
157+
{
158+
TimeVortexPQBase<false>::serialize_order(ser);
159+
}
157160

158161
SST_ELI_EXPORT(TimeVortexPQ)
159162
};
@@ -175,7 +178,10 @@ class TimeVortexPQ_ts : public TimeVortexPQBase<true>
175178
TimeVortexPQ_ts() : TimeVortexPQBase<true>() {} // For serialization only
176179
~TimeVortexPQ_ts() {}
177180
178-
void serialize_order(SST::Core::Serialization::serializer& ser) { TimeVortexPQBase<true>::serialize_order(ser); }
181+
void serialize_order(SST::Core::Serialization::serializer& ser) override
182+
{
183+
TimeVortexPQBase<true>::serialize_order(ser);
184+
}
179185
180186
SST_ELI_EXPORT(TimeVortexPQ_ts)
181187
};

src/sst/core/interfaces/stdMem.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1272,7 +1272,10 @@ class StandardMem : public SubComponent
12721272
/**
12731273
* Serialization function
12741274
*/
1275-
virtual void serialize_order(SST::Core::Serialization::serializer& ser) { SST::SubComponent::serialize_order(ser); }
1275+
void serialize_order(SST::Core::Serialization::serializer& ser) override
1276+
{
1277+
SST::SubComponent::serialize_order(ser);
1278+
}
12761279
};
12771280

12781281
} // namespace SST::Interfaces

src/sst/core/model/python/pymodel_comp.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,13 @@ struct PyComponent : ComponentHolder
5151
uint16_t subCompId;
5252

5353
PyComponent(ComponentPy_t* pobj, SST::ComponentId_t id) : ComponentHolder(pobj, id), subCompId(0) {}
54-
~PyComponent() {}
54+
~PyComponent() override = default;
5555
};
5656

5757
struct PySubComponent : ComponentHolder
5858
{
5959
PySubComponent(ComponentPy_t* pobj, SST::ComponentId_t id) : ComponentHolder(pobj, id) {}
60-
~PySubComponent() {}
60+
~PySubComponent() override = default;
6161
int getSlot();
6262
};
6363

src/sst/core/statapi/stataccumulator.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ class AccumulatorStatistic : public Statistic<NumberBase>
6969

7070
virtual const std::string& getStatTypeName() const override { return stat_type_; }
7171

72-
7372
void serialize_order(SST::Core::Serialization::serializer& ser) override
7473
{
7574
SST::Statistics::Statistic<NumberBase>::serialize_order(ser);

src/sst/core/testElements/coreTest_ClockerComponent.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ class coreTestClockerComponent : public SST::Component
4747
)
4848

4949
coreTestClockerComponent(SST::ComponentId_t id, SST::Params& params);
50-
void setup() {}
51-
void finish() {}
50+
void setup() override {}
51+
void finish() override {}
5252

5353
private:
5454
coreTestClockerComponent(); // for serialization only

src/sst/core/testElements/coreTest_DistribComponent.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ class coreTestDistribComponent : public SST::Component
5757
)
5858

5959
coreTestDistribComponent(SST::ComponentId_t id, SST::Params& params);
60-
void finish();
61-
void setup() {}
60+
void finish() override;
61+
void setup() override {}
6262

6363
private:
6464
coreTestDistribComponent(); // for serialization only

src/sst/core/testElements/coreTest_Links.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ class coreTestLinks : public SST::Component
5353
coreTestLinks(SST::ComponentId_t id, SST::Params& params);
5454
~coreTestLinks();
5555

56-
void setup() {}
57-
void finish() {}
56+
void setup() override {}
57+
void finish() override {}
5858

5959
private:
6060
int my_id;

src/sst/core/testElements/coreTest_MessageGeneratorComponent.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ class coreTestMessageGeneratorComponent : public SST::Component
5050
)
5151

5252
coreTestMessageGeneratorComponent(SST::ComponentId_t id, SST::Params& params);
53-
void setup() {}
54-
void finish()
53+
void setup() override {}
54+
void finish() override
5555
{
5656
fprintf(stdout, "Component completed at: %" PRIu64 " milliseconds\n", (uint64_t)getCurrentSimTimeMilli());
5757
}

src/sst/core/testElements/coreTest_ParamComponent.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ class coreTestParamComponent : public SST::Component
5858

5959
coreTestParamComponent(SST::ComponentId_t id, SST::Params& params);
6060
~coreTestParamComponent() {}
61-
void setup() {}
62-
void finish() {}
61+
void setup() override {}
62+
void finish() override {}
6363

6464
private:
6565
coreTestParamComponent(); // for serialization only

0 commit comments

Comments
 (0)