Fix some warnings found in gcc 8.5-14.2 (#1316)

* Addresses some compile warnings under gcc 8.5-14.2

Author: gvoskuilen

src/sst/core/action.h

@@ -29,7 +29,7 @@ class Action : public Activity
     Action() {}
     ~Action() {}
 
-    bool isAction() final { return true; }
+    bool isAction() override final { return true; }
 
 protected:
     /** Called to signal to the Simulation object to end the simulation */

src/sst/core/baseComponent.cc

@@ -457,7 +457,7 @@ Link*
 BaseComponent::configureSelfLink(const std::string& name, TimeConverter* time_base, Event::HandlerBase* handler)
 {
     addSelfLink(name);
-    return configureLink(name, time_base, handler);
+    return configureLink(name, *time_base, handler);
 }
 
 Link*

src/sst/core/clock.h

@@ -66,7 +66,8 @@ class Clock : public Action
        handler will be left in the clock list.
      */
     template <typename classT, typename dataT = void>
-    using Handler = SSTHandler<bool, Cycle_t, classT, dataT>;
+    using Handler [[deprecated("Handler has been deprecated. Please use Handler2 as it supports checkpointing.")]] =
+        SSTHandler<bool, Cycle_t, classT, dataT>;
 
     /**
        New style (checkpointable) SSTHandler

src/sst/core/event.h

@@ -58,7 +58,10 @@ class Event : public Activity
          new Event::Handler<classname, dataT>(this, &classname::function_name, data)
      */
     template <typename classT, typename dataT = void>
-    using Handler = SSTHandler<void, Event*, classT, dataT>;
+    using Handler
+        [[deprecated("Handler has been deprecated. Please use Handler2 instead as it supports checkpointing.")]] =
+            SSTHandler<void, Event*, classT, dataT>;
+
 
     /**
        New style (checkpointable) SSTHandler
@@ -119,9 +122,9 @@ class Event : public Activity
 
 #endif
 
-    bool isEvent() final { return true; }
+    bool isEvent() override final { return true; }
 
-    void copyAllDeliveryInfo(const Activity* act) final
+    void copyAllDeliveryInfo(const Activity* act) override final
     {
         Activity::copyAllDeliveryInfo(act);
         const Event* ev = static_cast<const Event*>(act);

src/sst/core/interfaces/simpleNetwork.h

@@ -213,7 +213,8 @@ class SimpleNetwork : public SubComponent
        handler will be removed from the clock list.
     */
     template <typename classT, typename dataT = void>
-    using Handler = SSTHandler<bool, int, classT, dataT>;
+    using Handler [[deprecated("Handler has been deprecated. Please use Handler2 as it supports checkpointing.")]] =
+        SSTHandler<bool, int, classT, dataT>;
 
     /**
        Used to create checkpointable handlers to notify the endpoint

src/sst/core/interfaces/stdMem.h

@@ -97,7 +97,9 @@ class StandardMem : public SubComponent
          new stdMem::Handler<classname, dataT>(this, &classname::function_name, data)
      */
     template <typename classT, typename dataT = void>
-    using Handler = SSTHandler<void, Request*, classT, dataT>;
+    using Handler
+        [[deprecated("Handler has been deprecated. Please use Handler2 instead as it supports checkpointing.")]] =
+            SSTHandler<void, Request*, classT, dataT>;
 
     /**
        Used to create checkpointable handlers for request handling.

src/sst/core/oneshot.h

@@ -59,7 +59,9 @@ class OneShot : public Action
          new OneShot::Handler<classname, dataT>(this, &classname::function_name, data)
      */
     template <typename classT, typename dataT = void>
-    using Handler = SSTHandlerNoArgs<void, classT, dataT>;
+    using Handler
+        [[deprecated("Handler has been deprecated. Please use Handler2 instead as it supports checkpointing.")]] =
+            SSTHandlerNoArgs<void, classT, dataT>;
 
     /**
        Used to create checkpointable handlers for OneShot.  The callback function is

src/sst/core/serialization/impl/serialize_insertable.h

@@ -210,12 +210,14 @@ class serialize_impl<OBJ, std::enable_if_t<is_insertable_v<OBJ>>>
                         is_same_type_template_v<OBJ, std::unordered_multiset> ) {
                         typename OBJ::key_type key {};
                         // TODO: Figure out how to make as_ptr_elem work with sets
-                        SST_SER(key);
+                        opts = SerOption::none;
+                        SST_SER(key, opts);
                         obj.emplace(std::move(key));
                     }
                     else if constexpr ( is_vector_bool_v<OBJ> ) {
                         bool value {};
-                        SST_SER(value);
+                        opts = SerOption::none;
+                        SST_SER(value, opts);
                         obj.push_back(value);
                     }
                     else { // std::vector, std::deque, std::list

src/sst/core/serialization/objectMap.h

@@ -820,7 +820,7 @@ class ObjectMapContainer : public ObjectMapWithChildren
     T* addr_;
 
 public:
-    bool isContainer() final { return true; }
+    bool isContainer() override final { return true; }
 
     std::string getType() override { return demangle_name(typeid(T).name()); }
 

src/sst/core/ssthandler.h

@@ -1129,9 +1129,7 @@ using SSTHandlerBaseNoArgs = SSTHandlerBase<returnT, void>;
  * Handler class with user-data argument
  */
 template <typename returnT, typename argT, typename classT, typename dataT = void>
-class [[deprecated(
-    "Handler has been deprecated.  Please use Handler2 instead as it supports checkpointing")]] SSTHandler :
-    public SSTHandlerBase<returnT, argT>
+class SSTHandler : public SSTHandlerBase<returnT, argT>
 {
 private:
     using PtrMember = returnT (classT::*)(argT, dataT);
@@ -1165,8 +1163,7 @@ class [[deprecated(
  * Event Handler class with no user-data.
  */
 template <typename returnT, typename argT, typename classT>
-class [[deprecated("Handler has been deprecated.  Please use Handler2 instead as it supports "
-                   "checkpointing")]] SSTHandler<returnT, argT, classT, void> : public SSTHandlerBase<returnT, argT>
+class SSTHandler<returnT, argT, classT, void> : public SSTHandlerBase<returnT, argT>
 {
 private:
     using PtrMember = returnT (classT::*)(argT);
@@ -1194,9 +1191,7 @@ class [[deprecated("Handler has been deprecated.  Please use Handler2 instead as
  * Event Handler class with user-data argument
  */
 template <typename returnT, typename classT, typename dataT = void>
-class [[deprecated(
-    "Handler has been deprecated.  Please use Handler2 instead as it supports checkpointing")]] SSTHandlerNoArgs :
-    public SSTHandlerBaseNoArgs<returnT>
+class SSTHandlerNoArgs : public SSTHandlerBaseNoArgs<returnT>
 {
 private:
     using PtrMember = returnT (classT::*)(dataT);
@@ -1230,8 +1225,7 @@ class [[deprecated(
  * Event Handler class with no user-data.
  */
 template <typename returnT, typename classT>
-class [[deprecated("Handler has been deprecated.  Please use Handler2 instead as it supports "
-                   "checkpointing")]] SSTHandlerNoArgs<returnT, classT, void> : public SSTHandlerBaseNoArgs<returnT>
+class SSTHandlerNoArgs<returnT, classT, void> : public SSTHandlerBaseNoArgs<returnT>
 {
 private:
     using PtrMember = returnT (classT::*)();