For default constructors with all bases and class members default-initialized

and an empty constructor body, and for destructors with an empty body, move the
definiton from the .cc file to the .h file with a = default definition.

Default constructors and destructors defined with empty bodies in the header
could be replaced with = default which is more specific than {} and could
conceivably be more optimized. To minimize diffs, these {} default constructors
and destructors in headers were left alone. Only if they were newly added or
moved from .cc to .h files, was = default used instead of {}.

Author: leekillough

src/sst/core/baseComponent.cc

@@ -35,8 +35,6 @@
 
 namespace SST {
 
-BaseComponent::BaseComponent() : SST::Core::Serialization::serializable_base() {}
-
 BaseComponent::BaseComponent(ComponentId_t id) :
     SST::Core::Serialization::serializable_base(),
     my_info(Simulation_impl::getSimulation()->getComponentInfo(id)),

src/sst/core/baseComponent.h

@@ -70,8 +70,7 @@ class BaseComponent : public SST::Core::Serialization::serializable_base
         BaseComponent*, Statistics::StatisticProcessingEngine*, const std::string& /*type*/,
         const std::string& /*name*/, const std::string& /*subId*/, Params&)>;
 
-    // For serialization only
-    BaseComponent();
+    BaseComponent() = default; // For serialization only
 
 public:
     BaseComponent(ComponentId_t id);

src/sst/core/checkpointAction.cc

@@ -62,8 +62,6 @@ CheckpointAction::CheckpointAction(
     setPriority(SYNCPRIORITY);
 }
 
-CheckpointAction::~CheckpointAction() {}
-
 // Generate checkpoint on simulation time period
 void
 CheckpointAction::execute()

src/sst/core/checkpointAction.h

@@ -64,7 +64,7 @@ class CheckpointAction : public Action
     Create a new checkpoint object for the simulation core to initiate checkpoints
     */
     CheckpointAction(Config* cfg, RankInfo this_rank, Simulation_impl* sim, TimeConverter* period);
-    ~CheckpointAction();
+    ~CheckpointAction() = default;
 
     /** Generate a checkpoint next time check() is called */
     void setCheckpoint();

src/sst/core/component.cc

@@ -30,8 +30,6 @@ Component::Component(ComponentId_t id) : BaseComponent(id)
     // currentlyLoadingSubComponent = my_info;
 }
 
-Component::~Component() {}
-
 void
 Component::registerAsPrimaryComponent()
 {
@@ -59,7 +57,4 @@ Component::serialize_order(SST::Core::Serialization::serializer& ser)
     BaseComponent::serialize_order(ser);
 }
 
-// For serialization only
-Component::Component() : BaseComponent() {}
-
 } // namespace SST

src/sst/core/component.h

@@ -48,7 +48,7 @@ class Component : public BaseComponent
         @param id Unique component ID
     */
     Component(ComponentId_t id);
-    virtual ~Component();
+    virtual ~Component() override = default;
 
     /** Register as a primary component, which allows the component to
         specify when it is and is not OK to end simulation.  The
@@ -97,9 +97,7 @@ class Component : public BaseComponent
 
 protected:
     friend class SubComponent;
-
-    // For Serialization only
-    Component();
+    Component() = default; // For Serialization only
 };
 
 } // namespace SST

src/sst/core/componentExtension.cc

@@ -26,7 +26,4 @@ ComponentExtension::serialize_order(SST::Core::Serialization::serializer& ser)
     BaseComponent::serialize_order(ser);
 }
 
-// For serialization only
-ComponentExtension::ComponentExtension() : BaseComponent() {}
-
 } // namespace SST

src/sst/core/componentExtension.h

@@ -31,11 +31,10 @@ class ComponentExtension : public BaseComponent
 public:
     ComponentExtension(ComponentId_t id);
 
-    virtual ~ComponentExtension() {};
+    virtual ~ComponentExtension() override = default;
 
 private:
-    // For serialization only
-    ComponentExtension();
+    ComponentExtension() = default; // For serialization only
 
     ImplementSerializable(SST::ComponentExtension)
     void serialize_order(SST::Core::Serialization::serializer& ser) override;

src/sst/core/event.cc

@@ -23,8 +23,6 @@ namespace SST {
 std::atomic<uint64_t>     SST::Event::id_counter(0);
 const SST::Event::id_type SST::Event::NO_ID = std::make_pair(0, -1);
 
-Event::~Event() {}
-
 void
 Event::execute()
 {

src/sst/core/event.h

@@ -79,7 +79,7 @@ class Event : public Activity
         last_comp  = "";
 #endif
     }
-    virtual ~Event();
+    ~Event() override = default;
 
     /** Clones the event in for the case of a broadcast */
     virtual Event* clone();